Skip to content

Upload code coverage to Datadog #9132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 10, 2025
Merged

Upload code coverage to Datadog #9132

merged 6 commits into from
Jul 10, 2025

Conversation

nikita-tkachenko-datadog
Copy link
Contributor

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Jul 9, 2025 •
edited
Loading

What Does This Do

Configures uploading code coverage data to Datadog.

Motivation

Dogfooding new Code Coverage product.

Contributor Checklist

Jira ticket: [PROJ-IDENT]
@pr-commenter
Copy link

pr-commenter bot commented Jul 9, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/code-coverage-upload
git_commit_date 1752144925 1752150815
git_commit_sha be7f9d3 b4c50a4
release_version 1.52.0-SNAPSHOT~be7f9d370d 1.51.0-SNAPSHOT~b4c50a43a1
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1752152637 1752152637
ci_job_id 1022668417 1022668417
ci_pipeline_id 70167173 70167173
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-s5evx4p8 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-s5evx4p8 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 9 unstable metrics.

Startup time reports for petclinic 
gantt title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~b4c50a43a1, baseline=1.52.0-SNAPSHOT~be7f9d370d dateFormat X axisFormat %s section tracing Agent [baseline] (996.018 ms) : 0, 996018 Total [baseline] (10.631 s) : 0, 10631295 Agent [candidate] (994.652 ms) : 0, 994652 Total [candidate] (10.664 s) : 0, 10664289 section appsec Agent [baseline] (1.175 s) : 0, 1174619 Total [baseline] (10.778 s) : 0, 10777978 Agent [candidate] (1.174 s) : 0, 1174233 Total [candidate] (10.756 s) : 0, 10756430 section iast Agent [baseline] (1.14 s) : 0, 1140051 Total [baseline] (11.008 s) : 0, 11007520 Agent [candidate] (1.135 s) : 0, 1134859 Total [candidate] (10.868 s) : 0, 10867839 section profiling Agent [baseline] (1.246 s) : 0, 1246040 Total [baseline] (10.989 s) : 0, 10988923 Agent [candidate] (1.245 s) : 0, 1244910 Total [candidate] (10.991 s) : 0, 10990915
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 996.018 ms -
Agent appsec 1.175 s 178.6 ms (17.9%)
Agent iast 1.14 s 144.033 ms (14.5%)
Agent profiling 1.246 s 250.022 ms (25.1%)
Total tracing 10.631 s -
Total appsec 10.778 s 146.683 ms (1.4%)
Total iast 11.008 s 376.224 ms (3.5%)
Total profiling 10.989 s 357.628 ms (3.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 994.652 ms -
Agent appsec 1.174 s 179.581 ms (18.1%)
Agent iast 1.135 s 140.207 ms (14.1%)
Agent profiling 1.245 s 250.258 ms (25.2%)
Total tracing 10.664 s -
Total appsec 10.756 s 92.14 ms (0.9%)
Total iast 10.868 s 203.55 ms (1.9%)
Total profiling 10.991 s 326.626 ms (3.1%) 
gantt title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~b4c50a43a1, baseline=1.52.0-SNAPSHOT~be7f9d370d dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (688.163 ms) : 0, 688163 BytebuddyAgent [candidate] (687.017 ms) : 0, 687017 GlobalTracer [baseline] (241.837 ms) : 0, 241837 GlobalTracer [candidate] (242.067 ms) : 0, 242067 AppSec [baseline] (30.276 ms) : 0, 30276 AppSec [candidate] (30.044 ms) : 0, 30044 Debugger [baseline] (5.987 ms) : 0, 5987 Debugger [candidate] (5.977 ms) : 0, 5977 Remote Config [baseline] (672.367 µs) : 0, 672 Remote Config [candidate] (673.461 µs) : 0, 673 Telemetry [baseline] (8.224 ms) : 0, 8224 Telemetry [candidate] (8.171 ms) : 0, 8171 section appsec BytebuddyAgent [baseline] (709.495 ms) : 0, 709495 BytebuddyAgent [candidate] (710.165 ms) : 0, 710165 GlobalTracer [baseline] (234.809 ms) : 0, 234809 GlobalTracer [candidate] (235.169 ms) : 0, 235169 AppSec [baseline] (171.421 ms) : 0, 171421 AppSec [candidate] (170.263 ms) : 0, 170263 Debugger [baseline] (5.767 ms) : 0, 5767 Debugger [candidate] (5.729 ms) : 0, 5729 Remote Config [baseline] (615.4 µs) : 0, 615 Remote Config [candidate] (607.022 µs) : 0, 607 Telemetry [baseline] (8.132 ms) : 0, 8132 Telemetry [candidate] (8.129 ms) : 0, 8129 IAST [baseline] (23.546 ms) : 0, 23546 IAST [candidate] (23.297 ms) : 0, 23297 section iast BytebuddyAgent [baseline] (812.776 ms) : 0, 812776 BytebuddyAgent [candidate] (808.739 ms) : 0, 808739 GlobalTracer [baseline] (233.553 ms) : 0, 233553 GlobalTracer [candidate] (233.123 ms) : 0, 233123 AppSec [baseline] (27.555 ms) : 0, 27555 AppSec [candidate] (31.576 ms) : 0, 31576 Debugger [baseline] (6.725 ms) : 0, 6725 Debugger [candidate] (5.777 ms) : 0, 5777 Remote Config [baseline] (589.021 µs) : 0, 589 Remote Config [candidate] (584.756 µs) : 0, 585 Telemetry [baseline] (7.996 ms) : 0, 7996 Telemetry [candidate] (8.062 ms) : 0, 8062 IAST [baseline] (30.045 ms) : 0, 30045 IAST [candidate] (26.194 ms) : 0, 26194 section profiling ProfilingAgent [baseline] (104.15 ms) : 0, 104150 ProfilingAgent [candidate] (103.644 ms) : 0, 103644 BytebuddyAgent [baseline] (678.554 ms) : 0, 678554 BytebuddyAgent [candidate] (677.531 ms) : 0, 677531 GlobalTracer [baseline] (361.731 ms) : 0, 361731 GlobalTracer [candidate] (361.864 ms) : 0, 361864 AppSec [baseline] (33.686 ms) : 0, 33686 AppSec [candidate] (31.032 ms) : 0, 31032 Debugger [baseline] (9.16 ms) : 0, 9160 Debugger [candidate] (10.642 ms) : 0, 10642 Remote Config [baseline] (674.437 µs) : 0, 674 Remote Config [candidate] (673.458 µs) : 0, 673 Telemetry [baseline] (9.449 ms) : 0, 9449 Telemetry [candidate] (10.969 ms) : 0, 10969 Profiling [baseline] (104.174 ms) : 0, 104174 Profiling [candidate] (103.669 ms) : 0, 103669
Loading
Startup time reports for insecure-bank 
gantt title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~b4c50a43a1, baseline=1.52.0-SNAPSHOT~be7f9d370d dateFormat X axisFormat %s section tracing Agent [baseline] (994.811 ms) : 0, 994811 Total [baseline] (8.569 s) : 0, 8569279 Agent [candidate] (994.367 ms) : 0, 994367 Total [candidate] (8.545 s) : 0, 8544635 section iast Agent [baseline] (1.131 s) : 0, 1130688 Total [baseline] (9.303 s) : 0, 9303453 Agent [candidate] (1.131 s) : 0, 1131268 Total [candidate] (9.253 s) : 0, 9253401
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 994.811 ms -
Agent iast 1.131 s 135.877 ms (13.7%)
Total tracing 8.569 s -
Total iast 9.303 s 734.174 ms (8.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 994.367 ms -
Agent iast 1.131 s 136.901 ms (13.8%)
Total tracing 8.545 s -
Total iast 9.253 s 708.766 ms (8.3%) 
gantt title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~b4c50a43a1, baseline=1.52.0-SNAPSHOT~be7f9d370d dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (686.79 ms) : 0, 686790 BytebuddyAgent [candidate] (686.773 ms) : 0, 686773 GlobalTracer [baseline] (242.069 ms) : 0, 242069 GlobalTracer [candidate] (241.762 ms) : 0, 241762 AppSec [baseline] (30.287 ms) : 0, 30287 AppSec [candidate] (30.252 ms) : 0, 30252 Debugger [baseline] (6.017 ms) : 0, 6017 Debugger [candidate] (5.956 ms) : 0, 5956 Remote Config [baseline] (682.56 µs) : 0, 683 Remote Config [candidate] (675.581 µs) : 0, 676 Telemetry [baseline] (8.235 ms) : 0, 8235 Telemetry [candidate] (8.211 ms) : 0, 8211 section iast BytebuddyAgent [baseline] (806.145 ms) : 0, 806145 BytebuddyAgent [candidate] (806.627 ms) : 0, 806627 GlobalTracer [baseline] (231.853 ms) : 0, 231853 GlobalTracer [candidate] (232.111 ms) : 0, 232111 IAST [baseline] (26.472 ms) : 0, 26472 IAST [candidate] (26.238 ms) : 0, 26238 AppSec [baseline] (30.485 ms) : 0, 30485 AppSec [candidate] (31.435 ms) : 0, 31435 Debugger [baseline] (6.589 ms) : 0, 6589 Debugger [candidate] (5.729 ms) : 0, 5729 Remote Config [baseline] (576.818 µs) : 0, 577 Remote Config [candidate] (582.83 µs) : 0, 583 Telemetry [baseline] (7.892 ms) : 0, 7892 Telemetry [candidate] (7.919 ms) : 0, 7919
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/code-coverage-upload
git_commit_date 1752144925 1752150815
git_commit_sha be7f9d3 b4c50a4
release_version 1.52.0-SNAPSHOT~be7f9d370d 1.51.0-SNAPSHOT~b4c50a43a1
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1752152319 1752152319
ci_job_id 1022668418 1022668418
ci_pipeline_id 70167173 70167173
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-cr8p5t1c 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-cr8p5t1c 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling:high_load worse
[+1.102ms; +2.074ms] or [+2.288%; +4.304%]		 unstable
[-10.081op/s; +3.831op/s] or [-10.380%; +3.945%]		 49.771ms 94.000op/s 48.183ms 97.125op/s
scenario:load:petclinic:appsec:high_load better
[-3.369ms; -2.449ms] or [-6.839%; -4.971%]		 unstable
[-1.916op/s; +11.361op/s] or [-1.992%; +11.812%]		 46.350ms 100.912op/s 49.259ms 96.190op/s
scenario:load:petclinic:tracing:high_load worse
[+2.349ms; +3.146ms] or [+5.519%; +7.391%]		 unstable
[-14.173op/s; +0.973op/s] or [-12.892%; +0.885%]		 45.306ms 103.338op/s 42.559ms 109.938op/s
Request duration reports for petclinic 
gantt title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~b4c50a43a1, baseline=1.52.0-SNAPSHOT~be7f9d370d dateFormat X axisFormat %s section baseline no_agent (37.248 ms) : 36941, 37555 . : milestone, 37248, appsec (49.259 ms) : 48812, 49706 . : milestone, 49259, code_origins (44.627 ms) : 44238, 45016 . : milestone, 44627, iast (44.863 ms) : 44475, 45251 . : milestone, 44863, profiling (48.183 ms) : 47750, 48616 . : milestone, 48183, tracing (42.559 ms) : 42205, 42912 . : milestone, 42559, section candidate no_agent (36.802 ms) : 36504, 37100 . : milestone, 36802, appsec (46.35 ms) : 45943, 46758 . : milestone, 46350, code_origins (45.191 ms) : 44813, 45570 . : milestone, 45191, iast (43.775 ms) : 43401, 44149 . : milestone, 43775, profiling (49.771 ms) : 49301, 50241 . : milestone, 49771, tracing (45.306 ms) : 44919, 45693 . : milestone, 45306,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 37.248 ms [36.941 ms, 37.555 ms] -
appsec 49.259 ms [48.812 ms, 49.706 ms] 12.011 ms (32.2%)
code_origins 44.627 ms [44.238 ms, 45.016 ms] 7.379 ms (19.8%)
iast 44.863 ms [44.475 ms, 45.251 ms] 7.615 ms (20.4%)
profiling 48.183 ms [47.75 ms, 48.616 ms] 10.935 ms (29.4%)
tracing 42.559 ms [42.205 ms, 42.912 ms] 5.311 ms (14.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 36.802 ms [36.504 ms, 37.1 ms] -
appsec 46.35 ms [45.943 ms, 46.758 ms] 9.548 ms (25.9%)
code_origins 45.191 ms [44.813 ms, 45.57 ms] 8.389 ms (22.8%)
iast 43.775 ms [43.401 ms, 44.149 ms] 6.973 ms (18.9%)
profiling 49.771 ms [49.301 ms, 50.241 ms] 12.969 ms (35.2%)
tracing 45.306 ms [44.919 ms, 45.693 ms] 8.504 ms (23.1%)
Request duration reports for insecure-bank 
gantt title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~b4c50a43a1, baseline=1.52.0-SNAPSHOT~be7f9d370d dateFormat X axisFormat %s section baseline no_agent (4.2 ms) : 4150, 4249 . : milestone, 4200, iast (9.316 ms) : 9159, 9472 . : milestone, 9316, iast_FULL (13.824 ms) : 13549, 14099 . : milestone, 13824, iast_GLOBAL (10.287 ms) : 10084, 10490 . : milestone, 10287, profiling (8.626 ms) : 8476, 8776 . : milestone, 8626, tracing (7.612 ms) : 7504, 7719 . : milestone, 7612, section candidate no_agent (4.313 ms) : 4264, 4362 . : milestone, 4313, iast (9.52 ms) : 9358, 9681 . : milestone, 9520, iast_FULL (13.584 ms) : 13311, 13857 . : milestone, 13584, iast_GLOBAL (10.372 ms) : 10191, 10553 . : milestone, 10372, profiling (8.56 ms) : 8426, 8693 . : milestone, 8560, tracing (7.495 ms) : 7382, 7608 . : milestone, 7495,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.2 ms [4.15 ms, 4.249 ms] -
iast 9.316 ms [9.159 ms, 9.472 ms] 5.116 ms (121.8%)
iast_FULL 13.824 ms [13.549 ms, 14.099 ms] 9.624 ms (229.2%)
iast_GLOBAL 10.287 ms [10.084 ms, 10.49 ms] 6.087 ms (145.0%)
profiling 8.626 ms [8.476 ms, 8.776 ms] 4.426 ms (105.4%)
tracing 7.612 ms [7.504 ms, 7.719 ms] 3.412 ms (81.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.313 ms [4.264 ms, 4.362 ms] -
iast 9.52 ms [9.358 ms, 9.681 ms] 5.207 ms (120.7%)
iast_FULL 13.584 ms [13.311 ms, 13.857 ms] 9.271 ms (215.0%)
iast_GLOBAL 10.372 ms [10.191 ms, 10.553 ms] 6.059 ms (140.5%)
profiling 8.56 ms [8.426 ms, 8.693 ms] 4.247 ms (98.5%)
tracing 7.495 ms [7.382 ms, 7.608 ms] 3.182 ms (73.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/code-coverage-upload
git_commit_date 1752144925 1752150815
git_commit_sha be7f9d3 b4c50a4
release_version 1.52.0-SNAPSHOT~be7f9d370d 1.51.0-SNAPSHOT~b4c50a43a1
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1752152822 1752152822
ci_job_id 1022668419 1022668419
ci_pipeline_id 70167173 70167173
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-ccqz41af 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-ccqz41af 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~b4c50a43a1, baseline=1.52.0-SNAPSHOT~be7f9d370d dateFormat X axisFormat %s section baseline no_agent (14.966 s) : 14966000, 14966000 . : milestone, 14966000, appsec (14.902 s) : 14902000, 14902000 . : milestone, 14902000, iast (18.691 s) : 18691000, 18691000 . : milestone, 18691000, iast_GLOBAL (18.214 s) : 18214000, 18214000 . : milestone, 18214000, profiling (14.931 s) : 14931000, 14931000 . : milestone, 14931000, tracing (14.761 s) : 14761000, 14761000 . : milestone, 14761000, section candidate no_agent (14.848 s) : 14848000, 14848000 . : milestone, 14848000, appsec (14.862 s) : 14862000, 14862000 . : milestone, 14862000, iast (18.441 s) : 18441000, 18441000 . : milestone, 18441000, iast_GLOBAL (18.233 s) : 18233000, 18233000 . : milestone, 18233000, profiling (14.833 s) : 14833000, 14833000 . : milestone, 14833000, tracing (14.807 s) : 14807000, 14807000 . : milestone, 14807000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.966 s [14.966 s, 14.966 s] -
appsec 14.902 s [14.902 s, 14.902 s] -64.0 ms (-0.4%)
iast 18.691 s [18.691 s, 18.691 s] 3.725 s (24.9%)
iast_GLOBAL 18.214 s [18.214 s, 18.214 s] 3.248 s (21.7%)
profiling 14.931 s [14.931 s, 14.931 s] -35.0 ms (-0.2%)
tracing 14.761 s [14.761 s, 14.761 s] -205.0 ms (-1.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.848 s [14.848 s, 14.848 s] -
appsec 14.862 s [14.862 s, 14.862 s] 14.0 ms (0.1%)
iast 18.441 s [18.441 s, 18.441 s] 3.593 s (24.2%)
iast_GLOBAL 18.233 s [18.233 s, 18.233 s] 3.385 s (22.8%)
profiling 14.833 s [14.833 s, 14.833 s] -15.0 ms (-0.1%)
tracing 14.807 s [14.807 s, 14.807 s] -41.0 ms (-0.3%)
Execution time for tomcat 
gantt title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~b4c50a43a1, baseline=1.52.0-SNAPSHOT~be7f9d370d dateFormat X axisFormat %s section baseline no_agent (1.478 ms) : 1466, 1489 . : milestone, 1478, appsec (2.436 ms) : 2385, 2486 . : milestone, 2436, iast (2.218 ms) : 2155, 2281 . : milestone, 2218, iast_GLOBAL (2.255 ms) : 2191, 2318 . : milestone, 2255, profiling (2.044 ms) : 1994, 2094 . : milestone, 2044, tracing (2.024 ms) : 1975, 2072 . : milestone, 2024, section candidate no_agent (1.484 ms) : 1473, 1496 . : milestone, 1484, appsec (2.429 ms) : 2379, 2479 . : milestone, 2429, iast (2.207 ms) : 2145, 2270 . : milestone, 2207, iast_GLOBAL (2.253 ms) : 2191, 2316 . : milestone, 2253, profiling (2.513 ms) : 2338, 2688 . : milestone, 2513, tracing (2.025 ms) : 1977, 2074 . : milestone, 2025,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.478 ms [1.466 ms, 1.489 ms] -
appsec 2.436 ms [2.385 ms, 2.486 ms] 958.047 µs (64.8%)
iast 2.218 ms [2.155 ms, 2.281 ms] 740.1 µs (50.1%)
iast_GLOBAL 2.255 ms [2.191 ms, 2.318 ms] 776.933 µs (52.6%)
profiling 2.044 ms [1.994 ms, 2.094 ms] 566.446 µs (38.3%)
tracing 2.024 ms [1.975 ms, 2.072 ms] 545.864 µs (36.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.484 ms [1.473 ms, 1.496 ms] -
appsec 2.429 ms [2.379 ms, 2.479 ms] 944.758 µs (63.7%)
iast 2.207 ms [2.145 ms, 2.27 ms] 723.231 µs (48.7%)
iast_GLOBAL 2.253 ms [2.191 ms, 2.316 ms] 769.361 µs (51.8%)
profiling 2.513 ms [2.338 ms, 2.688 ms] 1.029 ms (69.3%)
tracing 2.025 ms [1.977 ms, 2.074 ms] 541.162 µs (36.5%)
@nikita-tkachenko-datadog nikita-tkachenko-datadog added comp: testing Testing tag: no release notes Changes to exclude from release notes type: enhancement Enhancements and improvements labels Jul 10, 2025
@nikita-tkachenko-datadog nikita-tkachenko-datadog marked this pull request as ready for review July 10, 2025 11:32
@nikita-tkachenko-datadog nikita-tkachenko-datadog requested a review from a team as a code owner July 10, 2025 11:32
@nikita-tkachenko-datadog nikita-tkachenko-datadog requested review from TonyCTHsu and removed request for a team July 10, 2025 11:32
PerfectSlayer
PerfectSlayer reviewed Jul 10, 2025
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to test it or let's just give it a try?
.gitlab/upload_ciapp.sh
# Upload test results to production environment like all other CI jobs
junit_upload "$DATADOG_API_KEY_PROD"

coverage_upload "$DATADOG_API_KEY_PROD"
Copy link
Contributor

@PerfectSlayer PerfectSlayer Jul 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the script return the result of both upload functions now? Not only the coverage one?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't it just fail if any of the uploads fails?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nevermind, I realised the default is to just continue executing if a command fails. Updated the script to consider both statuses
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment here: https://github.com/DataDog/dd-trace-java/pull/9132/files#r2197581837
@nikita-tkachenko-datadog
Copy link
Contributor Author

Is there a way to test it or let's just give it a try?

It was tested by the CI jobs of this PR :)
bric3
bric3 reviewed Jul 10, 2025
View reviewed changes
.gitlab/upload_ciapp.sh
# Upload test results to production environment like all other CI jobs
junit_upload "$DATADOG_API_KEY_PROD"

coverage_upload "$DATADOG_API_KEY_PROD"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment here: https://github.com/DataDog/dd-trace-java/pull/9132/files#r2197581837
@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit a90ccbc into master Jul 10, 2025
674 of 675 checks passed
@nikita-tkachenko-datadog nikita-tkachenko-datadog deleted the nikita-tkachenko/code-coverage-upload branch July 10, 2025 16:06
@github-actions github-actions bot added this to the 1.52.0 milestone Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: testing Testing tag: no release notes Changes to exclude from release notes type: enhancement Enhancements and improvements

3 participants

@nikita-tkachenko-datadog @bric3 @PerfectSlayer