- Notifications
You must be signed in to change notification settings - Fork 314
Update builder image for JDK 25 EA #9096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update builder image for JDK 25 EA #9096
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 9 unstable metrics. Startup time reports for petclinicgantt title petclinic - global startup overhead: candidate=1.52.0-SNAPSHOT~e177118b38, baseline=1.52.0-SNAPSHOT~89e92d59f6 dateFormat X axisFormat %s section tracing Agent [baseline] (1.031 s) : 0, 1030778 Total [baseline] (10.969 s) : 0, 10968815 Agent [candidate] (1.02 s) : 0, 1019542 Total [candidate] (11.075 s) : 0, 11074686 section appsec Agent [baseline] (1.204 s) : 0, 1203994 Total [baseline] (10.977 s) : 0, 10977064 Agent [candidate] (1.204 s) : 0, 1204061 Total [candidate] (11.042 s) : 0, 11041943 section iast Agent [baseline] (1.162 s) : 0, 1162106 Total [baseline] (11.184 s) : 0, 11184150 Agent [candidate] (1.162 s) : 0, 1161534 Total [candidate] (11.134 s) : 0, 11133506 section profiling Agent [baseline] (1.275 s) : 0, 1275325 Total [baseline] (11.287 s) : 0, 11286600 Agent [candidate] (1.287 s) : 0, 1287048 Total [candidate] (11.364 s) : 0, 11363965
gantt title petclinic - break down per module: candidate=1.52.0-SNAPSHOT~e177118b38, baseline=1.52.0-SNAPSHOT~89e92d59f6 dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (710.258 ms) : 0, 710258 BytebuddyAgent [candidate] (700.85 ms) : 0, 700850 GlobalTracer [baseline] (252.056 ms) : 0, 252056 GlobalTracer [candidate] (250.059 ms) : 0, 250059 AppSec [baseline] (31.624 ms) : 0, 31624 AppSec [candidate] (31.256 ms) : 0, 31256 Debugger [baseline] (6.283 ms) : 0, 6283 Debugger [candidate] (6.283 ms) : 0, 6283 Remote Config [baseline] (722.89 µs) : 0, 723 Remote Config [candidate] (711.361 µs) : 0, 711 Telemetry [baseline] (8.586 ms) : 0, 8586 Telemetry [candidate] (9.299 ms) : 0, 9299 section appsec BytebuddyAgent [baseline] (725.621 ms) : 0, 725621 BytebuddyAgent [candidate] (725.717 ms) : 0, 725717 GlobalTracer [baseline] (242.476 ms) : 0, 242476 GlobalTracer [candidate] (241.97 ms) : 0, 241970 IAST [baseline] (24.061 ms) : 0, 24061 IAST [candidate] (24.173 ms) : 0, 24173 AppSec [baseline] (175.957 ms) : 0, 175957 AppSec [candidate] (176.32 ms) : 0, 176320 Debugger [baseline] (5.807 ms) : 0, 5807 Debugger [candidate] (5.843 ms) : 0, 5843 Remote Config [baseline] (640.71 µs) : 0, 641 Remote Config [candidate] (635.192 µs) : 0, 635 Telemetry [baseline] (8.26 ms) : 0, 8260 Telemetry [candidate] (8.303 ms) : 0, 8303 section iast BytebuddyAgent [baseline] (825.168 ms) : 0, 825168 BytebuddyAgent [candidate] (825.102 ms) : 0, 825102 GlobalTracer [baseline] (240.827 ms) : 0, 240827 GlobalTracer [candidate] (240.652 ms) : 0, 240652 IAST [baseline] (30.144 ms) : 0, 30144 IAST [candidate] (29.209 ms) : 0, 29209 AppSec [baseline] (30.099 ms) : 0, 30099 AppSec [candidate] (30.805 ms) : 0, 30805 Debugger [baseline] (6.006 ms) : 0, 6006 Debugger [candidate] (5.962 ms) : 0, 5962 Remote Config [baseline] (621.272 µs) : 0, 621 Remote Config [candidate] (609.099 µs) : 0, 609 Telemetry [baseline] (8.267 ms) : 0, 8267 Telemetry [candidate] (8.187 ms) : 0, 8187 section profiling BytebuddyAgent [baseline] (692.13 ms) : 0, 692130 BytebuddyAgent [candidate] (698.762 ms) : 0, 698762 GlobalTracer [baseline] (375.312 ms) : 0, 375312 GlobalTracer [candidate] (378.387 ms) : 0, 378387 AppSec [baseline] (34.829 ms) : 0, 34829 AppSec [candidate] (37.164 ms) : 0, 37164 Debugger [baseline] (8.842 ms) : 0, 8842 Debugger [candidate] (8.042 ms) : 0, 8042 Remote Config [baseline] (689.647 µs) : 0, 690 Remote Config [candidate] (706.099 µs) : 0, 706 Telemetry [baseline] (10.583 ms) : 0, 10583 Telemetry [candidate] (9.937 ms) : 0, 9937 ProfilingAgent [baseline] (103.726 ms) : 0, 103726 ProfilingAgent [candidate] (104.821 ms) : 0, 104821 Profiling [baseline] (103.749 ms) : 0, 103749 Profiling [candidate] (104.845 ms) : 0, 104845 Startup time reports for insecure-bankgantt title insecure-bank - global startup overhead: candidate=1.52.0-SNAPSHOT~e177118b38, baseline=1.52.0-SNAPSHOT~89e92d59f6 dateFormat X axisFormat %s section tracing Agent [baseline] (1.016 s) : 0, 1016190 Total [baseline] (9.09 s) : 0, 9090305 Agent [candidate] (1.019 s) : 0, 1019228 Total [candidate] (9.101 s) : 0, 9100581 section iast Agent [baseline] (1.158 s) : 0, 1158240 Total [baseline] (9.824 s) : 0, 9824275 Agent [candidate] (1.158 s) : 0, 1158413 Total [candidate] (9.781 s) : 0, 9780760
gantt title insecure-bank - break down per module: candidate=1.52.0-SNAPSHOT~e177118b38, baseline=1.52.0-SNAPSHOT~89e92d59f6 dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (699.68 ms) : 0, 699680 BytebuddyAgent [candidate] (701.959 ms) : 0, 701959 GlobalTracer [baseline] (248.755 ms) : 0, 248755 GlobalTracer [candidate] (249.571 ms) : 0, 249571 AppSec [baseline] (31.205 ms) : 0, 31205 AppSec [candidate] (31.166 ms) : 0, 31166 Debugger [baseline] (6.306 ms) : 0, 6306 Debugger [candidate] (6.265 ms) : 0, 6265 Remote Config [baseline] (711.012 µs) : 0, 711 Remote Config [candidate] (701.635 µs) : 0, 702 Telemetry [baseline] (8.471 ms) : 0, 8471 Telemetry [candidate] (8.547 ms) : 0, 8547 section iast BytebuddyAgent [baseline] (823.286 ms) : 0, 823286 BytebuddyAgent [candidate] (823.198 ms) : 0, 823198 GlobalTracer [baseline] (239.731 ms) : 0, 239731 GlobalTracer [candidate] (239.966 ms) : 0, 239966 IAST [baseline] (28.915 ms) : 0, 28915 IAST [candidate] (30.684 ms) : 0, 30684 AppSec [baseline] (30.57 ms) : 0, 30570 AppSec [candidate] (28.911 ms) : 0, 28911 Debugger [baseline] (5.964 ms) : 0, 5964 Debugger [candidate] (5.944 ms) : 0, 5944 Remote Config [baseline] (622.297 µs) : 0, 622 Remote Config [candidate] (611.265 µs) : 0, 611 Telemetry [baseline] (8.193 ms) : 0, 8193 Telemetry [candidate] (8.215 ms) : 0, 8215 LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt title petclinic - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~e177118b38, baseline=1.52.0-SNAPSHOT~89e92d59f6 dateFormat X axisFormat %s section baseline no_agent (37.169 ms) : 36863, 37475 . : milestone, 37169, appsec (48.948 ms) : 48513, 49384 . : milestone, 48948, code_origins (45.955 ms) : 45565, 46345 . : milestone, 45955, iast (44.086 ms) : 43699, 44473 . : milestone, 44086, profiling (48.539 ms) : 48091, 48986 . : milestone, 48539, tracing (42.89 ms) : 42544, 43235 . : milestone, 42890, section candidate no_agent (37.374 ms) : 37070, 37677 . : milestone, 37374, appsec (48.275 ms) : 47851, 48698 . : milestone, 48275, code_origins (45.411 ms) : 45034, 45787 . : milestone, 45411, iast (44.042 ms) : 43657, 44428 . : milestone, 44042, profiling (49.173 ms) : 48697, 49649 . : milestone, 49173, tracing (42.549 ms) : 42206, 42892 . : milestone, 42549,
Request duration reports for insecure-bankgantt title insecure-bank - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~e177118b38, baseline=1.52.0-SNAPSHOT~89e92d59f6 dateFormat X axisFormat %s section baseline no_agent (4.32 ms) : 4265, 4374 . : milestone, 4320, iast (9.799 ms) : 9639, 9960 . : milestone, 9799, iast_FULL (14.143 ms) : 13862, 14424 . : milestone, 14143, iast_GLOBAL (10.383 ms) : 10196, 10570 . : milestone, 10383, profiling (8.831 ms) : 8697, 8965 . : milestone, 8831, tracing (7.638 ms) : 7526, 7750 . : milestone, 7638, section candidate no_agent (4.321 ms) : 4272, 4370 . : milestone, 4321, iast (9.291 ms) : 9137, 9444 . : milestone, 9291, iast_FULL (13.57 ms) : 13305, 13836 . : milestone, 13570, iast_GLOBAL (10.187 ms) : 9983, 10391 . : milestone, 10187, profiling (8.96 ms) : 8819, 9101 . : milestone, 8960, tracing (7.481 ms) : 7379, 7584 . : milestone, 7481,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt title tomcat - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~e177118b38, baseline=1.52.0-SNAPSHOT~89e92d59f6 dateFormat X axisFormat %s section baseline no_agent (1.472 ms) : 1460, 1483 . : milestone, 1472, appsec (2.407 ms) : 2356, 2457 . : milestone, 2407, iast (2.199 ms) : 2136, 2261 . : milestone, 2199, iast_GLOBAL (2.243 ms) : 2179, 2306 . : milestone, 2243, profiling (2.06 ms) : 2008, 2112 . : milestone, 2060, tracing (2.012 ms) : 1964, 2061 . : milestone, 2012, section candidate no_agent (1.478 ms) : 1466, 1489 . : milestone, 1478, appsec (2.41 ms) : 2360, 2460 . : milestone, 2410, iast (2.204 ms) : 2142, 2267 . : milestone, 2204, iast_GLOBAL (2.233 ms) : 2170, 2296 . : milestone, 2233, profiling (2.039 ms) : 1989, 2090 . : milestone, 2039, tracing (2.014 ms) : 1966, 2063 . : milestone, 2014,
Execution time for biojavagantt title biojava - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~e177118b38, baseline=1.52.0-SNAPSHOT~89e92d59f6 dateFormat X axisFormat %s section baseline no_agent (15.552 s) : 15552000, 15552000 . : milestone, 15552000, appsec (14.661 s) : 14661000, 14661000 . : milestone, 14661000, iast (18.497 s) : 18497000, 18497000 . : milestone, 18497000, iast_GLOBAL (17.977 s) : 17977000, 17977000 . : milestone, 17977000, profiling (14.966 s) : 14966000, 14966000 . : milestone, 14966000, tracing (14.958 s) : 14958000, 14958000 . : milestone, 14958000, section candidate no_agent (15.02 s) : 15020000, 15020000 . : milestone, 15020000, appsec (14.724 s) : 14724000, 14724000 . : milestone, 14724000, iast (18.366 s) : 18366000, 18366000 . : milestone, 18366000, iast_GLOBAL (18.136 s) : 18136000, 18136000 . : milestone, 18136000, profiling (14.816 s) : 14816000, 14816000 . : milestone, 14816000, tracing (14.92 s) : 14920000, 14920000 . : milestone, 14920000,
|
97623bb
to b8f796a
Compare Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment about how to deal with EA build in the long term.
We can revisit it later 😉
* Update builder image prefix for JDK 25 EA * Exclude 25 from stable jvm calculation
What Does This Do
Update builder image prefix to
v25.07
to include the JDK 25 EA imageMotivation
Additional Notes
dd-trace-java-docker-build image tags here
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: https://datadoghq.atlassian.net/browse/LANGPLAT-83