Migrate internal-api to environment component #9091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
PerfectSlayer added comp: core 
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 8 unstable metrics. Startup time reports for petclinicgantt title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~25a7cc11ac, baseline=1.51.0-SNAPSHOT~6aa285fb9c dateFormat X axisFormat %s section tracing Agent [baseline] (1.003 s) : 0, 1003070 Total [baseline] (10.648 s) : 0, 10647882 Agent [candidate] (1.011 s) : 0, 1010925 Total [candidate] (10.687 s) : 0, 10686599 section appsec Agent [baseline] (1.176 s) : 0, 1175932 Total [baseline] (10.763 s) : 0, 10762642 Agent [candidate] (1.185 s) : 0, 1184681 Total [candidate] (10.866 s) : 0, 10865871 section iast Agent [baseline] (1.133 s) : 0, 1132537 Total [baseline] (10.845 s) : 0, 10844524 Agent [candidate] (1.135 s) : 0, 1135181 Total [candidate] (10.907 s) : 0, 10906572 section profiling Agent [baseline] (1.245 s) : 0, 1245442 Total [baseline] (10.914 s) : 0, 10914404 Agent [candidate] (1.243 s) : 0, 1243212 Total [candidate] (10.962 s) : 0, 10962197
gantt title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~25a7cc11ac, baseline=1.51.0-SNAPSHOT~6aa285fb9c dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (692.751 ms) : 0, 692751 BytebuddyAgent [candidate] (698.795 ms) : 0, 698795 GlobalTracer [baseline] (243.797 ms) : 0, 243797 GlobalTracer [candidate] (245.166 ms) : 0, 245166 AppSec [baseline] (30.556 ms) : 0, 30556 AppSec [candidate] (30.816 ms) : 0, 30816 Debugger [baseline] (6.072 ms) : 0, 6072 Debugger [candidate] (6.132 ms) : 0, 6132 Remote Config [baseline] (686.537 µs) : 0, 687 Remote Config [candidate] (699.926 µs) : 0, 700 Telemetry [baseline] (8.269 ms) : 0, 8269 Telemetry [candidate] (8.387 ms) : 0, 8387 section appsec BytebuddyAgent [baseline] (710.751 ms) : 0, 710751 BytebuddyAgent [candidate] (717.503 ms) : 0, 717503 GlobalTracer [baseline] (234.995 ms) : 0, 234995 GlobalTracer [candidate] (237.001 ms) : 0, 237001 IAST [baseline] (23.126 ms) : 0, 23126 IAST [candidate] (23.451 ms) : 0, 23451 AppSec [baseline] (171.805 ms) : 0, 171805 AppSec [candidate] (171.383 ms) : 0, 171383 Debugger [baseline] (5.776 ms) : 0, 5776 Debugger [candidate] (5.747 ms) : 0, 5747 Remote Config [baseline] (616.547 µs) : 0, 617 Remote Config [candidate] (599.491 µs) : 0, 599 Telemetry [baseline] (8.093 ms) : 0, 8093 Telemetry [candidate] (8.028 ms) : 0, 8028 section iast BytebuddyAgent [baseline] (806.963 ms) : 0, 806963 BytebuddyAgent [candidate] (809.158 ms) : 0, 809158 GlobalTracer [baseline] (232.746 ms) : 0, 232746 GlobalTracer [candidate] (233.321 ms) : 0, 233321 IAST [baseline] (27.897 ms) : 0, 27897 IAST [candidate] (27.835 ms) : 0, 27835 AppSec [baseline] (28.935 ms) : 0, 28935 AppSec [candidate] (28.804 ms) : 0, 28804 Debugger [baseline] (6.653 ms) : 0, 6653 Debugger [candidate] (6.672 ms) : 0, 6672 Remote Config [baseline] (586.302 µs) : 0, 586 Remote Config [candidate] (581.324 µs) : 0, 581 Telemetry [baseline] (7.994 ms) : 0, 7994 Telemetry [candidate] (8.001 ms) : 0, 8001 section profiling BytebuddyAgent [baseline] (677.384 ms) : 0, 677384 BytebuddyAgent [candidate] (676.872 ms) : 0, 676872 GlobalTracer [baseline] (363.142 ms) : 0, 363142 GlobalTracer [candidate] (361.381 ms) : 0, 361381 AppSec [baseline] (31.782 ms) : 0, 31782 AppSec [candidate] (30.857 ms) : 0, 30857 Debugger [baseline] (12.025 ms) : 0, 12025 Debugger [candidate] (12.721 ms) : 0, 12721 Remote Config [baseline] (663.127 µs) : 0, 663 Remote Config [candidate] (663.962 µs) : 0, 664 Telemetry [baseline] (8.67 ms) : 0, 8670 Telemetry [candidate] (8.771 ms) : 0, 8771 ProfilingAgent [baseline] (103.193 ms) : 0, 103193 ProfilingAgent [candidate] (102.71 ms) : 0, 102710 Profiling [baseline] (103.217 ms) : 0, 103217 Profiling [candidate] (102.735 ms) : 0, 102735 Startup time reports for insecure-bankgantt title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~25a7cc11ac, baseline=1.51.0-SNAPSHOT~6aa285fb9c dateFormat X axisFormat %s section tracing Agent [baseline] (995.792 ms) : 0, 995792 Total [baseline] (8.547 s) : 0, 8547307 Agent [candidate] (994.774 ms) : 0, 994774 Total [candidate] (8.544 s) : 0, 8543878 section iast Agent [baseline] (1.148 s) : 0, 1148217 Total [baseline] (9.271 s) : 0, 9271379 Agent [candidate] (1.135 s) : 0, 1134944 Total [candidate] (9.277 s) : 0, 9276760
gantt title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~25a7cc11ac, baseline=1.51.0-SNAPSHOT~6aa285fb9c dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (686.378 ms) : 0, 686378 BytebuddyAgent [candidate] (687.313 ms) : 0, 687313 GlobalTracer [baseline] (243.16 ms) : 0, 243160 GlobalTracer [candidate] (241.505 ms) : 0, 241505 AppSec [baseline] (30.391 ms) : 0, 30391 AppSec [candidate] (30.256 ms) : 0, 30256 Debugger [baseline] (6.065 ms) : 0, 6065 Debugger [candidate] (6.052 ms) : 0, 6052 Remote Config [baseline] (687.749 µs) : 0, 688 Remote Config [candidate] (678.679 µs) : 0, 679 Telemetry [baseline] (8.313 ms) : 0, 8313 Telemetry [candidate] (8.181 ms) : 0, 8181 section iast BytebuddyAgent [baseline] (818.896 ms) : 0, 818896 BytebuddyAgent [candidate] (809.152 ms) : 0, 809152 GlobalTracer [baseline] (235.484 ms) : 0, 235484 GlobalTracer [candidate] (232.714 ms) : 0, 232714 IAST [baseline] (27.436 ms) : 0, 27436 IAST [candidate] (27.95 ms) : 0, 27950 AppSec [baseline] (30.911 ms) : 0, 30911 AppSec [candidate] (28.886 ms) : 0, 28886 Debugger [baseline] (5.874 ms) : 0, 5874 Debugger [candidate] (6.729 ms) : 0, 6729 Remote Config [baseline] (595.142 µs) : 0, 595 Remote Config [candidate] (585.75 µs) : 0, 586 Telemetry [baseline] (8.093 ms) : 0, 8093 Telemetry [candidate] (8.084 ms) : 0, 8084 LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~25a7cc11ac, baseline=1.51.0-SNAPSHOT~6aa285fb9c dateFormat X axisFormat %s section baseline no_agent (37.384 ms) : 37079, 37689 . : milestone, 37384, appsec (46.04 ms) : 45626, 46453 . : milestone, 46040, code_origins (44.798 ms) : 44412, 45184 . : milestone, 44798, iast (46.534 ms) : 46123, 46945 . : milestone, 46534, profiling (47.332 ms) : 46875, 47789 . : milestone, 47332, tracing (44.56 ms) : 44186, 44934 . : milestone, 44560, section candidate no_agent (36.762 ms) : 36461, 37062 . : milestone, 36762, appsec (46.66 ms) : 46242, 47079 . : milestone, 46660, code_origins (45.941 ms) : 45547, 46335 . : milestone, 45941, iast (44.424 ms) : 44038, 44810 . : milestone, 44424, profiling (47.231 ms) : 46778, 47684 . : milestone, 47231, tracing (44.124 ms) : 43747, 44502 . : milestone, 44124,
Request duration reports for insecure-bankgantt title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~25a7cc11ac, baseline=1.51.0-SNAPSHOT~6aa285fb9c dateFormat X axisFormat %s section baseline no_agent (4.388 ms) : 4338, 4437 . : milestone, 4388, iast (9.683 ms) : 9524, 9842 . : milestone, 9683, iast_FULL (14.06 ms) : 13777, 14343 . : milestone, 14060, iast_GLOBAL (9.909 ms) : 9737, 10080 . : milestone, 9909, profiling (8.519 ms) : 8391, 8648 . : milestone, 8519, tracing (7.947 ms) : 7829, 8066 . : milestone, 7947, section candidate no_agent (4.373 ms) : 4323, 4422 . : milestone, 4373, iast (9.742 ms) : 9568, 9915 . : milestone, 9742, iast_FULL (14.388 ms) : 14103, 14672 . : milestone, 14388, iast_GLOBAL (10.431 ms) : 10240, 10622 . : milestone, 10431, profiling (8.707 ms) : 8568, 8846 . : milestone, 8707, tracing (7.768 ms) : 7653, 7884 . : milestone, 7768,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~25a7cc11ac, baseline=1.51.0-SNAPSHOT~6aa285fb9c dateFormat X axisFormat %s section baseline no_agent (15.629 s) : 15629000, 15629000 . : milestone, 15629000, appsec (14.877 s) : 14877000, 14877000 . : milestone, 14877000, iast (18.231 s) : 18231000, 18231000 . : milestone, 18231000, iast_GLOBAL (18.012 s) : 18012000, 18012000 . : milestone, 18012000, profiling (15.142 s) : 15142000, 15142000 . : milestone, 15142000, tracing (14.644 s) : 14644000, 14644000 . : milestone, 14644000, section candidate no_agent (14.992 s) : 14992000, 14992000 . : milestone, 14992000, appsec (14.923 s) : 14923000, 14923000 . : milestone, 14923000, iast (18.921 s) : 18921000, 18921000 . : milestone, 18921000, iast_GLOBAL (18.196 s) : 18196000, 18196000 . : milestone, 18196000, profiling (15.294 s) : 15294000, 15294000 . : milestone, 15294000, tracing (15.004 s) : 15004000, 15004000 . : milestone, 15004000,
Execution time for tomcatgantt title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~25a7cc11ac, baseline=1.51.0-SNAPSHOT~6aa285fb9c dateFormat X axisFormat %s section baseline no_agent (1.478 ms) : 1467, 1490 . : milestone, 1478, appsec (2.409 ms) : 2360, 2458 . : milestone, 2409, iast (2.198 ms) : 2137, 2260 . : milestone, 2198, iast_GLOBAL (2.243 ms) : 2181, 2306 . : milestone, 2243, profiling (2.045 ms) : 1995, 2095 . : milestone, 2045, tracing (2.016 ms) : 1968, 2064 . : milestone, 2016, section candidate no_agent (1.476 ms) : 1465, 1488 . : milestone, 1476, appsec (2.409 ms) : 2360, 2458 . : milestone, 2409, iast (2.207 ms) : 2145, 2269 . : milestone, 2207, iast_GLOBAL (2.242 ms) : 2180, 2305 . : milestone, 2242, profiling (2.054 ms) : 2004, 2104 . : milestone, 2054, tracing (2.001 ms) : 1953, 2049 . : milestone, 2001,
|
PerfectSlayer force-pushed the bbujon/environment-step3 branch from 74661c9 to f077e1b Compare 
PerfectSlayer force-pushed the bbujon/environment-step3 branch from f077e1b to 25a7cc1 Compare PerfectSlayer requested review from dougqh, manuel-alvarez-alvarez and smola and removed request for a team 
bric3 approved these changes Jul 3, 2025
This was referenced Jul 4, 2025
This was referenced Jul 17, 2025
This was referenced Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR migrates the internal API to the environment components.
Follow-up to:
Motivation
Additional Notes
More part from the internal API are intended to move to the environment component but I would rather focus on deploying / adopting it right now, and make it grew later once I'm sure I will have to time to properly integrate them and add dedicated tests - hopefully next R&D week.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: LANGPLAT-458