Graceful error handling in .gitlab/find-gh-base-ref.sh #9074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
smola added tag: no release notes smola changed the title 
PerfectSlayer approved these changes Jul 1, 2025
| @PerfectSlayer That's to get a chance to log some error message before exiting. |
PerfectSlayer approved these changes Jul 1, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 7 unstable metrics. Startup time reports for petclinicgantt title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~9e1a9a1fd9, baseline=1.51.0-SNAPSHOT~848b0754aa dateFormat X axisFormat %s section tracing Agent [baseline] (997.474 ms) : 0, 997474 Total [baseline] (10.692 s) : 0, 10691730 Agent [candidate] (998.377 ms) : 0, 998377 Total [candidate] (10.582 s) : 0, 10581558 section appsec Agent [baseline] (1.176 s) : 0, 1176156 Total [baseline] (10.741 s) : 0, 10741122 Agent [candidate] (1.178 s) : 0, 1177952 Total [candidate] (10.811 s) : 0, 10811442 section iast Agent [baseline] (1.133 s) : 0, 1133407 Total [baseline] (10.824 s) : 0, 10824438 Agent [candidate] (1.135 s) : 0, 1135120 Total [candidate] (10.845 s) : 0, 10844630 section profiling Agent [baseline] (1.256 s) : 0, 1256404 Total [baseline] (11.073 s) : 0, 11073398 Agent [candidate] (1.248 s) : 0, 1247647 Total [candidate] (10.942 s) : 0, 10941723
gantt title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~9e1a9a1fd9, baseline=1.51.0-SNAPSHOT~848b0754aa dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (688.784 ms) : 0, 688784 BytebuddyAgent [candidate] (689.199 ms) : 0, 689199 GlobalTracer [baseline] (242.703 ms) : 0, 242703 GlobalTracer [candidate] (242.977 ms) : 0, 242977 AppSec [baseline] (30.279 ms) : 0, 30279 AppSec [candidate] (30.423 ms) : 0, 30423 Debugger [baseline] (6.082 ms) : 0, 6082 Debugger [candidate] (6.038 ms) : 0, 6038 Remote Config [baseline] (678.429 µs) : 0, 678 Remote Config [candidate] (680.884 µs) : 0, 681 Telemetry [baseline] (8.182 ms) : 0, 8182 Telemetry [candidate] (8.185 ms) : 0, 8185 section appsec BytebuddyAgent [baseline] (711.856 ms) : 0, 711856 BytebuddyAgent [candidate] (712.599 ms) : 0, 712599 GlobalTracer [baseline] (236.034 ms) : 0, 236034 GlobalTracer [candidate] (236.312 ms) : 0, 236312 AppSec [baseline] (171.012 ms) : 0, 171012 AppSec [candidate] (171.542 ms) : 0, 171542 Debugger [baseline] (5.811 ms) : 0, 5811 Debugger [candidate] (5.815 ms) : 0, 5815 Remote Config [baseline] (608.126 µs) : 0, 608 Remote Config [candidate] (606.419 µs) : 0, 606 Telemetry [baseline] (8.124 ms) : 0, 8124 Telemetry [candidate] (8.128 ms) : 0, 8128 IAST [baseline] (21.905 ms) : 0, 21905 IAST [candidate] (22.104 ms) : 0, 22104 section iast BytebuddyAgent [baseline] (809.277 ms) : 0, 809277 BytebuddyAgent [candidate] (810.581 ms) : 0, 810581 GlobalTracer [baseline] (233.674 ms) : 0, 233674 GlobalTracer [candidate] (233.675 ms) : 0, 233675 AppSec [baseline] (26.789 ms) : 0, 26789 AppSec [candidate] (26.022 ms) : 0, 26022 Debugger [baseline] (5.791 ms) : 0, 5791 Debugger [candidate] (5.836 ms) : 0, 5836 Remote Config [baseline] (568.706 µs) : 0, 569 Remote Config [candidate] (725.541 µs) : 0, 726 Telemetry [baseline] (7.88 ms) : 0, 7880 Telemetry [candidate] (7.987 ms) : 0, 7987 IAST [baseline] (28.625 ms) : 0, 28625 IAST [candidate] (29.467 ms) : 0, 29467 section profiling ProfilingAgent [baseline] (104.976 ms) : 0, 104976 ProfilingAgent [candidate] (103.395 ms) : 0, 103395 BytebuddyAgent [baseline] (684.881 ms) : 0, 684881 BytebuddyAgent [candidate] (680.681 ms) : 0, 680681 GlobalTracer [baseline] (364.277 ms) : 0, 364277 GlobalTracer [candidate] (361.826 ms) : 0, 361826 AppSec [baseline] (31.797 ms) : 0, 31797 AppSec [candidate] (30.908 ms) : 0, 30908 Debugger [baseline] (12.867 ms) : 0, 12867 Debugger [candidate] (13.453 ms) : 0, 13453 Remote Config [baseline] (664.687 µs) : 0, 665 Remote Config [candidate] (659.187 µs) : 0, 659 Telemetry [baseline] (8.063 ms) : 0, 8063 Telemetry [candidate] (8.018 ms) : 0, 8018 Profiling [baseline] (105.0 ms) : 0, 105000 Profiling [candidate] (103.421 ms) : 0, 103421 Startup time reports for insecure-bankgantt title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~9e1a9a1fd9, baseline=1.51.0-SNAPSHOT~848b0754aa dateFormat X axisFormat %s section tracing Agent [baseline] (997.339 ms) : 0, 997339 Total [baseline] (8.617 s) : 0, 8616557 Agent [candidate] (999.422 ms) : 0, 999422 Total [candidate] (8.612 s) : 0, 8611566 section iast Agent [baseline] (1.137 s) : 0, 1137144 Total [baseline] (9.352 s) : 0, 9351734 Agent [candidate] (1.139 s) : 0, 1139357 Total [candidate] (9.328 s) : 0, 9327988
gantt title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~9e1a9a1fd9, baseline=1.51.0-SNAPSHOT~848b0754aa dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (688.983 ms) : 0, 688983 BytebuddyAgent [candidate] (690.126 ms) : 0, 690126 GlobalTracer [baseline] (242.387 ms) : 0, 242387 GlobalTracer [candidate] (243.029 ms) : 0, 243029 AppSec [baseline] (30.269 ms) : 0, 30269 AppSec [candidate] (30.397 ms) : 0, 30397 Debugger [baseline] (6.031 ms) : 0, 6031 Debugger [candidate] (6.071 ms) : 0, 6071 Remote Config [baseline] (675.79 µs) : 0, 676 Remote Config [candidate] (683.561 µs) : 0, 684 Telemetry [baseline] (8.184 ms) : 0, 8184 Telemetry [candidate] (8.22 ms) : 0, 8220 section iast BytebuddyAgent [baseline] (811.228 ms) : 0, 811228 BytebuddyAgent [candidate] (814.951 ms) : 0, 814951 GlobalTracer [baseline] (234.63 ms) : 0, 234630 GlobalTracer [candidate] (233.519 ms) : 0, 233519 AppSec [baseline] (28.019 ms) : 0, 28019 AppSec [candidate] (26.823 ms) : 0, 26823 Debugger [baseline] (5.886 ms) : 0, 5886 Debugger [candidate] (5.787 ms) : 0, 5787 Remote Config [baseline] (591.43 µs) : 0, 591 Remote Config [candidate] (575.961 µs) : 0, 576 Telemetry [baseline] (8.03 ms) : 0, 8030 Telemetry [candidate] (7.927 ms) : 0, 7927 IAST [baseline] (27.949 ms) : 0, 27949 IAST [candidate] (28.857 ms) : 0, 28857 LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~9e1a9a1fd9, baseline=1.51.0-SNAPSHOT~848b0754aa dateFormat X axisFormat %s section baseline no_agent (4.44 ms) : 4390, 4490 . : milestone, 4440, iast (9.028 ms) : 8882, 9175 . : milestone, 9028, iast_FULL (14.385 ms) : 14100, 14671 . : milestone, 14385, iast_GLOBAL (10.416 ms) : 10232, 10600 . : milestone, 10416, profiling (8.424 ms) : 8296, 8552 . : milestone, 8424, tracing (7.845 ms) : 7726, 7963 . : milestone, 7845, section candidate no_agent (4.319 ms) : 4270, 4369 . : milestone, 4319, iast (9.203 ms) : 9055, 9351 . : milestone, 9203, iast_FULL (14.376 ms) : 14096, 14655 . : milestone, 14376, iast_GLOBAL (10.177 ms) : 9999, 10356 . : milestone, 10177, profiling (8.848 ms) : 8713, 8983 . : milestone, 8848, tracing (8.269 ms) : 8149, 8388 . : milestone, 8269,
Request duration reports for petclinicgantt title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~9e1a9a1fd9, baseline=1.51.0-SNAPSHOT~848b0754aa dateFormat X axisFormat %s section baseline no_agent (36.686 ms) : 36380, 36991 . : milestone, 36686, appsec (46.586 ms) : 46165, 47007 . : milestone, 46586, code_origins (44.053 ms) : 43664, 44443 . : milestone, 44053, iast (43.592 ms) : 43205, 43980 . : milestone, 43592, profiling (47.668 ms) : 47236, 48099 . : milestone, 47668, tracing (43.363 ms) : 42981, 43746 . : milestone, 43363, section candidate no_agent (36.786 ms) : 36487, 37084 . : milestone, 36786, appsec (47.621 ms) : 47207, 48034 . : milestone, 47621, code_origins (44.719 ms) : 44335, 45103 . : milestone, 44719, iast (44.652 ms) : 44263, 45041 . : milestone, 44652, profiling (48.629 ms) : 48143, 49115 . : milestone, 48629, tracing (43.813 ms) : 43456, 44171 . : milestone, 43813,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~9e1a9a1fd9, baseline=1.51.0-SNAPSHOT~848b0754aa dateFormat X axisFormat %s section baseline no_agent (1.473 ms) : 1462, 1485 . : milestone, 1473, appsec (2.408 ms) : 2358, 2457 . : milestone, 2408, iast (2.193 ms) : 2130, 2255 . : milestone, 2193, iast_GLOBAL (2.237 ms) : 2174, 2299 . : milestone, 2237, profiling (2.049 ms) : 1998, 2100 . : milestone, 2049, tracing (2.007 ms) : 1959, 2055 . : milestone, 2007, section candidate no_agent (1.473 ms) : 1461, 1484 . : milestone, 1473, appsec (2.405 ms) : 2355, 2454 . : milestone, 2405, iast (2.193 ms) : 2132, 2255 . : milestone, 2193, iast_GLOBAL (2.238 ms) : 2175, 2300 . : milestone, 2238, profiling (2.02 ms) : 1971, 2069 . : milestone, 2020, tracing (2.017 ms) : 1969, 2065 . : milestone, 2017,
Execution time for biojavagantt title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~9e1a9a1fd9, baseline=1.51.0-SNAPSHOT~848b0754aa dateFormat X axisFormat %s section baseline no_agent (15.372 s) : 15372000, 15372000 . : milestone, 15372000, appsec (14.824 s) : 14824000, 14824000 . : milestone, 14824000, iast (18.478 s) : 18478000, 18478000 . : milestone, 18478000, iast_GLOBAL (18.213 s) : 18213000, 18213000 . : milestone, 18213000, profiling (15.212 s) : 15212000, 15212000 . : milestone, 15212000, tracing (14.934 s) : 14934000, 14934000 . : milestone, 14934000, section candidate no_agent (15.498 s) : 15498000, 15498000 . : milestone, 15498000, appsec (14.943 s) : 14943000, 14943000 . : milestone, 14943000, iast (18.545 s) : 18545000, 18545000 . : milestone, 18545000, iast_GLOBAL (18.173 s) : 18173000, 18173000 . : milestone, 18173000, profiling (15.863 s) : 15863000, 15863000 . : milestone, 15863000, tracing (14.833 s) : 14833000, 14833000 . : milestone, 14833000,
|
Co-authored-by: Brice Dutheil <brice.dutheil@gmail.com>
Co-authored-by: Brice Dutheil <brice.dutheil@gmail.com>
smola added a commit that referenced this pull request Jul 2, 2025
Co-authored-by: Brice Dutheil <brice.dutheil@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What Does This Do
aws ssmfails, print an error..gitlab/find-gh-base-ref.shdoes not determine any base branch, do not set-PgitBaseRef=at all.Motivation
Additional Notes
Doing this for quick CI recovery, but ideally:
ghCLI withgh pr view -R DataDog/dd-trace-java $CI_COMMIT_REF_NAME --json baseRefName --jq .baseRefNameas suggested by @PerfectSlayer.Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]