Refactor wildcard imports in config #9063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
PerfectSlayer added comp: core 
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~292304336b, baseline=1.51.0-SNAPSHOT~46d09492c9 dateFormat X axisFormat %s section tracing Agent [baseline] (998.658 ms) : 0, 998658 Total [baseline] (8.546 s) : 0, 8545782 Agent [candidate] (996.931 ms) : 0, 996931 Total [candidate] (8.545 s) : 0, 8544841 section iast Agent [baseline] (1.143 s) : 0, 1142520 Total [baseline] (9.366 s) : 0, 9366107 Agent [candidate] (1.139 s) : 0, 1138961 Total [candidate] (9.277 s) : 0, 9276610
gantt title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~292304336b, baseline=1.51.0-SNAPSHOT~46d09492c9 dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (689.811 ms) : 0, 689811 BytebuddyAgent [candidate] (688.149 ms) : 0, 688149 GlobalTracer [baseline] (242.754 ms) : 0, 242754 GlobalTracer [candidate] (242.572 ms) : 0, 242572 AppSec [baseline] (30.369 ms) : 0, 30369 AppSec [candidate] (30.515 ms) : 0, 30515 Debugger [baseline] (6.041 ms) : 0, 6041 Debugger [candidate] (6.043 ms) : 0, 6043 Remote Config [baseline] (689.823 µs) : 0, 690 Remote Config [candidate] (678.226 µs) : 0, 678 Telemetry [baseline] (8.26 ms) : 0, 8260 Telemetry [candidate] (8.233 ms) : 0, 8233 section iast BytebuddyAgent [baseline] (814.901 ms) : 0, 814901 BytebuddyAgent [candidate] (814.04 ms) : 0, 814040 GlobalTracer [baseline] (235.61 ms) : 0, 235610 GlobalTracer [candidate] (234.355 ms) : 0, 234355 IAST [baseline] (25.867 ms) : 0, 25867 IAST [candidate] (27.866 ms) : 0, 27866 AppSec [baseline] (30.78 ms) : 0, 30780 AppSec [candidate] (27.483 ms) : 0, 27483 Debugger [baseline] (5.861 ms) : 0, 5861 Debugger [candidate] (5.8 ms) : 0, 5800 Remote Config [baseline] (587.558 µs) : 0, 588 Remote Config [candidate] (577.254 µs) : 0, 577 Telemetry [baseline] (8.097 ms) : 0, 8097 Telemetry [candidate] (7.956 ms) : 0, 7956 Startup time reports for petclinicgantt title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~292304336b, baseline=1.51.0-SNAPSHOT~46d09492c9 dateFormat X axisFormat %s section tracing Agent [baseline] (995.786 ms) : 0, 995786 Total [baseline] (10.691 s) : 0, 10690683 Agent [candidate] (1.003 s) : 0, 1002662 Total [candidate] (10.575 s) : 0, 10574606 section appsec Agent [baseline] (1.172 s) : 0, 1171989 Total [baseline] (10.672 s) : 0, 10671619 Agent [candidate] (1.175 s) : 0, 1174583 Total [candidate] (10.782 s) : 0, 10782241 section iast Agent [baseline] (1.132 s) : 0, 1132265 Total [baseline] (10.825 s) : 0, 10825060 Agent [candidate] (1.134 s) : 0, 1134184 Total [candidate] (10.788 s) : 0, 10787501 section profiling Agent [baseline] (1.242 s) : 0, 1242346 Total [baseline] (10.944 s) : 0, 10943922 Agent [candidate] (1.244 s) : 0, 1244092 Total [candidate] (10.959 s) : 0, 10958682
gantt title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~292304336b, baseline=1.51.0-SNAPSHOT~46d09492c9 dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (687.735 ms) : 0, 687735 BytebuddyAgent [candidate] (692.78 ms) : 0, 692780 GlobalTracer [baseline] (241.924 ms) : 0, 241924 GlobalTracer [candidate] (243.451 ms) : 0, 243451 AppSec [baseline] (30.374 ms) : 0, 30374 AppSec [candidate] (30.552 ms) : 0, 30552 Debugger [baseline] (6.094 ms) : 0, 6094 Debugger [candidate] (6.093 ms) : 0, 6093 Remote Config [baseline] (691.302 µs) : 0, 691 Remote Config [candidate] (676.276 µs) : 0, 676 Telemetry [baseline] (8.217 ms) : 0, 8217 Telemetry [candidate] (8.229 ms) : 0, 8229 section appsec BytebuddyAgent [baseline] (709.487 ms) : 0, 709487 BytebuddyAgent [candidate] (711.41 ms) : 0, 711410 GlobalTracer [baseline] (235.085 ms) : 0, 235085 GlobalTracer [candidate] (235.505 ms) : 0, 235505 IAST [baseline] (21.861 ms) : 0, 21861 IAST [candidate] (21.896 ms) : 0, 21896 AppSec [baseline] (170.42 ms) : 0, 170420 AppSec [candidate] (170.55 ms) : 0, 170550 Debugger [baseline] (5.767 ms) : 0, 5767 Debugger [candidate] (5.793 ms) : 0, 5793 Remote Config [baseline] (595.134 µs) : 0, 595 Remote Config [candidate] (605.007 µs) : 0, 605 Telemetry [baseline] (8.022 ms) : 0, 8022 Telemetry [candidate] (8.111 ms) : 0, 8111 section iast BytebuddyAgent [baseline] (808.366 ms) : 0, 808366 BytebuddyAgent [candidate] (809.596 ms) : 0, 809596 GlobalTracer [baseline] (233.182 ms) : 0, 233182 GlobalTracer [candidate] (233.535 ms) : 0, 233535 IAST [baseline] (27.951 ms) : 0, 27951 IAST [candidate] (26.397 ms) : 0, 26397 AppSec [baseline] (27.613 ms) : 0, 27613 AppSec [candidate] (29.481 ms) : 0, 29481 Debugger [baseline] (5.808 ms) : 0, 5808 Debugger [candidate] (5.814 ms) : 0, 5814 Remote Config [baseline] (585.935 µs) : 0, 586 Remote Config [candidate] (576.581 µs) : 0, 577 Telemetry [baseline] (7.945 ms) : 0, 7945 Telemetry [candidate] (7.928 ms) : 0, 7928 section profiling BytebuddyAgent [baseline] (678.154 ms) : 0, 678154 BytebuddyAgent [candidate] (679.135 ms) : 0, 679135 GlobalTracer [baseline] (360.521 ms) : 0, 360521 GlobalTracer [candidate] (361.004 ms) : 0, 361004 AppSec [baseline] (31.585 ms) : 0, 31585 AppSec [candidate] (31.488 ms) : 0, 31488 Debugger [baseline] (12.777 ms) : 0, 12777 Debugger [candidate] (11.881 ms) : 0, 11881 Remote Config [baseline] (649.309 µs) : 0, 649 Remote Config [candidate] (659.507 µs) : 0, 660 Telemetry [baseline] (7.9 ms) : 0, 7900 Telemetry [candidate] (8.729 ms) : 0, 8729 ProfilingAgent [baseline] (102.177 ms) : 0, 102177 ProfilingAgent [candidate] (102.692 ms) : 0, 102692 Profiling [baseline] (102.203 ms) : 0, 102203 Profiling [candidate] (102.718 ms) : 0, 102718 LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~292304336b, baseline=1.51.0-SNAPSHOT~46d09492c9 dateFormat X axisFormat %s section baseline no_agent (37.27 ms) : 36968, 37571 . : milestone, 37270, appsec (47.508 ms) : 47101, 47916 . : milestone, 47508, code_origins (44.068 ms) : 43698, 44438 . : milestone, 44068, iast (44.944 ms) : 44546, 45342 . : milestone, 44944, profiling (47.833 ms) : 47420, 48246 . : milestone, 47833, tracing (45.879 ms) : 45489, 46270 . : milestone, 45879, section candidate no_agent (37.287 ms) : 36982, 37592 . : milestone, 37287, appsec (48.709 ms) : 48266, 49152 . : milestone, 48709, code_origins (45.258 ms) : 44863, 45652 . : milestone, 45258, iast (45.09 ms) : 44704, 45476 . : milestone, 45090, profiling (48.404 ms) : 47945, 48864 . : milestone, 48404, tracing (43.544 ms) : 43167, 43920 . : milestone, 43544,
Request duration reports for insecure-bankgantt title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~292304336b, baseline=1.51.0-SNAPSHOT~46d09492c9 dateFormat X axisFormat %s section baseline no_agent (4.352 ms) : 4302, 4401 . : milestone, 4352, iast (9.335 ms) : 9176, 9494 . : milestone, 9335, iast_FULL (14.131 ms) : 13851, 14411 . : milestone, 14131, iast_GLOBAL (9.69 ms) : 9524, 9856 . : milestone, 9690, profiling (8.839 ms) : 8684, 8993 . : milestone, 8839, tracing (7.624 ms) : 7514, 7734 . : milestone, 7624, section candidate no_agent (4.503 ms) : 4450, 4555 . : milestone, 4503, iast (9.248 ms) : 9091, 9404 . : milestone, 9248, iast_FULL (13.945 ms) : 13667, 14223 . : milestone, 13945, iast_GLOBAL (10.302 ms) : 10095, 10509 . : milestone, 10302, profiling (8.763 ms) : 8627, 8899 . : milestone, 8763, tracing (7.651 ms) : 7528, 7774 . : milestone, 7651,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~292304336b, baseline=1.51.0-SNAPSHOT~46d09492c9 dateFormat X axisFormat %s section baseline no_agent (1.476 ms) : 1464, 1487 . : milestone, 1476, appsec (2.4 ms) : 2351, 2449 . : milestone, 2400, iast (2.184 ms) : 2122, 2246 . : milestone, 2184, iast_GLOBAL (2.229 ms) : 2167, 2292 . : milestone, 2229, profiling (2.035 ms) : 1986, 2085 . : milestone, 2035, tracing (1.999 ms) : 1951, 2046 . : milestone, 1999, section candidate no_agent (1.48 ms) : 1469, 1492 . : milestone, 1480, appsec (2.4 ms) : 2351, 2450 . : milestone, 2400, iast (2.186 ms) : 2124, 2247 . : milestone, 2186, iast_GLOBAL (2.239 ms) : 2176, 2301 . : milestone, 2239, profiling (2.054 ms) : 2003, 2105 . : milestone, 2054, tracing (2.006 ms) : 1958, 2054 . : milestone, 2006,
Execution time for biojavagantt title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~292304336b, baseline=1.51.0-SNAPSHOT~46d09492c9 dateFormat X axisFormat %s section baseline no_agent (15.77 s) : 15770000, 15770000 . : milestone, 15770000, appsec (14.705 s) : 14705000, 14705000 . : milestone, 14705000, iast (18.232 s) : 18232000, 18232000 . : milestone, 18232000, iast_GLOBAL (18.104 s) : 18104000, 18104000 . : milestone, 18104000, profiling (15.252 s) : 15252000, 15252000 . : milestone, 15252000, tracing (14.895 s) : 14895000, 14895000 . : milestone, 14895000, section candidate no_agent (15.278 s) : 15278000, 15278000 . : milestone, 15278000, appsec (14.691 s) : 14691000, 14691000 . : milestone, 14691000, iast (18.332 s) : 18332000, 18332000 . : milestone, 18332000, iast_GLOBAL (18.071 s) : 18071000, 18071000 . : milestone, 18071000, profiling (15.326 s) : 15326000, 15326000 . : milestone, 15326000, tracing (14.585 s) : 14585000, 14585000 . : milestone, 14585000,
|
mcculls approved these changes Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What Does This Do
Remove usage of wildcard import from
Config.Motivation
Following the work of #9042
This often leads to conflict while working on refactoring.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]