- Notifications
You must be signed in to change notification settings - Fork 313
Increase CiVis smoke tests timeout #9062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase CiVis smoke tests timeout #9062
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 10 unstable metrics. Startup time reports for insecure-bankgantt title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~99a5b11ce8, baseline=1.51.0-SNAPSHOT~53e4f70038 dateFormat X axisFormat %s section tracing Agent [baseline] (999.837 ms) : 0, 999837 Total [baseline] (8.587 s) : 0, 8587211 Agent [candidate] (1.003 s) : 0, 1002690 Total [candidate] (8.578 s) : 0, 8577752 section iast Agent [baseline] (1.142 s) : 0, 1141622 Total [baseline] (9.283 s) : 0, 9282581 Agent [candidate] (1.159 s) : 0, 1159308 Total [candidate] (9.393 s) : 0, 9392591
gantt title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~99a5b11ce8, baseline=1.51.0-SNAPSHOT~53e4f70038 dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (691.87 ms) : 0, 691870 BytebuddyAgent [candidate] (692.35 ms) : 0, 692350 GlobalTracer [baseline] (241.884 ms) : 0, 241884 GlobalTracer [candidate] (243.728 ms) : 0, 243728 AppSec [baseline] (30.2 ms) : 0, 30200 AppSec [candidate] (30.637 ms) : 0, 30637 Debugger [baseline] (6.059 ms) : 0, 6059 Debugger [candidate] (6.105 ms) : 0, 6105 Remote Config [baseline] (681.981 µs) : 0, 682 Remote Config [candidate] (685.716 µs) : 0, 686 Telemetry [baseline] (8.226 ms) : 0, 8226 Telemetry [candidate] (8.268 ms) : 0, 8268 section iast BytebuddyAgent [baseline] (814.399 ms) : 0, 814399 BytebuddyAgent [candidate] (828.266 ms) : 0, 828266 GlobalTracer [baseline] (233.901 ms) : 0, 233901 GlobalTracer [candidate] (238.095 ms) : 0, 238095 IAST [baseline] (28.056 ms) : 0, 28056 IAST [candidate] (27.798 ms) : 0, 27798 AppSec [baseline] (28.966 ms) : 0, 28966 AppSec [candidate] (28.541 ms) : 0, 28541 Debugger [baseline] (6.708 ms) : 0, 6708 Debugger [candidate] (5.972 ms) : 0, 5972 Remote Config [baseline] (592.25 µs) : 0, 592 Remote Config [candidate] (589.08 µs) : 0, 589 Telemetry [baseline] (8.146 ms) : 0, 8146 Telemetry [candidate] (8.118 ms) : 0, 8118 Startup time reports for petclinicgantt title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~99a5b11ce8, baseline=1.51.0-SNAPSHOT~53e4f70038 dateFormat X axisFormat %s section tracing Agent [baseline] (998.571 ms) : 0, 998571 Total [baseline] (10.584 s) : 0, 10584149 Agent [candidate] (1.005 s) : 0, 1005320 Total [candidate] (10.702 s) : 0, 10702208 section appsec Agent [baseline] (1.176 s) : 0, 1176073 Total [baseline] (10.734 s) : 0, 10733872 Agent [candidate] (1.186 s) : 0, 1185820 Total [candidate] (10.765 s) : 0, 10765000 section iast Agent [baseline] (1.135 s) : 0, 1134898 Total [baseline] (10.846 s) : 0, 10845962 Agent [candidate] (1.133 s) : 0, 1132651 Total [candidate] (10.847 s) : 0, 10846717 section profiling Agent [baseline] (1.247 s) : 0, 1246580 Total [baseline] (10.949 s) : 0, 10949141 Agent [candidate] (1.245 s) : 0, 1245384 Total [candidate] (11.024 s) : 0, 11023838
gantt title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~99a5b11ce8, baseline=1.51.0-SNAPSHOT~53e4f70038 dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (689.737 ms) : 0, 689737 BytebuddyAgent [candidate] (694.246 ms) : 0, 694246 GlobalTracer [baseline] (242.835 ms) : 0, 242835 GlobalTracer [candidate] (244.27 ms) : 0, 244270 AppSec [baseline] (30.179 ms) : 0, 30179 AppSec [candidate] (30.76 ms) : 0, 30760 Debugger [baseline] (6.095 ms) : 0, 6095 Debugger [candidate] (6.144 ms) : 0, 6144 Remote Config [baseline] (685.831 µs) : 0, 686 Remote Config [candidate] (697.416 µs) : 0, 697 Telemetry [baseline] (8.235 ms) : 0, 8235 Telemetry [candidate] (8.3 ms) : 0, 8300 section appsec BytebuddyAgent [baseline] (711.053 ms) : 0, 711053 BytebuddyAgent [candidate] (717.758 ms) : 0, 717758 GlobalTracer [baseline] (234.907 ms) : 0, 234907 GlobalTracer [candidate] (237.851 ms) : 0, 237851 IAST [baseline] (23.228 ms) : 0, 23228 IAST [candidate] (22.407 ms) : 0, 22407 AppSec [baseline] (171.531 ms) : 0, 171531 AppSec [candidate] (172.213 ms) : 0, 172213 Debugger [baseline] (5.765 ms) : 0, 5765 Debugger [candidate] (5.852 ms) : 0, 5852 Remote Config [baseline] (601.52 µs) : 0, 602 Remote Config [candidate] (612.811 µs) : 0, 613 Telemetry [baseline] (8.123 ms) : 0, 8123 Telemetry [candidate] (8.211 ms) : 0, 8211 section iast BytebuddyAgent [baseline] (808.611 ms) : 0, 808611 BytebuddyAgent [candidate] (808.864 ms) : 0, 808864 GlobalTracer [baseline] (233.348 ms) : 0, 233348 GlobalTracer [candidate] (232.952 ms) : 0, 232952 IAST [baseline] (26.411 ms) : 0, 26411 IAST [candidate] (28.64 ms) : 0, 28640 AppSec [baseline] (30.271 ms) : 0, 30271 AppSec [candidate] (26.951 ms) : 0, 26951 Debugger [baseline] (6.758 ms) : 0, 6758 Debugger [candidate] (5.856 ms) : 0, 5856 Remote Config [baseline] (591.246 µs) : 0, 591 Remote Config [candidate] (593.399 µs) : 0, 593 Telemetry [baseline] (8.016 ms) : 0, 8016 Telemetry [candidate] (8.029 ms) : 0, 8029 section profiling BytebuddyAgent [baseline] (678.917 ms) : 0, 678917 BytebuddyAgent [candidate] (679.349 ms) : 0, 679349 GlobalTracer [baseline] (362.528 ms) : 0, 362528 GlobalTracer [candidate] (361.787 ms) : 0, 361787 AppSec [baseline] (31.579 ms) : 0, 31579 AppSec [candidate] (30.845 ms) : 0, 30845 Debugger [baseline] (12.176 ms) : 0, 12176 Debugger [candidate] (12.018 ms) : 0, 12018 Remote Config [baseline] (650.511 µs) : 0, 651 Remote Config [candidate] (2.141 ms) : 0, 2141 Telemetry [baseline] (8.796 ms) : 0, 8796 Telemetry [candidate] (8.057 ms) : 0, 8057 ProfilingAgent [baseline] (103.328 ms) : 0, 103328 ProfilingAgent [candidate] (102.54 ms) : 0, 102540 Profiling [baseline] (103.353 ms) : 0, 103353 Profiling [candidate] (102.565 ms) : 0, 102565 LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~99a5b11ce8, baseline=1.51.0-SNAPSHOT~53e4f70038 dateFormat X axisFormat %s section baseline no_agent (4.472 ms) : 4411, 4534 . : milestone, 4472, iast (8.94 ms) : 8796, 9085 . : milestone, 8940, iast_FULL (14.253 ms) : 13973, 14533 . : milestone, 14253, iast_GLOBAL (10.349 ms) : 10170, 10528 . : milestone, 10349, profiling (9.017 ms) : 8871, 9164 . : milestone, 9017, tracing (7.856 ms) : 7745, 7966 . : milestone, 7856, section candidate no_agent (4.312 ms) : 4263, 4360 . : milestone, 4312, iast (8.967 ms) : 8819, 9116 . : milestone, 8967, iast_FULL (13.784 ms) : 13510, 14058 . : milestone, 13784, iast_GLOBAL (10.018 ms) : 9834, 10202 . : milestone, 10018, profiling (8.774 ms) : 8637, 8910 . : milestone, 8774, tracing (7.698 ms) : 7578, 7817 . : milestone, 7698,
Request duration reports for petclinicgantt title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~99a5b11ce8, baseline=1.51.0-SNAPSHOT~53e4f70038 dateFormat X axisFormat %s section baseline no_agent (37.721 ms) : 37418, 38024 . : milestone, 37721, appsec (47.853 ms) : 47422, 48284 . : milestone, 47853, code_origins (44.205 ms) : 43817, 44594 . : milestone, 44205, iast (44.41 ms) : 44018, 44802 . : milestone, 44410, profiling (45.822 ms) : 45422, 46222 . : milestone, 45822, tracing (43.679 ms) : 43310, 44048 . : milestone, 43679, section candidate no_agent (36.394 ms) : 36099, 36688 . : milestone, 36394, appsec (46.286 ms) : 45884, 46689 . : milestone, 46286, code_origins (44.603 ms) : 44217, 44990 . : milestone, 44603, iast (45.707 ms) : 45311, 46102 . : milestone, 45707, profiling (46.528 ms) : 46120, 46936 . : milestone, 46528, tracing (43.016 ms) : 42662, 43370 . : milestone, 43016,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~99a5b11ce8, baseline=1.51.0-SNAPSHOT~53e4f70038 dateFormat X axisFormat %s section baseline no_agent (14.773 s) : 14773000, 14773000 . : milestone, 14773000, appsec (15.266 s) : 15266000, 15266000 . : milestone, 15266000, iast (18.476 s) : 18476000, 18476000 . : milestone, 18476000, iast_GLOBAL (18.063 s) : 18063000, 18063000 . : milestone, 18063000, profiling (15.133 s) : 15133000, 15133000 . : milestone, 15133000, tracing (14.83 s) : 14830000, 14830000 . : milestone, 14830000, section candidate no_agent (14.982 s) : 14982000, 14982000 . : milestone, 14982000, appsec (14.843 s) : 14843000, 14843000 . : milestone, 14843000, iast (18.275 s) : 18275000, 18275000 . : milestone, 18275000, iast_GLOBAL (17.682 s) : 17682000, 17682000 . : milestone, 17682000, profiling (15.174 s) : 15174000, 15174000 . : milestone, 15174000, tracing (14.78 s) : 14780000, 14780000 . : milestone, 14780000,
Execution time for tomcatgantt title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~99a5b11ce8, baseline=1.51.0-SNAPSHOT~53e4f70038 dateFormat X axisFormat %s section baseline no_agent (1.483 ms) : 1471, 1494 . : milestone, 1483, appsec (2.422 ms) : 2373, 2471 . : milestone, 2422, iast (2.198 ms) : 2136, 2260 . : milestone, 2198, iast_GLOBAL (2.257 ms) : 2195, 2320 . : milestone, 2257, profiling (2.054 ms) : 2003, 2105 . : milestone, 2054, tracing (2.02 ms) : 1972, 2068 . : milestone, 2020, section candidate no_agent (1.479 ms) : 1467, 1490 . : milestone, 1479, appsec (2.423 ms) : 2373, 2473 . : milestone, 2423, iast (2.202 ms) : 2139, 2264 . : milestone, 2202, iast_GLOBAL (2.252 ms) : 2189, 2315 . : milestone, 2252, profiling (2.059 ms) : 2008, 2110 . : milestone, 2059, tracing (2.027 ms) : 1979, 2076 . : milestone, 2027,
|
This reverts commit abb4997.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we bump the gradle task timeout for Maven smoke tests module as well?
Sounds good, let's bump it up to 25min just in case |
FYI there's this PR for possibly improving download latencies #9099 |
@bric3 We'll hold off on merging this PR to see how the download latencies improve and if those changes are enough 👍 |
What Does This Do
Motivation
After fixing the Maven smoke test suite timeout in #9040, test failures are being correctly reported. Although the Maven smoke tests are passing, sometimes the first one or two individual smoke tests need a retry after timing out (usually
test test_successful_maven_run, v3.5.4
, less oftentest test_successful_maven_run, v3.6.3
, which are coincidentally the first two tests in the suite). Currently there are limitations on both the caching of smoke tests dependencies and the caching of maven dependencies, as well as issues related to the Maven smoke tests setup. This changes serve as a patch for now until the implementation can be improved to make use of the dependencies caching capabilities.Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]