🍒 9037 - Drop Baggage when TracePropagationBehaviorExtract=IGNORE #9052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mhlidd added type: bug 
bric3 approved these changes Jun 27, 2025
sarahchen6 approved these changes Jun 27, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 40 metrics, 11 unstable metrics.
Startup time reports for petclinicgantt title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~c08ecaa60c, baseline=1.51.0-SNAPSHOT~640fc88be4 dateFormat X axisFormat %s section tracing Agent [baseline] (1.004 s) : 0, 1004302 Total [baseline] (10.65 s) : 0, 10649657 Agent [candidate] (1.033 s) : 0, 1032537 Total [candidate] (10.594 s) : 0, 10593896 section appsec Agent [baseline] (1.179 s) : 0, 1179242 Total [baseline] (10.751 s) : 0, 10750769 Agent [candidate] (1.18 s) : 0, 1179609 Total [candidate] (10.725 s) : 0, 10724740 section iast Agent [baseline] (1.136 s) : 0, 1136074 Total [baseline] (10.879 s) : 0, 10879110 Agent [candidate] (1.153 s) : 0, 1153165 Total [candidate] (10.878 s) : 0, 10877937 section profiling Agent [baseline] (1.246 s) : 0, 1246342 Total [baseline] (11.048 s) : 0, 11047621 Agent [candidate] (1.271 s) : 0, 1270664 Total [candidate] (11.023 s) : 0, 11022554
gantt title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~c08ecaa60c, baseline=1.51.0-SNAPSHOT~640fc88be4 dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (693.327 ms) : 0, 693327 BytebuddyAgent [candidate] (692.013 ms) : 0, 692013 GlobalTracer [baseline] (244.408 ms) : 0, 244408 GlobalTracer [candidate] (244.069 ms) : 0, 244069 AppSec [baseline] (30.608 ms) : 0, 30608 AppSec [candidate] (57.908 ms) : 0, 57908 Debugger [baseline] (6.094 ms) : 0, 6094 Debugger [candidate] (7.056 ms) : 0, 7056 Remote Config [baseline] (681.421 µs) : 0, 681 Remote Config [candidate] (667.998 µs) : 0, 668 Telemetry [baseline] (8.284 ms) : 0, 8284 Telemetry [candidate] (9.796 ms) : 0, 9796 section appsec BytebuddyAgent [baseline] (713.308 ms) : 0, 713308 BytebuddyAgent [candidate] (711.13 ms) : 0, 711130 GlobalTracer [baseline] (236.697 ms) : 0, 236697 GlobalTracer [candidate] (235.92 ms) : 0, 235920 IAST [baseline] (22.109 ms) : 0, 22109 IAST [candidate] (21.902 ms) : 0, 21902 AppSec [baseline] (171.739 ms) : 0, 171739 AppSec [candidate] (176.083 ms) : 0, 176083 Debugger [baseline] (5.813 ms) : 0, 5813 Debugger [candidate] (5.922 ms) : 0, 5922 Remote Config [baseline] (611.695 µs) : 0, 612 Remote Config [candidate] (617.439 µs) : 0, 617 Telemetry [baseline] (8.118 ms) : 0, 8118 Telemetry [candidate] (7.242 ms) : 0, 7242 section iast BytebuddyAgent [baseline] (811.146 ms) : 0, 811146 BytebuddyAgent [candidate] (806.68 ms) : 0, 806680 GlobalTracer [baseline] (233.836 ms) : 0, 233836 GlobalTracer [candidate] (232.053 ms) : 0, 232053 IAST [baseline] (28.858 ms) : 0, 28858 IAST [candidate] (25.925 ms) : 0, 25925 AppSec [baseline] (27.021 ms) : 0, 27021 AppSec [candidate] (53.146 ms) : 0, 53146 Debugger [baseline] (5.837 ms) : 0, 5837 Debugger [candidate] (5.957 ms) : 0, 5957 Remote Config [baseline] (588.878 µs) : 0, 589 Remote Config [candidate] (589.375 µs) : 0, 589 Telemetry [baseline] (7.944 ms) : 0, 7944 Telemetry [candidate] (8.014 ms) : 0, 8014 section profiling BytebuddyAgent [baseline] (678.963 ms) : 0, 678963 BytebuddyAgent [candidate] (677.979 ms) : 0, 677979 GlobalTracer [baseline] (361.727 ms) : 0, 361727 GlobalTracer [candidate] (361.406 ms) : 0, 361406 AppSec [baseline] (30.921 ms) : 0, 30921 AppSec [candidate] (61.983 ms) : 0, 61983 Debugger [baseline] (12.853 ms) : 0, 12853 Debugger [candidate] (6.122 ms) : 0, 6122 Remote Config [baseline] (665.202 µs) : 0, 665 Remote Config [candidate] (703.313 µs) : 0, 703 Telemetry [baseline] (8.009 ms) : 0, 8009 Telemetry [candidate] (8.235 ms) : 0, 8235 ProfilingAgent [baseline] (103.85 ms) : 0, 103850 ProfilingAgent [candidate] (105.652 ms) : 0, 105652 Profiling [baseline] (103.876 ms) : 0, 103876 Profiling [candidate] (105.675 ms) : 0, 105675 Startup time reports for insecure-bankgantt title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~c08ecaa60c, baseline=1.51.0-SNAPSHOT~640fc88be4 dateFormat X axisFormat %s section tracing Agent [baseline] (1.006 s) : 0, 1005669 Total [baseline] (8.64 s) : 0, 8639882 Agent [candidate] (1.025 s) : 0, 1025445 Total [candidate] (8.571 s) : 0, 8571353 section iast Agent [baseline] (1.134 s) : 0, 1133955 Total [baseline] (9.315 s) : 0, 9315058 Agent [candidate] (1.153 s) : 0, 1152769 Total [candidate] (9.25 s) : 0, 9250135
gantt title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~c08ecaa60c, baseline=1.51.0-SNAPSHOT~640fc88be4 dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (694.9 ms) : 0, 694900 BytebuddyAgent [candidate] (686.898 ms) : 0, 686898 GlobalTracer [baseline] (244.17 ms) : 0, 244170 GlobalTracer [candidate] (242.342 ms) : 0, 242342 AppSec [baseline] (30.562 ms) : 0, 30562 AppSec [candidate] (56.806 ms) : 0, 56806 Debugger [baseline] (6.085 ms) : 0, 6085 Debugger [candidate] (7.09 ms) : 0, 7090 Remote Config [baseline] (682.708 µs) : 0, 683 Remote Config [candidate] (676.932 µs) : 0, 677 Telemetry [baseline] (8.332 ms) : 0, 8332 Telemetry [candidate] (10.769 ms) : 0, 10769 section iast BytebuddyAgent [baseline] (809.527 ms) : 0, 809527 BytebuddyAgent [candidate] (806.593 ms) : 0, 806593 GlobalTracer [baseline] (232.899 ms) : 0, 232899 GlobalTracer [candidate] (232.168 ms) : 0, 232168 IAST [baseline] (29.805 ms) : 0, 29805 IAST [candidate] (28.366 ms) : 0, 28366 AppSec [baseline] (26.504 ms) : 0, 26504 AppSec [candidate] (50.305 ms) : 0, 50305 Debugger [baseline] (5.833 ms) : 0, 5833 Debugger [candidate] (5.91 ms) : 0, 5910 Remote Config [baseline] (595.339 µs) : 0, 595 Remote Config [candidate] (600.513 µs) : 0, 601 Telemetry [baseline] (8.031 ms) : 0, 8031 Telemetry [candidate] (7.989 ms) : 0, 7989 LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~c08ecaa60c, baseline=1.51.0-SNAPSHOT~640fc88be4 dateFormat X axisFormat %s section baseline no_agent (38.525 ms) : 38210, 38840 . : milestone, 38525, appsec (47.421 ms) : 46954, 47888 . : milestone, 47421, code_origins (45.59 ms) : 45206, 45973 . : milestone, 45590, iast (46.469 ms) : 46060, 46877 . : milestone, 46469, profiling (48.185 ms) : 47745, 48624 . : milestone, 48185, tracing (43.458 ms) : 43086, 43831 . : milestone, 43458, section candidate no_agent (35.929 ms) : 35647, 36211 . : milestone, 35929, appsec (48.174 ms) : 47754, 48594 . : milestone, 48174, code_origins (44.6 ms) : 44229, 44971 . : milestone, 44600, iast (44.911 ms) : 44533, 45288 . : milestone, 44911, profiling (48.962 ms) : 48508, 49416 . : milestone, 48962, tracing (43.884 ms) : 43511, 44258 . : milestone, 43884,
Request duration reports for insecure-bankgantt title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~c08ecaa60c, baseline=1.51.0-SNAPSHOT~640fc88be4 dateFormat X axisFormat %s section baseline no_agent (4.562 ms) : 4511, 4614 . : milestone, 4562, iast (9.728 ms) : 9551, 9904 . : milestone, 9728, iast_FULL (14.073 ms) : 13792, 14355 . : milestone, 14073, iast_GLOBAL (10.363 ms) : 10170, 10556 . : milestone, 10363, profiling (8.919 ms) : 8779, 9060 . : milestone, 8919, tracing (7.747 ms) : 7638, 7856 . : milestone, 7747, section candidate no_agent (4.342 ms) : 4294, 4391 . : milestone, 4342, iast (9.212 ms) : 9064, 9360 . : milestone, 9212, iast_FULL (14.346 ms) : 14059, 14632 . : milestone, 14346, iast_GLOBAL (10.282 ms) : 10102, 10463 . : milestone, 10282, profiling (9.191 ms) : 9041, 9341 . : milestone, 9191, tracing (7.568 ms) : 7461, 7676 . : milestone, 7568,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~c08ecaa60c, baseline=1.51.0-SNAPSHOT~640fc88be4 dateFormat X axisFormat %s section baseline no_agent (1.481 ms) : 1469, 1493 . : milestone, 1481, appsec (2.406 ms) : 2357, 2454 . : milestone, 2406, iast (2.195 ms) : 2134, 2257 . : milestone, 2195, iast_GLOBAL (2.242 ms) : 2180, 2304 . : milestone, 2242, profiling (2.053 ms) : 2003, 2103 . : milestone, 2053, tracing (2.015 ms) : 1968, 2063 . : milestone, 2015, section candidate no_agent (1.482 ms) : 1470, 1493 . : milestone, 1482, appsec (2.404 ms) : 2356, 2453 . : milestone, 2404, iast (2.194 ms) : 2133, 2256 . : milestone, 2194, iast_GLOBAL (2.243 ms) : 2181, 2306 . : milestone, 2243, profiling (2.056 ms) : 2005, 2107 . : milestone, 2056, tracing (2.02 ms) : 1972, 2068 . : milestone, 2020,
Execution time for biojavagantt title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~c08ecaa60c, baseline=1.51.0-SNAPSHOT~640fc88be4 dateFormat X axisFormat %s section baseline no_agent (14.98 s) : 14980000, 14980000 . : milestone, 14980000, appsec (14.94 s) : 14940000, 14940000 . : milestone, 14940000, iast (18.749 s) : 18749000, 18749000 . : milestone, 18749000, iast_GLOBAL (17.848 s) : 17848000, 17848000 . : milestone, 17848000, profiling (15.171 s) : 15171000, 15171000 . : milestone, 15171000, tracing (14.854 s) : 14854000, 14854000 . : milestone, 14854000, section candidate no_agent (15.507 s) : 15507000, 15507000 . : milestone, 15507000, appsec (15.117 s) : 15117000, 15117000 . : milestone, 15117000, iast (18.275 s) : 18275000, 18275000 . : milestone, 18275000, iast_GLOBAL (18.021 s) : 18021000, 18021000 . : milestone, 18021000, profiling (14.997 s) : 14997000, 14997000 . : milestone, 14997000, tracing (14.727 s) : 14727000, 14727000 . : milestone, 14727000,
|
Contributor
| I've bypassed CI checks and merged to expedite the release process We will wait for all tests and checks prior to releasing v1.50.1 |
mhlidd changed the title TracePropagationBehaviorExtract=IGNORETracePropagationBehaviorExtract=IGNORE svc-squareup-copybara pushed a commit to cashapp/misk that referenced this pull request Jun 30, 2025
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-spanner](https://github.com/googleapis/java-spanner) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `6.95.1` -> `6.96.0` | | [com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.29.2` -> `2.30.0` | | [com.squareup.okio:okio-fakefilesystem](https://github.com/square/okio) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `3.13.0` -> `3.14.0` | | [com.squareup.okio:okio](https://github.com/square/okio) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `3.13.0` -> `3.14.0` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.50.0` -> `1.50.1` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.71` -> `2.31.73` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.71` -> `2.31.73` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.71` -> `2.31.73` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.71` -> `2.31.73` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.71` -> `2.31.73` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.71` -> `2.31.73` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.71` -> `2.31.73` | --- ### Release Notes <details> <summary>googleapis/java-spanner (com.google.cloud:google-cloud-spanner)</summary> ### [`v6.96.0`](https://github.com/googleapis/java-spanner/blob/HEAD/CHANGELOG.md#6960-2025-06-27) ##### Features - Allow JDBC to configure directpath for connection ([#​3929](googleapis/java-spanner#3929)) ([d754f1f](googleapis/java-spanner@d754f1f)) - Support getOrNull and getOrDefault in Struct ([#​3914](googleapis/java-spanner#3914)) ([1dc5a3e](googleapis/java-spanner@1dc5a3e)) - Use multiplexed sessions for read-only transactions ([#​3917](googleapis/java-spanner#3917)) ([37fdc27](googleapis/java-spanner@37fdc27)) ##### Bug Fixes - Allow zero durations to be set for connections ([#​3916](googleapis/java-spanner#3916)) ([43ea4fa](googleapis/java-spanner@43ea4fa)) ##### Documentation - Add snippet for Repeatable Read configuration at client and transaction ([#​3908](googleapis/java-spanner#3908)) ([ff3d212](googleapis/java-spanner@ff3d212)) - Update SpannerSample.java to align with best practices ([#​3625](googleapis/java-spanner#3625)) ([7bfc62d](googleapis/java-spanner@7bfc62d)) </details> <details> <summary>googleapis/java-datastore (com.google.cloud:google-cloud-datastore)</summary> ### [`v2.30.0`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2300-2025-06-26) ##### Features - Enable grpc configurator for client-side tracing ([#​1886](googleapis/java-datastore#1886)) ([97004c8](googleapis/java-datastore@97004c8)) ##### Dependencies - Update dependency com.google.cloud:gapic-libraries-bom to v1.60.0 ([#​1799](googleapis/java-datastore#1799)) ([bf2a33c](googleapis/java-datastore@bf2a33c)) - Update dependency com.google.cloud:sdk-platform-java-config to v3.50.0 ([#​1897](googleapis/java-datastore#1897)) ([a8d99cd](googleapis/java-datastore@a8d99cd)) - Update googleapis/sdk-platform-java action to v2.59.1 ([#​1880](googleapis/java-datastore#1880)) ([4fb9929](googleapis/java-datastore@4fb9929)) - Update googleapis/sdk-platform-java action to v2.60.0 ([#​1898](googleapis/java-datastore#1898)) ([0921f86](googleapis/java-datastore@0921f86)) </details> <details> <summary>square/okio (com.squareup.okio:okio-fakefilesystem)</summary> ### [`v3.14.0`](https://github.com/square/okio/blob/HEAD/CHANGELOG.md#Version-3140) *2025-06-28* - Upgrade: \[kotlinx-datetime 0.7.0]\[datetime\_0\_7\_0]. This impacts the `okio-fakefilesystem` artifact only. This is a binary-incompatible backwards-incompatible change that cannot co-exist with previous releases of `okio-fakefilesystem`! If you observe a `NoSuchMethodError` calling `FakeFileSystem.init`, update the calling code to this release (or newer) and recompile. We don't like imposing backwards-incompatible changes like this on you and do so regretfully. </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.50.1`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.50.1): 1.50.1 ### Components #### Build & Tooling - ✨ Migrate publishing to Maven Central Portal ([#​9054](DataDog/dd-trace-java#9054) - [@​sarahchen6](https://github.com/sarahchen6)) #### Trace context propagation - 🐛 Drop Baggage when `TracePropagationBehaviorExtract=IGNORE` ([#​9052](DataDog/dd-trace-java#9052) - [@​mhlidd](https://github.com/mhlidd)) #### Tracer public API - 🐛 Fix ArrayIndexOutOfBoundsException in PercentEscaper ([#​9050](DataDog/dd-trace-java#9050) - [@​mhlidd](https://github.com/mhlidd)) ### Instrumentations #### Akka instrumentation - 🐛 Fix NPE in akka-http and pekko-http integrations ([#​9049](DataDog/dd-trace-java#9049) - [@​mcculls](https://github.com/mcculls)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: e80867de3af2534eca79fe17a33f5c76801bcd6a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Backport #9037 to release/v1.50.x