Skip to content

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented Jun 27, 2025

What Does This Do

now it's only an array of probe with type as attribute. This is same format than stored in RemoteConfig.
We need to parse it to look up using the type and reuse the moshi adapters to deserialize the probes.
Add source as LOCAL_FILE

Motivation

Additional Notes

Contributor Checklist

Jira ticket: DEBUG-4103

now it's only an array of probe with type as attribute. This is same format than stored in RemoteConfig. We need to parse it to look up using the type and reuse the moshi adapters to deserialize the probes. Add source as LOCAL_FILE
@jpbempel jpbempel added type: enhancement Enhancements and improvements comp: debugger Dynamic Instrumentation labels Jun 27, 2025
@pr-commenter
Copy link

pr-commenter bot commented Jun 27, 2025

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1752048795 1752049179
end_time 2025-07-09T08:14:36 2025-07-09T08:20:59
git_branch master jpbempel/update-probe-file-format
git_commit_sha 16eee52 8a4254a
start_time 2025-07-09T08:13:16 2025-07-09T08:19:40
See matching parameters
Baseline Candidate
ci_job_id 1019996361 1019996361
ci_pipeline_id 70011296 70011296
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1752048226 1752048226

Summary

Found 8 performance improvements and 0 performance regressions! Performance is the same for 0 metrics, 7 unstable metrics.

scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:basic better
[-35.074µs; -26.918µs] or [-12.575%; -9.651%]
better
[-45.726µs; -29.398µs] or [-14.490%; -9.316%]
better
[-47.774µs; -29.789µs] or [-14.625%; -9.120%]
unstable
[-150.891µs; +8.390µs] or [-17.879%; +0.994%]
unstable
[+46.998op/s; +338.111op/s] or [+1.927%; +13.863%]
scenario:loop better
[-1.918ms; -1.862ms] or [-17.825%; -17.305%]
better
[-2.004ms; -1.934ms] or [-18.314%; -17.679%]
better
[-2.015ms; -1.938ms] or [-18.310%; -17.608%]
better
[-2.315ms; -2.061ms] or [-20.395%; -18.159%]
better
[+18.310op/s; +20.475op/s] or [+20.232%; +22.625%]
See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-23.203µs; +29.539µs] or [-8.493%; +10.812%]
unstable
[-31.587µs; +44.014µs] or [-10.082%; +14.048%]
unstable
[-40.145µs; +59.921µs] or [-12.287%; +18.340%]
unstable
[-249.633µs; -20.633µs] or [-23.612%; -1.952%]
unstable
[-94.234op/s; +155.962op/s] or [-3.816%; +6.316%]
Request duration reports for reports
gantt title reports - request duration [CI 0.99] : candidate=None, baseline=None dateFormat X axisFormat %s section baseline noprobe (313.309 µs) : 290, 337 . : milestone, 313, basic (315.559 µs) : 306, 325 . : milestone, 316, loop (10.941 ms) : 10896, 10986 . : milestone, 10941, section candidate noprobe (319.522 µs) : 274, 365 . : milestone, 320, basic (277.997 µs) : 272, 284 . : milestone, 278, loop (8.972 ms) : 8967, 8977 . : milestone, 8972, 
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 313.309 µs [289.911 µs, 336.706 µs]
basic 315.559 µs [305.984 µs, 325.134 µs]
loop 10.941 ms [10.896 ms, 10.986 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 319.522 µs [274.315 µs, 364.729 µs]
basic 277.997 µs [272.039 µs, 283.955 µs]
loop 8.972 ms [8.967 ms, 8.977 ms]
@pr-commenter
Copy link

pr-commenter bot commented Jun 27, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/update-probe-file-format
git_commit_date 1752048042 1752048226
git_commit_sha 16eee52 8a4254a
release_version 1.51.0-SNAPSHOT~16eee52b4d 1.51.0-SNAPSHOT~8a4254af76
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1752049956 1752049956
ci_job_id 1019996348 1019996348
ci_pipeline_id 70011296 70011296
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-6mtxt1pk 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-6mtxt1pk 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 8 unstable metrics.

Startup time reports for petclinic
gantt title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~8a4254af76, baseline=1.51.0-SNAPSHOT~16eee52b4d dateFormat X axisFormat %s section tracing Agent [baseline] (994.067 ms) : 0, 994067 Total [baseline] (10.667 s) : 0, 10666588 Agent [candidate] (999.622 ms) : 0, 999622 Total [candidate] (10.667 s) : 0, 10666523 section appsec Agent [baseline] (1.177 s) : 0, 1176955 Total [baseline] (10.716 s) : 0, 10715888 Agent [candidate] (1.175 s) : 0, 1175255 Total [candidate] (10.701 s) : 0, 10701367 section iast Agent [baseline] (1.143 s) : 0, 1142950 Total [baseline] (10.966 s) : 0, 10965828 Agent [candidate] (1.129 s) : 0, 1128504 Total [candidate] (10.822 s) : 0, 10822296 section profiling Agent [baseline] (1.245 s) : 0, 1245138 Total [baseline] (10.882 s) : 0, 10882111 Agent [candidate] (1.244 s) : 0, 1244256 Total [candidate] (10.929 s) : 0, 10929357 
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 994.067 ms -
Agent appsec 1.177 s 182.888 ms (18.4%)
Agent iast 1.143 s 148.884 ms (15.0%)
Agent profiling 1.245 s 251.071 ms (25.3%)
Total tracing 10.667 s -
Total appsec 10.716 s 49.3 ms (0.5%)
Total iast 10.966 s 299.24 ms (2.8%)
Total profiling 10.882 s 215.523 ms (2.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 999.622 ms -
Agent appsec 1.175 s 175.633 ms (17.6%)
Agent iast 1.129 s 128.882 ms (12.9%)
Agent profiling 1.244 s 244.635 ms (24.5%)
Total tracing 10.667 s -
Total appsec 10.701 s 34.843 ms (0.3%)
Total iast 10.822 s 155.772 ms (1.5%)
Total profiling 10.929 s 262.834 ms (2.5%)
gantt title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~8a4254af76, baseline=1.51.0-SNAPSHOT~16eee52b4d dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (686.716 ms) : 0, 686716 BytebuddyAgent [candidate] (690.297 ms) : 0, 690297 GlobalTracer [baseline] (241.503 ms) : 0, 241503 GlobalTracer [candidate] (243.072 ms) : 0, 243072 AppSec [baseline] (30.112 ms) : 0, 30112 AppSec [candidate] (30.433 ms) : 0, 30433 Debugger [baseline] (6.082 ms) : 0, 6082 Debugger [candidate] (6.036 ms) : 0, 6036 Remote Config [baseline] (681.87 µs) : 0, 682 Remote Config [candidate] (680.091 µs) : 0, 680 Telemetry [baseline] (8.198 ms) : 0, 8198 Telemetry [candidate] (8.224 ms) : 0, 8224 section appsec BytebuddyAgent [baseline] (711.064 ms) : 0, 711064 BytebuddyAgent [candidate] (710.073 ms) : 0, 710073 GlobalTracer [baseline] (235.901 ms) : 0, 235901 GlobalTracer [candidate] (235.42 ms) : 0, 235420 IAST [baseline] (23.323 ms) : 0, 23323 IAST [candidate] (23.13 ms) : 0, 23130 AppSec [baseline] (171.299 ms) : 0, 171299 AppSec [candidate] (171.427 ms) : 0, 171427 Debugger [baseline] (5.781 ms) : 0, 5781 Debugger [candidate] (5.696 ms) : 0, 5696 Remote Config [baseline] (605.719 µs) : 0, 606 Remote Config [candidate] (596.843 µs) : 0, 597 Telemetry [baseline] (8.116 ms) : 0, 8116 Telemetry [candidate] (8.057 ms) : 0, 8057 section iast BytebuddyAgent [baseline] (814.738 ms) : 0, 814738 BytebuddyAgent [candidate] (804.595 ms) : 0, 804595 GlobalTracer [baseline] (234.641 ms) : 0, 234641 GlobalTracer [candidate] (231.535 ms) : 0, 231535 IAST [baseline] (28.857 ms) : 0, 28857 IAST [candidate] (27.676 ms) : 0, 27676 AppSec [baseline] (29.217 ms) : 0, 29217 AppSec [candidate] (29.787 ms) : 0, 29787 Debugger [baseline] (5.93 ms) : 0, 5930 Debugger [candidate] (5.713 ms) : 0, 5713 Remote Config [baseline] (593.049 µs) : 0, 593 Remote Config [candidate] (576.624 µs) : 0, 577 Telemetry [baseline] (8.05 ms) : 0, 8050 Telemetry [candidate] (7.869 ms) : 0, 7869 section profiling BytebuddyAgent [baseline] (677.913 ms) : 0, 677913 BytebuddyAgent [candidate] (676.543 ms) : 0, 676543 GlobalTracer [baseline] (361.363 ms) : 0, 361363 GlobalTracer [candidate] (361.515 ms) : 0, 361515 AppSec [baseline] (31.659 ms) : 0, 31659 AppSec [candidate] (31.716 ms) : 0, 31716 Debugger [baseline] (12.118 ms) : 0, 12118 Debugger [candidate] (10.46 ms) : 0, 10460 Remote Config [baseline] (664.474 µs) : 0, 664 Remote Config [candidate] (671.995 µs) : 0, 672 Telemetry [baseline] (7.986 ms) : 0, 7986 Telemetry [candidate] (10.206 ms) : 0, 10206 ProfilingAgent [baseline] (104.203 ms) : 0, 104203 ProfilingAgent [candidate] (104.643 ms) : 0, 104643 Profiling [baseline] (104.227 ms) : 0, 104227 Profiling [candidate] (104.667 ms) : 0, 104667 
Loading
Startup time reports for insecure-bank
gantt title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~8a4254af76, baseline=1.51.0-SNAPSHOT~16eee52b4d dateFormat X axisFormat %s section tracing Agent [baseline] (1.0 s) : 0, 1000472 Total [baseline] (8.567 s) : 0, 8567355 Agent [candidate] (998.204 ms) : 0, 998204 Total [candidate] (8.585 s) : 0, 8585134 section iast Agent [baseline] (1.138 s) : 0, 1138359 Total [baseline] (9.282 s) : 0, 9281643 Agent [candidate] (1.13 s) : 0, 1129890 Total [candidate] (9.287 s) : 0, 9287066 
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.0 s -
Agent iast 1.138 s 137.888 ms (13.8%)
Total tracing 8.567 s -
Total iast 9.282 s 714.289 ms (8.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 998.204 ms -
Agent iast 1.13 s 131.685 ms (13.2%)
Total tracing 8.585 s -
Total iast 9.287 s 701.932 ms (8.2%)
gantt title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~8a4254af76, baseline=1.51.0-SNAPSHOT~16eee52b4d dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (691.213 ms) : 0, 691213 BytebuddyAgent [candidate] (689.208 ms) : 0, 689208 GlobalTracer [baseline] (242.93 ms) : 0, 242930 GlobalTracer [candidate] (242.975 ms) : 0, 242975 AppSec [baseline] (30.405 ms) : 0, 30405 AppSec [candidate] (30.285 ms) : 0, 30285 Debugger [baseline] (6.115 ms) : 0, 6115 Debugger [candidate] (5.972 ms) : 0, 5972 Remote Config [baseline] (675.681 µs) : 0, 676 Remote Config [candidate] (676.749 µs) : 0, 677 Telemetry [baseline] (8.23 ms) : 0, 8230 Telemetry [candidate] (8.235 ms) : 0, 8235 section iast BytebuddyAgent [baseline] (812.6 ms) : 0, 812600 BytebuddyAgent [candidate] (806.16 ms) : 0, 806160 GlobalTracer [baseline] (232.777 ms) : 0, 232777 GlobalTracer [candidate] (232.538 ms) : 0, 232538 IAST [baseline] (27.179 ms) : 0, 27179 IAST [candidate] (26.854 ms) : 0, 26854 AppSec [baseline] (30.683 ms) : 0, 30683 AppSec [candidate] (29.428 ms) : 0, 29428 Debugger [baseline] (5.776 ms) : 0, 5776 Debugger [candidate] (5.719 ms) : 0, 5719 Remote Config [baseline] (590.462 µs) : 0, 590 Remote Config [candidate] (584.125 µs) : 0, 584 Telemetry [baseline] (7.893 ms) : 0, 7893 Telemetry [candidate] (7.912 ms) : 0, 7912 
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/update-probe-file-format
git_commit_date 1752048042 1752048226
git_commit_sha 16eee52 8a4254a
release_version 1.51.0-SNAPSHOT~16eee52b4d 1.51.0-SNAPSHOT~8a4254af76
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1752049639 1752049639
ci_job_id 1019996350 1019996350
ci_pipeline_id 70011296 70011296
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-la3jpuu3 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-la3jpuu3 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 1 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:iast:high_load better
[-2.012ms; -1.177ms] or [-4.391%; -2.570%]
unstable
[-3.767op/s; +11.217op/s] or [-3.688%; +10.981%]
44.220ms 105.875op/s 45.814ms 102.150op/s
scenario:load:petclinic:no_agent:high_load better
[-1.746ms; -1.079ms] or [-4.536%; -2.803%]
unstable
[-3.985op/s; +13.310op/s] or [-3.280%; +10.955%]
37.075ms 126.162op/s 38.487ms 121.500op/s
scenario:load:petclinic:appsec:high_load worse
[+1.655ms; +2.574ms] or [+3.621%; +5.630%]
unstable
[-12.023op/s; +3.073op/s] or [-11.747%; +3.003%]
47.833ms 97.875op/s 45.719ms 102.350op/s
Request duration reports for insecure-bank
gantt title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~8a4254af76, baseline=1.51.0-SNAPSHOT~16eee52b4d dateFormat X axisFormat %s section baseline no_agent (4.392 ms) : 4342, 4442 . : milestone, 4392, iast (9.095 ms) : 8948, 9241 . : milestone, 9095, iast_FULL (14.047 ms) : 13774, 14320 . : milestone, 14047, iast_GLOBAL (9.911 ms) : 9738, 10085 . : milestone, 9911, profiling (8.256 ms) : 8129, 8383 . : milestone, 8256, tracing (7.634 ms) : 7516, 7752 . : milestone, 7634, section candidate no_agent (4.481 ms) : 4431, 4531 . : milestone, 4481, iast (9.332 ms) : 9179, 9485 . : milestone, 9332, iast_FULL (13.785 ms) : 13512, 14059 . : milestone, 13785, iast_GLOBAL (10.113 ms) : 9937, 10290 . : milestone, 10113, profiling (8.295 ms) : 8164, 8427 . : milestone, 8295, tracing (7.572 ms) : 7457, 7686 . : milestone, 7572, 
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.392 ms [4.342 ms, 4.442 ms] -
iast 9.095 ms [8.948 ms, 9.241 ms] 4.703 ms (107.1%)
iast_FULL 14.047 ms [13.774 ms, 14.32 ms] 9.655 ms (219.8%)
iast_GLOBAL 9.911 ms [9.738 ms, 10.085 ms] 5.52 ms (125.7%)
profiling 8.256 ms [8.129 ms, 8.383 ms] 3.864 ms (88.0%)
tracing 7.634 ms [7.516 ms, 7.752 ms] 3.242 ms (73.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.481 ms [4.431 ms, 4.531 ms] -
iast 9.332 ms [9.179 ms, 9.485 ms] 4.851 ms (108.3%)
iast_FULL 13.785 ms [13.512 ms, 14.059 ms] 9.304 ms (207.6%)
iast_GLOBAL 10.113 ms [9.937 ms, 10.29 ms] 5.632 ms (125.7%)
profiling 8.295 ms [8.164 ms, 8.427 ms] 3.814 ms (85.1%)
tracing 7.572 ms [7.457 ms, 7.686 ms] 3.091 ms (69.0%)
Request duration reports for petclinic
gantt title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~8a4254af76, baseline=1.51.0-SNAPSHOT~16eee52b4d dateFormat X axisFormat %s section baseline no_agent (38.487 ms) : 38170, 38804 . : milestone, 38487, appsec (45.719 ms) : 45307, 46130 . : milestone, 45719, code_origins (44.692 ms) : 44295, 45089 . : milestone, 44692, iast (45.814 ms) : 45415, 46213 . : milestone, 45814, profiling (48.283 ms) : 47804, 48761 . : milestone, 48283, tracing (44.18 ms) : 43808, 44552 . : milestone, 44180, section candidate no_agent (37.075 ms) : 36772, 37378 . : milestone, 37075, appsec (47.833 ms) : 47392, 48275 . : milestone, 47833, code_origins (45.371 ms) : 44981, 45761 . : milestone, 45371, iast (44.22 ms) : 43843, 44596 . : milestone, 44220, profiling (48.015 ms) : 47556, 48474 . : milestone, 48015, tracing (44.872 ms) : 44491, 45254 . : milestone, 44872, 
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 38.487 ms [38.17 ms, 38.804 ms] -
appsec 45.719 ms [45.307 ms, 46.13 ms] 7.231 ms (18.8%)
code_origins 44.692 ms [44.295 ms, 45.089 ms] 6.204 ms (16.1%)
iast 45.814 ms [45.415 ms, 46.213 ms] 7.327 ms (19.0%)
profiling 48.283 ms [47.804 ms, 48.761 ms] 9.795 ms (25.5%)
tracing 44.18 ms [43.808 ms, 44.552 ms] 5.692 ms (14.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 37.075 ms [36.772 ms, 37.378 ms] -
appsec 47.833 ms [47.392 ms, 48.275 ms] 10.758 ms (29.0%)
code_origins 45.371 ms [44.981 ms, 45.761 ms] 8.296 ms (22.4%)
iast 44.22 ms [43.843 ms, 44.596 ms] 7.145 ms (19.3%)
profiling 48.015 ms [47.556 ms, 48.474 ms] 10.94 ms (29.5%)
tracing 44.872 ms [44.491 ms, 45.254 ms] 7.797 ms (21.0%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/update-probe-file-format
git_commit_date 1752048042 1752048226
git_commit_sha 16eee52 8a4254a
release_version 1.51.0-SNAPSHOT~16eee52b4d 1.51.0-SNAPSHOT~8a4254af76
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1752050200 1752050200
ci_job_id 1019996352 1019996352
ci_pipeline_id 70011296 70011296
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-i57riaam 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-i57riaam 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava
gantt title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~8a4254af76, baseline=1.51.0-SNAPSHOT~16eee52b4d dateFormat X axisFormat %s section baseline no_agent (14.879 s) : 14879000, 14879000 . : milestone, 14879000, appsec (14.847 s) : 14847000, 14847000 . : milestone, 14847000, iast (18.183 s) : 18183000, 18183000 . : milestone, 18183000, iast_GLOBAL (18.23 s) : 18230000, 18230000 . : milestone, 18230000, profiling (14.99 s) : 14990000, 14990000 . : milestone, 14990000, tracing (15.11 s) : 15110000, 15110000 . : milestone, 15110000, section candidate no_agent (15.741 s) : 15741000, 15741000 . : milestone, 15741000, appsec (15.016 s) : 15016000, 15016000 . : milestone, 15016000, iast (18.762 s) : 18762000, 18762000 . : milestone, 18762000, iast_GLOBAL (17.637 s) : 17637000, 17637000 . : milestone, 17637000, profiling (15.356 s) : 15356000, 15356000 . : milestone, 15356000, tracing (14.76 s) : 14760000, 14760000 . : milestone, 14760000, 
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.879 s [14.879 s, 14.879 s] -
appsec 14.847 s [14.847 s, 14.847 s] -32.0 ms (-0.2%)
iast 18.183 s [18.183 s, 18.183 s] 3.304 s (22.2%)
iast_GLOBAL 18.23 s [18.23 s, 18.23 s] 3.351 s (22.5%)
profiling 14.99 s [14.99 s, 14.99 s] 111.0 ms (0.7%)
tracing 15.11 s [15.11 s, 15.11 s] 231.0 ms (1.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.741 s [15.741 s, 15.741 s] -
appsec 15.016 s [15.016 s, 15.016 s] -725.0 ms (-4.6%)
iast 18.762 s [18.762 s, 18.762 s] 3.021 s (19.2%)
iast_GLOBAL 17.637 s [17.637 s, 17.637 s] 1.896 s (12.0%)
profiling 15.356 s [15.356 s, 15.356 s] -385.0 ms (-2.4%)
tracing 14.76 s [14.76 s, 14.76 s] -981.0 ms (-6.2%)
Execution time for tomcat
gantt title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~8a4254af76, baseline=1.51.0-SNAPSHOT~16eee52b4d dateFormat X axisFormat %s section baseline no_agent (1.474 ms) : 1463, 1486 . : milestone, 1474, appsec (2.415 ms) : 2365, 2466 . : milestone, 2415, iast (2.197 ms) : 2134, 2260 . : milestone, 2197, iast_GLOBAL (2.241 ms) : 2178, 2304 . : milestone, 2241, profiling (2.046 ms) : 1996, 2097 . : milestone, 2046, tracing (2.017 ms) : 1969, 2066 . : milestone, 2017, section candidate no_agent (1.476 ms) : 1464, 1487 . : milestone, 1476, appsec (2.406 ms) : 2356, 2456 . : milestone, 2406, iast (2.19 ms) : 2127, 2252 . : milestone, 2190, iast_GLOBAL (2.236 ms) : 2174, 2299 . : milestone, 2236, profiling (2.062 ms) : 2010, 2113 . : milestone, 2062, tracing (2.015 ms) : 1967, 2064 . : milestone, 2015, 
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.474 ms [1.463 ms, 1.486 ms] -
appsec 2.415 ms [2.365 ms, 2.466 ms] 941.389 µs (63.9%)
iast 2.197 ms [2.134 ms, 2.26 ms] 722.555 µs (49.0%)
iast_GLOBAL 2.241 ms [2.178 ms, 2.304 ms] 767.065 µs (52.0%)
profiling 2.046 ms [1.996 ms, 2.097 ms] 572.368 µs (38.8%)
tracing 2.017 ms [1.969 ms, 2.066 ms] 543.156 µs (36.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.476 ms [1.464 ms, 1.487 ms] -
appsec 2.406 ms [2.356 ms, 2.456 ms] 930.237 µs (63.0%)
iast 2.19 ms [2.127 ms, 2.252 ms] 713.893 µs (48.4%)
iast_GLOBAL 2.236 ms [2.174 ms, 2.299 ms] 760.476 µs (51.5%)
profiling 2.062 ms [2.01 ms, 2.113 ms] 585.69 µs (39.7%)
tracing 2.015 ms [1.967 ms, 2.064 ms] 539.324 µs (36.5%)
@jpbempel jpbempel requested a review from evanchooly July 7, 2025 12:56
Copy link
Contributor

@evanchooly evanchooly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good apart from the one comment

public class MoshiHelper {

public static Moshi createMoshiConfig() {
return createMoshiConfigBuilder().build();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems a random, unrelated change.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not random, I want a builder to add option for tests, while most of the time i need just a Moshi instance

@jpbempel
Copy link
Member Author

jpbempel commented Jul 9, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Jul 9, 2025

View all feedbacks in Devflow UI.

2025-07-09 06:03:58 UTC ℹ️ Start processing command /merge


2025-07-09 06:04:06 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-07-09 06:04:48 UTC ⚠️ MergeQueue: This merge request was unqueued

jean-philippe.bempel@datadoghq.com unqueued this merge request

@jpbempel
Copy link
Member Author

jpbempel commented Jul 9, 2025

/merge -c

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Jul 9, 2025

View all feedbacks in Devflow UI.

2025-07-09 06:04:43 UTC ℹ️ Start processing command /merge -c

@jpbempel jpbempel requested a review from a team as a code owner July 9, 2025 08:03
@jpbempel jpbempel requested review from ojung and removed request for a team July 9, 2025 08:03
@jpbempel jpbempel merged commit 2a04939 into master Jul 9, 2025
514 checks passed
@jpbempel jpbempel deleted the jpbempel/update-probe-file-format branch July 9, 2025 09:45
@github-actions github-actions bot added this to the 1.51.0 milestone Jul 9, 2025
svc-squareup-copybara pushed a commit to cashapp/misk that referenced this pull request Jul 10, 2025
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.errorprone:error_prone_annotations](https://errorprone.info) ([source](https://github.com/google/error-prone)) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.39.0` -> `2.40.0` | | [org.apache.commons:commons-lang3](https://commons.apache.org/proper/commons-lang/) ([source](https://gitbox.apache.org/repos/asf/commons-lang.git)) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `3.17.0` -> `3.18.0` | | [org.jetbrains.kotlinx.binary-compatibility-validator](https://github.com/Kotlin/binary-compatibility-validator) | plugin | misk/gradle/libs.versions.toml | gradle | patch | `0.18.0` -> `0.18.1` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.50.1` -> `1.51.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | --- ### Release Notes <details> <summary>google/error-prone (com.google.errorprone:error_prone_annotations)</summary> ### [`v2.40.0`](https://github.com/google/error-prone/releases/tag/v2.40.0): Error Prone 2.40.0 Changes: - Bug fixes and improvements - Releases (including snapshots) have migrated from [OSSRH to the Central Publisher Portal](https://central.sonatype.org/pages/ossrh-eol/#process-to-migrate) Full changelog: google/error-prone@v2.39.0...v2.40.0 </details> <details> <summary>Kotlin/binary-compatibility-validator (org.jetbrains.kotlinx.binary-compatibility-validator)</summary> ### [`v0.18.1`](https://github.com/Kotlin/binary-compatibility-validator/releases/tag/0.18.1) [Compare Source](Kotlin/binary-compatibility-validator@0.18.0...0.18.1) #### What's Changed - Fixed a bug preventing use of cross-compilation support during KLIB dump validation \[[#&#8203;304](https://github.com/Kotlin/binary-compatibility-validator/issues/304)]\[[#&#8203;306](https://github.com/Kotlin/binary-compatibility-validator/issues/306)] </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.51.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.51.0): 1.51.0 ### Components #### Application Security Management (IAST) - 🐛 Fix verify error when ctor params are used after a call site ([#&#8203;9083](DataDog/dd-trace-java#9083) - [@&#8203;manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛 Limit the maximum size of the location path in IAST vulnerabilities ([#&#8203;9028](DataDog/dd-trace-java#9028) - [@&#8203;jandro996](https://github.com/jandro996)) - 🐛 Fix IAST gRPC handler with null superclass ([#&#8203;8984](DataDog/dd-trace-java#8984) - [@&#8203;smola](https://github.com/smola)) - ✨ Optimize IAST Vulnerability Detection ([#&#8203;8885](DataDog/dd-trace-java#8885) - [@&#8203;jandro996](https://github.com/jandro996)) #### Application Security Management (WAF) - ✨ Upgrade libddwaf-java to 15.0.0 ([#&#8203;9022](DataDog/dd-trace-java#9022) - [@&#8203;sezen-datadog](https://github.com/sezen-datadog)) - ✨ Extract RestEasy json body response schemas ([#&#8203;9015](DataDog/dd-trace-java#9015) - [@&#8203;jandro996](https://github.com/jandro996)) - ✨ Extract Jersey json body response schemas ([#&#8203;9014](DataDog/dd-trace-java#9014) - [@&#8203;jandro996](https://github.com/jandro996)) - ✨ Extract Ratpack json body response schemas ([#&#8203;9013](DataDog/dd-trace-java#9013) - [@&#8203;manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Enable API Security by default and make it lazy loading ([#&#8203;9009](DataDog/dd-trace-java#9009) - [@&#8203;smola](https://github.com/smola)) - ✨ Extract Vert.x json body response schemas ([#&#8203;9001](DataDog/dd-trace-java#9001) - [@&#8203;manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Extract Play json body response schemas ([#&#8203;8995](DataDog/dd-trace-java#8995) - [@&#8203;manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛 Fix Jackson nodes introspection for request/response schema extraction ([#&#8203;8980](DataDog/dd-trace-java#8980) - [@&#8203;manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Extract Spring json body response schemas ([#&#8203;8938](DataDog/dd-trace-java#8938) - [@&#8203;sezen-datadog](https://github.com/sezen-datadog)) - ✨ Default obfuscation regexp update ([#&#8203;8937](DataDog/dd-trace-java#8937) - [@&#8203;sezen-datadog](https://github.com/sezen-datadog)) #### Build & Tooling - ✨ Cancel GitLab running pipeline on new PR push ([#&#8203;9023](DataDog/dd-trace-java#9023) - [@&#8203;PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Migrate publishing to Maven Central Portal ([#&#8203;8807](DataDog/dd-trace-java#8807) - [@&#8203;sarahchen6](https://github.com/sarahchen6)) #### Continuous Integration Visibility - 🐛 Fix Test Optimization to work with JDK 24 ([#&#8203;9114](DataDog/dd-trace-java#9114) - [@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add repo root as safe directory on git client creation ([#&#8203;9033](DataDog/dd-trace-java#9033) - [@&#8203;daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Add PR number tag and improve PR information building ([#&#8203;8990](DataDog/dd-trace-java#8990) - [@&#8203;daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Update impacted tests logic ([#&#8203;8923](DataDog/dd-trace-java#8923) - [@&#8203;daniel-mohedano](https://github.com/daniel-mohedano)) #### Data Streams Monitoring - 🧹 Clean up DSM context injection ([#&#8203;8776](DataDog/dd-trace-java#8776) - [@&#8203;PerfectSlayer](https://github.com/PerfectSlayer)) #### Database Monitoring - 🐛 Set trace\_injected in try block ([#&#8203;9025](DataDog/dd-trace-java#9025) - [@&#8203;natashadada](https://github.com/natashadada)) #### Dynamic Instrumentation - 🐛 Add source file tracking enable option ([#&#8203;9115](DataDog/dd-trace-java#9115) - [@&#8203;jpbempel](https://github.com/jpbempel)) - ✨ Add java.util.Date support ([#&#8203;9111](DataDog/dd-trace-java#9111) - [@&#8203;jpbempel](https://github.com/jpbempel)) - ✨ Update file probe format ([#&#8203;9047](DataDog/dd-trace-java#9047) - [@&#8203;jpbempel](https://github.com/jpbempel)) - ✨ add safe local var hoisting ([#&#8203;9034](DataDog/dd-trace-java#9034) - [@&#8203;jpbempel](https://github.com/jpbempel)) - 🧹 Add new config for debugger upload interval ([#&#8203;8959](DataDog/dd-trace-java#8959) - [@&#8203;jpbempel](https://github.com/jpbempel)) - ✨ Enable Code Origin with Dynamic instrumentation ([#&#8203;8940](DataDog/dd-trace-java#8940) - [@&#8203;jpbempel](https://github.com/jpbempel)) #### ML Observability (LLMObs) - 💡 LLM Observability SDK ([#&#8203;8781](DataDog/dd-trace-java#8781) - [@&#8203;gary-huang](https://github.com/gary-huang), [@&#8203;nayeem-kamal](https://github.com/nayeem-kamal)) #### Metrics - 🐛 Ensure client stat reporter is started when the agent is not available at bootstrap ([#&#8203;9082](DataDog/dd-trace-java#9082) - [@&#8203;amarziali](https://github.com/amarziali)) - ✨ Create metric: appsec.waf.config\_errors ([#&#8203;8394](DataDog/dd-trace-java#8394) - [@&#8203;sezen-datadog](https://github.com/sezen-datadog)) #### Platform components - ✨ Introduce environment component ([#&#8203;9071](DataDog/dd-trace-java#9071) - [@&#8203;PerfectSlayer](https://github.com/PerfectSlayer)) #### Profiling - 🐛 Remove annoying warning for smap event parsing ([#&#8203;9119](DataDog/dd-trace-java#9119) - [@&#8203;jbachorik](https://github.com/jbachorik)) - 🐛 Fix ByteCountingInputStream when reading past EOF ([#&#8203;8988](DataDog/dd-trace-java#8988) - [@&#8203;manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### Realtime User Monitoring - ✨ Add RUM SDK injection for servlet based web servers ([#&#8203;9110](DataDog/dd-trace-java#9110) - [@&#8203;PerfectSlayer](https://github.com/PerfectSlayer) [@&#8203;amarziali](https://github.com/amarziali)) #### Telemetry - ✨ Update the config origin metric to match what it's mapping ([#&#8203;9045](DataDog/dd-trace-java#9045) - [@&#8203;sezen-datadog](https://github.com/sezen-datadog)) #### Testing - ✨ Add testing for latest stable version (JDK 24) ([#&#8203;8875](DataDog/dd-trace-java#8875) - [@&#8203;sarahchen6](https://github.com/sarahchen6)) #### Trace context propagation - 🐛 Fix bug with dropping baggage when `TracePropagationBehaviorExtract=IGNORE` ([#&#8203;9037](DataDog/dd-trace-java#9037) - [@&#8203;mhlidd](https://github.com/mhlidd)) - 🐛 Fix ArrayIndexOutOfBoundsException in PercentEscaper ([#&#8203;9032](DataDog/dd-trace-java#9032) - [@&#8203;mhlidd](https://github.com/mhlidd)) #### Tracer core - 🐛 Fix `Error` handling for trace interceptors ([#&#8203;9097](DataDog/dd-trace-java#9097) - [@&#8203;AlexeyKuznetsov-DD](https://github.com/AlexeyKuznetsov-DD)) - 💡 Add wildcard feature for `DD_TRACE_HEADER_TAGS` and enabling for Http Response headers ([#&#8203;9067](DataDog/dd-trace-java#9067) - [@&#8203;mhlidd](https://github.com/mhlidd)) #### Tracer public API - 💡 Add LLM Observability SDK ([#&#8203;8781](DataDog/dd-trace-java#8781) - [@&#8203;gary-huang](https://github.com/gary-huang)) ### Instrumentations #### Akka instrumentation - 🐛 Fix NPE in akka-http and pekko-http integrations ([#&#8203;9019](DataDog/dd-trace-java#9019) - [@&#8203;mcculls](https://github.com/mcculls)) #### Eclipse Vert.x instrumentation - ✨ Extract Vert.x json body response schemas ([#&#8203;9001](DataDog/dd-trace-java#9001) - [@&#8203;manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Write http.route tag as soon as possible in vert.x ([#&#8203;8952](DataDog/dd-trace-java#8952) - [@&#8203;manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### JAX-WS instrumentation - 💡⚠️ Enable jax-ws integration by default ([#&#8203;9030](DataDog/dd-trace-java#9030) - [@&#8203;bm1549](https://github.com/bm1549)) - ✨ Extract Jersey json body response schemas ([#&#8203;9014](DataDog/dd-trace-java#9014) - [@&#8203;jandro996](https://github.com/jandro996)) #### Mule instrumentation - 🐛 Propagate grizzly http span in filters if nothing is active ([#&#8203;9016](DataDog/dd-trace-java#9016) - [@&#8203;amarziali](https://github.com/amarziali)) #### Play Framework instrumentation - ✨ Extract Play json body response schemas ([#&#8203;8995](DataDog/dd-trace-java#8995) - [@&#8203;manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### Ratpack instrumentation - ✨ Extract Ratpack json body response schemas ([#&#8203;9013](DataDog/dd-trace-java#9013) - [@&#8203;manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### Spring instrumentation - ✨ Extract Spring json body response schemas ([#&#8203;8938](DataDog/dd-trace-java#8938) - [@&#8203;sezen-datadog](https://github.com/sezen-datadog)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 649b690d4c9d7dcb572c457f0802b42b8e3e682e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: debugger Dynamic Instrumentation type: enhancement Enhancements and improvements

3 participants