Support vertx 5 #8220
Merged
Support vertx 5 #8220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
...a-agent/instrumentation/vertx-web-4.0/src/latestDepTest/java/server/IastSourcesVerticle.java Show resolved Hide resolved
...a-agent/instrumentation/vertx-web-4.0/src/latestDepTest/java/server/IastSourcesVerticle.java Show resolved Hide resolved
dd-java-agent/instrumentation/vertx-web-4.0/src/latestDepTest/java/server/VertxTestServer.java Show resolved Hide resolved
dd-java-agent/instrumentation/vertx-web-4.0/src/latestDepTest/java/server/VertxTestServer.java Show resolved Hide resolved
...a-agent/instrumentation/vertx-web-4.0/src/latestDepTest/java/server/IastSourcesVerticle.java Show resolved Hide resolved
dd-java-agent/instrumentation/vertx-web-4.0/src/latestDepTest/java/server/VertxTestServer.java Show resolved Hide resolved
...a-agent/instrumentation/vertx-web-4.0/src/latestDepTest/java/server/IastSourcesVerticle.java Show resolved Hide resolved
amarziali added type: enhancement 
vandonr reviewed Jan 16, 2025
vandonr approved these changes Jan 16, 2025
Contributor
vandonr left a comment
vandonr left a comment There was a problem hiding this comment.
LGTM, I merely skimmed over the tests assuming they were mostly adapted from the existing ones. Might need an approval from AppSec as well.
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics. Startup time reports for petclinicgantt title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~1a5dccd365, baseline=1.46.0-SNAPSHOT~148aef92ab dateFormat X axisFormat %s section tracing Agent [baseline] (1.064 s) : 0, 1064430 Total [baseline] (10.467 s) : 0, 10467337 Agent [candidate] (1.058 s) : 0, 1057779 Total [candidate] (10.44 s) : 0, 10440349 section appsec Agent [baseline] (1.191 s) : 0, 1191267 Total [baseline] (10.733 s) : 0, 10733459 Agent [candidate] (1.19 s) : 0, 1190198 Total [candidate] (10.711 s) : 0, 10710618 section iast Agent [baseline] (1.184 s) : 0, 1183731 Total [baseline] (10.976 s) : 0, 10976365 Agent [candidate] (1.206 s) : 0, 1206355 Total [candidate] (10.999 s) : 0, 10999474 section profiling Agent [baseline] (1.252 s) : 0, 1251594 Total [baseline] (10.813 s) : 0, 10813202 Agent [candidate] (1.257 s) : 0, 1257147 Total [candidate] (10.864 s) : 0, 10863889
gantt title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~1a5dccd365, baseline=1.46.0-SNAPSHOT~148aef92ab dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (720.203 ms) : 0, 720203 BytebuddyAgent [candidate] (715.268 ms) : 0, 715268 GlobalTracer [baseline] (257.681 ms) : 0, 257681 GlobalTracer [candidate] (256.071 ms) : 0, 256071 AppSec [baseline] (56.283 ms) : 0, 56283 AppSec [candidate] (56.536 ms) : 0, 56536 Remote Config [baseline] (728.336 µs) : 0, 728 Remote Config [candidate] (704.966 µs) : 0, 705 Telemetry [baseline] (14.446 ms) : 0, 14446 Telemetry [candidate] (14.121 ms) : 0, 14121 section appsec BytebuddyAgent [baseline] (732.99 ms) : 0, 732990 BytebuddyAgent [candidate] (732.242 ms) : 0, 732242 GlobalTracer [baseline] (253.749 ms) : 0, 253749 GlobalTracer [candidate] (253.666 ms) : 0, 253666 AppSec [baseline] (171.0 ms) : 0, 171000 AppSec [candidate] (170.709 ms) : 0, 170709 IAST [baseline] (19.327 ms) : 0, 19327 IAST [candidate] (19.378 ms) : 0, 19378 Remote Config [baseline] (655.117 µs) : 0, 655 Remote Config [candidate] (668.218 µs) : 0, 668 Telemetry [baseline] (8.225 ms) : 0, 8225 Telemetry [candidate] (8.186 ms) : 0, 8186 section iast BytebuddyAgent [baseline] (832.96 ms) : 0, 832960 BytebuddyAgent [candidate] (850.869 ms) : 0, 850869 GlobalTracer [baseline] (246.837 ms) : 0, 246837 GlobalTracer [candidate] (250.022 ms) : 0, 250022 AppSec [baseline] (57.918 ms) : 0, 57918 AppSec [candidate] (58.382 ms) : 0, 58382 IAST [baseline] (21.51 ms) : 0, 21510 IAST [candidate] (22.072 ms) : 0, 22072 Remote Config [baseline] (660.729 µs) : 0, 661 Remote Config [candidate] (687.034 µs) : 0, 687 Telemetry [baseline] (8.791 ms) : 0, 8791 Telemetry [candidate] (8.984 ms) : 0, 8984 section profiling BytebuddyAgent [baseline] (702.006 ms) : 0, 702006 BytebuddyAgent [candidate] (705.836 ms) : 0, 705836 GlobalTracer [baseline] (348.413 ms) : 0, 348413 GlobalTracer [candidate] (349.688 ms) : 0, 349688 AppSec [baseline] (54.605 ms) : 0, 54605 AppSec [candidate] (54.421 ms) : 0, 54421 Remote Config [baseline] (655.283 µs) : 0, 655 Remote Config [candidate] (659.145 µs) : 0, 659 Telemetry [baseline] (8.736 ms) : 0, 8736 Telemetry [candidate] (8.782 ms) : 0, 8782 ProfilingAgent [baseline] (95.305 ms) : 0, 95305 ProfilingAgent [candidate] (95.759 ms) : 0, 95759 Profiling [baseline] (95.33 ms) : 0, 95330 Profiling [candidate] (95.783 ms) : 0, 95783 Startup time reports for insecure-bankgantt title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~1a5dccd365, baseline=1.46.0-SNAPSHOT~148aef92ab dateFormat X axisFormat %s section tracing Agent [baseline] (1.06 s) : 0, 1059949 Total [baseline] (8.708 s) : 0, 8708049 Agent [candidate] (1.06 s) : 0, 1059582 Total [candidate] (8.637 s) : 0, 8636637 section iast Agent [baseline] (1.181 s) : 0, 1180663 Total [baseline] (9.195 s) : 0, 9195030 Agent [candidate] (1.185 s) : 0, 1185256 Total [candidate] (9.223 s) : 0, 9222958 section iast_HARDCODED_SECRET_DISABLED Agent [baseline] (1.184 s) : 0, 1183836 Total [baseline] (9.154 s) : 0, 9153782 Agent [candidate] (1.184 s) : 0, 1183841 Total [candidate] (9.233 s) : 0, 9232864 section iast_TELEMETRY_OFF Agent [baseline] (1.186 s) : 0, 1185689 Total [baseline] (9.26 s) : 0, 9259743 Agent [candidate] (1.189 s) : 0, 1188524 Total [candidate] (9.231 s) : 0, 9231484
gantt title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~1a5dccd365, baseline=1.46.0-SNAPSHOT~148aef92ab dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (716.275 ms) : 0, 716275 BytebuddyAgent [candidate] (716.338 ms) : 0, 716338 GlobalTracer [baseline] (257.501 ms) : 0, 257501 GlobalTracer [candidate] (256.761 ms) : 0, 256761 AppSec [baseline] (55.764 ms) : 0, 55764 AppSec [candidate] (55.887 ms) : 0, 55887 Remote Config [baseline] (735.957 µs) : 0, 736 Remote Config [candidate] (711.395 µs) : 0, 711 Telemetry [baseline] (14.601 ms) : 0, 14601 Telemetry [candidate] (14.908 ms) : 0, 14908 section iast BytebuddyAgent [baseline] (830.89 ms) : 0, 830890 BytebuddyAgent [candidate] (833.401 ms) : 0, 833401 GlobalTracer [baseline] (246.294 ms) : 0, 246294 GlobalTracer [candidate] (247.934 ms) : 0, 247934 AppSec [baseline] (57.608 ms) : 0, 57608 AppSec [candidate] (57.991 ms) : 0, 57991 IAST [baseline] (21.398 ms) : 0, 21398 IAST [candidate] (21.407 ms) : 0, 21407 Remote Config [baseline] (658.682 µs) : 0, 659 Remote Config [candidate] (666.867 µs) : 0, 667 Telemetry [baseline] (8.823 ms) : 0, 8823 Telemetry [candidate] (8.727 ms) : 0, 8727 section iast_HARDCODED_SECRET_DISABLED BytebuddyAgent [baseline] (832.386 ms) : 0, 832386 BytebuddyAgent [candidate] (833.067 ms) : 0, 833067 GlobalTracer [baseline] (247.47 ms) : 0, 247470 GlobalTracer [candidate] (247.277 ms) : 0, 247277 AppSec [baseline] (57.965 ms) : 0, 57965 AppSec [candidate] (57.915 ms) : 0, 57915 IAST [baseline] (21.428 ms) : 0, 21428 IAST [candidate] (21.254 ms) : 0, 21254 Remote Config [baseline] (671.461 µs) : 0, 671 Remote Config [candidate] (655.61 µs) : 0, 656 Telemetry [baseline] (8.882 ms) : 0, 8882 Telemetry [candidate] (8.66 ms) : 0, 8660 section iast_TELEMETRY_OFF BytebuddyAgent [baseline] (833.761 ms) : 0, 833761 BytebuddyAgent [candidate] (835.949 ms) : 0, 835949 GlobalTracer [baseline] (248.061 ms) : 0, 248061 GlobalTracer [candidate] (248.75 ms) : 0, 248750 AppSec [baseline] (58.252 ms) : 0, 58252 AppSec [candidate] (58.023 ms) : 0, 58023 IAST [baseline] (21.106 ms) : 0, 21106 IAST [candidate] (21.273 ms) : 0, 21273 Remote Config [baseline] (671.558 µs) : 0, 672 Remote Config [candidate] (671.963 µs) : 0, 672 Telemetry [baseline] (8.699 ms) : 0, 8699 Telemetry [candidate] (8.733 ms) : 0, 8733 LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics. Request duration reports for petclinicgantt title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~1a5dccd365, baseline=1.46.0-SNAPSHOT~148aef92ab dateFormat X axisFormat %s section baseline no_agent (1.351 ms) : 1330, 1371 . : milestone, 1351, appsec (1.753 ms) : 1730, 1776 . : milestone, 1753, appsec_no_iast (1.74 ms) : 1717, 1763 . : milestone, 1740, iast (1.484 ms) : 1460, 1509 . : milestone, 1484, profiling (1.533 ms) : 1508, 1557 . : milestone, 1533, tracing (1.489 ms) : 1465, 1514 . : milestone, 1489, section candidate no_agent (1.338 ms) : 1318, 1357 . : milestone, 1338, appsec (1.754 ms) : 1730, 1778 . : milestone, 1754, appsec_no_iast (1.766 ms) : 1741, 1790 . : milestone, 1766, iast (1.509 ms) : 1484, 1534 . : milestone, 1509, profiling (1.517 ms) : 1491, 1542 . : milestone, 1517, tracing (1.472 ms) : 1446, 1497 . : milestone, 1472,
Request duration reports for insecure-bankgantt title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~1a5dccd365, baseline=1.46.0-SNAPSHOT~148aef92ab dateFormat X axisFormat %s section baseline no_agent (374.258 µs) : 355, 394 . : milestone, 374, iast (503.778 µs) : 482, 526 . : milestone, 504, iast_FULL (736.857 µs) : 715, 759 . : milestone, 737, iast_GLOBAL (545.882 µs) : 524, 568 . : milestone, 546, iast_HARDCODED_SECRET_DISABLED (504.193 µs) : 482, 526 . : milestone, 504, iast_INACTIVE (456.571 µs) : 436, 478 . : milestone, 457, iast_TELEMETRY_OFF (495.457 µs) : 473, 518 . : milestone, 495, tracing (448.249 µs) : 427, 469 . : milestone, 448, section candidate no_agent (381.385 µs) : 361, 402 . : milestone, 381, iast (512.239 µs) : 490, 534 . : milestone, 512, iast_FULL (738.949 µs) : 717, 761 . : milestone, 739, iast_GLOBAL (560.401 µs) : 539, 582 . : milestone, 560, iast_HARDCODED_SECRET_DISABLED (501.287 µs) : 480, 523 . : milestone, 501, iast_INACTIVE (450.507 µs) : 429, 472 . : milestone, 451, iast_TELEMETRY_OFF (491.528 µs) : 469, 514 . : milestone, 492, tracing (446.752 µs) : 426, 467 . : milestone, 447,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~1a5dccd365, baseline=1.46.0-SNAPSHOT~148aef92ab dateFormat X axisFormat %s section baseline no_agent (1.477 ms) : 1465, 1488 . : milestone, 1477, appsec (2.372 ms) : 2329, 2416 . : milestone, 2372, iast (2.108 ms) : 2054, 2163 . : milestone, 2108, iast_GLOBAL (2.161 ms) : 2106, 2215 . : milestone, 2161, profiling (2.445 ms) : 2208, 2682 . : milestone, 2445, tracing (1.964 ms) : 1922, 2006 . : milestone, 1964, section candidate no_agent (1.476 ms) : 1465, 1488 . : milestone, 1476, appsec (2.354 ms) : 2312, 2397 . : milestone, 2354, iast (2.109 ms) : 2055, 2163 . : milestone, 2109, iast_GLOBAL (2.151 ms) : 2096, 2205 . : milestone, 2151, profiling (1.995 ms) : 1951, 2039 . : milestone, 1995, tracing (1.953 ms) : 1911, 1995 . : milestone, 1953,
Execution time for biojavagantt title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~1a5dccd365, baseline=1.46.0-SNAPSHOT~148aef92ab dateFormat X axisFormat %s section baseline no_agent (14.718 s) : 14718000, 14718000 . : milestone, 14718000, appsec (15.195 s) : 15195000, 15195000 . : milestone, 15195000, iast (18.797 s) : 18797000, 18797000 . : milestone, 18797000, iast_GLOBAL (17.861 s) : 17861000, 17861000 . : milestone, 17861000, profiling (14.965 s) : 14965000, 14965000 . : milestone, 14965000, tracing (15.011 s) : 15011000, 15011000 . : milestone, 15011000, section candidate no_agent (14.941 s) : 14941000, 14941000 . : milestone, 14941000, appsec (15.026 s) : 15026000, 15026000 . : milestone, 15026000, iast (19.101 s) : 19101000, 19101000 . : milestone, 19101000, iast_GLOBAL (17.76 s) : 17760000, 17760000 . : milestone, 17760000, profiling (15.762 s) : 15762000, 15762000 . : milestone, 15762000, tracing (15.054 s) : 15054000, 15054000 . : milestone, 15054000,
|
amarziali force-pushed the andrea.marziali/vertx5 branch from 1cd0dce to 1a5dccd Compare 
manuel-alvarez-alvarez approved these changes Jan 16, 2025
Member
manuel-alvarez-alvarez left a comment
manuel-alvarez-alvarez left a comment There was a problem hiding this comment.
I've created a JIRA ticket APPSEC-56368 to review support for vert.x 5 in ASM, thanks for spotting the missing pieces 😄
amarziali added comp: api 
svc-squareup-copybara pushed a commit to cashapp/misk that referenced this pull request Jan 31, 2025
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.25.4` -> `2.26.0` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.45.2` -> `1.46.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.45.2` -> `1.46.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | --- ### Release Notes <details> <summary>googleapis/java-datastore (com.google.cloud:google-cloud-datastore)</summary> ### [`v2.26.0`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2260-2025-01-29) ##### Features - Add firestoreInDatastoreMode for datastore emulator ([#​1698](googleapis/java-datastore#1698)) ([50f106d](googleapis/java-datastore@50f106d)) ##### Dependencies - Update dependency com.google.cloud:sdk-platform-java-config to v3.42.0 ([#​1725](googleapis/java-datastore#1725)) ([1cbaf22](googleapis/java-datastore@1cbaf22)) </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.46.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.46.0): 1.46.0 ##### Breaking Changes > \[!WARNING] > jnr-unixsocket is now an external dependency of dd-trace-ot and must be included when deploying dd-trace-ot. > \[!NOTE] > The API `TracerScope.setAsync(boolean)`, used to manually control asynchronous span propagation, does no more apply to the scope instance but to the active span scope. ##### Components ##### Application Security Management (IAST) - 🐛 Fix String.replace instrumentation for IAST ([#​8281](DataDog/dd-trace-java#8281) - [@​Mariovido](https://github.com/Mariovido)) - ✨ Apply the standard nomenclature to the stacktrace configs ([#​8244](DataDog/dd-trace-java#8244) - [@​jandro996](https://github.com/jandro996)) - 🐛 Exclude false positive weak randomness ([#​8232](DataDog/dd-trace-java#8232) - [@​jandro996](https://github.com/jandro996)) - ✨ Propagation of translateEscapes of String class ([#​8186](DataDog/dd-trace-java#8186) - [@​sezen-datadog](https://github.com/sezen-datadog)) - ✨ Add security control metrics ([#​8175](DataDog/dd-trace-java#8175) - [@​jandro996](https://github.com/jandro996)) - ✨ Increase IAST propagation to StringBuffer setLength ([#​8128](DataDog/dd-trace-java#8128) - [@​Mariovido](https://github.com/Mariovido)) - ✨ Add IAST taint tracking for DB values ([#​8072](DataDog/dd-trace-java#8072) - [@​Mariovido](https://github.com/Mariovido)) ##### Application Security Management (WAF) - 🐛 Prevents a NPE when there is no subscriber for user events ([#​8258](DataDog/dd-trace-java#8258) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Apply the standard nomenclature to the stacktrace configs ([#​8244](DataDog/dd-trace-java#8244) - [@​jandro996](https://github.com/jandro996)) - 🐛 Ensure cached subscriptions are cleared on reconfiguration via RC ([#​8229](DataDog/dd-trace-java#8229) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Add support for session tracking in Vertx ([#​8167](DataDog/dd-trace-java#8167) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Create span tag: \_dd.appsec.rasp.timeout ([#​8269](DataDog/dd-trace-java#8269) - [@​Mariovido](https://github.com/Mariovido)) ##### Build & Tooling - 🐛 Ensure shaded helpers have unique names when injected into class-loaders ([#​8192](DataDog/dd-trace-java#8192) - [@​mcculls](https://github.com/mcculls)) ##### Configuration at Runtime - 🐛 Remove filtering of `DD_SERVICE` and `DD_ENV` from the tracer ([#​8176](DataDog/dd-trace-java#8176) - [@​mhlidd](https://github.com/mhlidd)) ##### Continuous Integration Visibility - 🧹 Generalize TestRetryPolicy to TestExecutionPolicy ([#​8302](DataDog/dd-trace-java#8302) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Parallelize CI Visibility settings requests ([#​8299](DataDog/dd-trace-java#8299) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Generalize test retry logic ([#​8289](DataDog/dd-trace-java#8289) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Generalize tests skipping logic ([#​8288](DataDog/dd-trace-java#8288) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Remove skip and shouldBeSkipped methods from TestEventsHandler in favor of isSkippable ([#​8286](DataDog/dd-trace-java#8286) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨⚡ Optimize Git repository information computation ([#​8270](DataDog/dd-trace-java#8270) - [@​dougqh](https://github.com/dougqh)) - ✨ Always request known tests from the backend ([#​8268](DataDog/dd-trace-java#8268) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Fix NPE when trying to get retry analyzer in Test NG ([#​8253](DataDog/dd-trace-java#8253) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Set test framework and test framework version tags atomically ([#​8252](DataDog/dd-trace-java#8252) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add debug logging to Android Gradle module layout logic ([#​8251](DataDog/dd-trace-java#8251) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix source and destination folders computation for Android Gradle projects ([#​8190](DataDog/dd-trace-java#8190) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add basic Scala Weaver sbt support ([#​8189](DataDog/dd-trace-java#8189) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement impacted tests detection ([#​8188](DataDog/dd-trace-java#8188) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ##### Data Streams Monitoring - ✨ Change hash computation for protobuf to better represent impacting changes + save proto number in schema ([#​8201](DataDog/dd-trace-java#8201) - [@​vandonr](https://github.com/vandonr)) ##### Database Monitoring - Add peer service tag in dbm sql commenter ([#​7913](DataDog/dd-trace-java#7913) - [@​jordan-wong](https://github.com/jordan-wong)) ##### Dynamic Instrumentation - ✨ Add support for SymDB to scan directories ([#​8306](DataDog/dd-trace-java#8306) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Add SymDB report for any jar scanning failures ([#​8300](DataDog/dd-trace-java#8300) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Use two budgets depending on type ([#​8283](DataDog/dd-trace-java#8283) - [@​evanchooly](https://github.com/evanchooly)) - ✨ Institute a 10 snapshot per probe per trace budget ([#​8277](DataDog/dd-trace-java#8277) - [@​evanchooly](https://github.com/evanchooly)) - 🐛 Avoid double snapshots for Exception Replay ([#​8273](DataDog/dd-trace-java#8273) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Simplify code origins. Separate out snapshot generation. ([#​8263](DataDog/dd-trace-java#8263) - [@​evanchooly](https://github.com/evanchooly)) - ✨ Add Exception probe custom instrumentation ([#​8230](DataDog/dd-trace-java#8230) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Enhance log probes to honor debug session tags ([#​8215](DataDog/dd-trace-java#8215) - [@​evanchooly](https://github.com/evanchooly)) - 🐛 Don't redact env tokens from debugger probe snapshots ([#​8211](DataDog/dd-trace-java#8211) - [@​watson](https://github.com/watson)) - ✨⚡ Move Trace/SpanId capture at commit time ([#​8184](DataDog/dd-trace-java#8184) - [@​jpbempel](https://github.com/jpbempel)) - 🐛 Capture values at entry for method probe ([#​8169](DataDog/dd-trace-java#8169) - [@​jpbempel](https://github.com/jpbempel)) ##### JMX fetch - 🐛 Mute JMXFetch Shutdown in progress error ([#​8068](DataDog/dd-trace-java#8068) - [@​ygree](https://github.com/ygree)) ##### OpenTracing -⚠️ 🧹 Make jnr-unixsocket an explicit dependency of dd-trace-ot ([#​8307](DataDog/dd-trace-java#8307) - [@​mcculls](https://github.com/mcculls)) ##### Profiling - 🐛 Avoid unsupported API call for creating folders on windows ([#​8304](DataDog/dd-trace-java#8304) - [@​jbachorik](https://github.com/jbachorik)) - ✨ Tag profiles for serverless ([#​8279](DataDog/dd-trace-java#8279) - [@​jbachorik](https://github.com/jbachorik)) - ✨ add queue type and length to queue events ([#​8242](DataDog/dd-trace-java#8242) - [@​richardstartin](https://github.com/richardstartin)) - 🐛 TempLocationManager Fixes and Improvements ([#​8191](DataDog/dd-trace-java#8191) - [@​jbachorik](https://github.com/jbachorik)) - ✨ Bump ddprof to 1.18.0 ([#​8173](DataDog/dd-trace-java#8173) - [@​jbachorik](https://github.com/jbachorik)) - ✨ Report profiler initialization and configuration errors to telemetry ([#​8171](DataDog/dd-trace-java#8171) - [@​jbachorik](https://github.com/jbachorik)) ##### Telemetry - ✨ Add pending traces report in tracer flares ([#​8053](DataDog/dd-trace-java#8053) - [@​mhlidd](https://github.com/mhlidd)) ##### Testing - ✨ Test http server requests in parallel ([#​8222](DataDog/dd-trace-java#8222) - [@​amarziali](https://github.com/amarziali)) ##### Trace context propagation - ✨ Add non default propagator registration ([#​8310](DataDog/dd-trace-java#8310) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) ##### Tracer core - ✨ Probe for existence of IBMSASL or ACCP security providers ([#​8276](DataDog/dd-trace-java#8276) - [@​mcculls](https://github.com/mcculls)) - ✨⚡ Overhead improvement to agent feedback based sampling ([#​8265](DataDog/dd-trace-java#8265) - [@​dougqh](https://github.com/dougqh)) - 🧹 Move async propagation API from scope to tracer ([#​8231](DataDog/dd-trace-java#8231) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Introduce context propagation API ([#​8161](DataDog/dd-trace-java#8161) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) - ✨🧪 Use env-entry to add tags per webapp deployment ([#​8138](DataDog/dd-trace-java#8138) - [@​amarziali](https://github.com/amarziali)) - ✨ Introduce context helpers API ([#​8134](DataDog/dd-trace-java#8134) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Support IPv6 values for `DD_AGENT_HOST` and `DD_TRACE_AGENT_URL` ([#​7984](DataDog/dd-trace-java#7984) - [@​mhlidd](https://github.com/mhlidd)) ##### Instrumentations ##### Apache HttpComponents - 🐛 Properly finish spans and support latest apache httpclient5 ([#​8272](DataDog/dd-trace-java#8272) - [@​amarziali](https://github.com/amarziali)) ##### AWS Lambda instrumentation - 🐛 Properly capture lambda payloads for all handler types. ([#​8264](DataDog/dd-trace-java#8264) - [@​purple4reina](https://github.com/purple4reina)) ##### AWS S3 instrumentation - 💡 Create S3 instrumentation + add span pointers ([#​8075](DataDog/dd-trace-java#8075) - [@​nhulston](https://github.com/nhulston)) ##### AWS SDK instrumentation - 🐛 Revert "Add avoid double instrumenting lambda non-streaming handlers." ([#​8247](DataDog/dd-trace-java#8247) - [@​nhulston](https://github.com/nhulston)) ##### Cassandra - ✨ Allow extracting keyspace from statement result ([#​8239](DataDog/dd-trace-java#8239) - [@​amarziali](https://github.com/amarziali)) ##### Core Java language instrumentation - ✨ Propagation of translateEscapes of String class ([#​8186](DataDog/dd-trace-java#8186) - [@​sezen-datadog](https://github.com/sezen-datadog)) ##### Eclipse Vert.x instrumentation - 🐛 Fix vertx worker propagation and error handling ([#​8237](DataDog/dd-trace-java#8237) - [@​amarziali](https://github.com/amarziali)) - ✨ Support vertx 5 ([#​8220](DataDog/dd-trace-java#8220) - [@​amarziali](https://github.com/amarziali)) - ✨ Add support for session tracking in Vertx ([#​8167](DataDog/dd-trace-java#8167) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) ##### Kafka instrumentation - 🐛 Prevent possible NPE calculating Kafka record header size ([#​8292](DataDog/dd-trace-java#8292) - [@​ygree](https://github.com/ygree)) ##### Mule instrumentation - 🐛 Fix crash using Mule with JPMS ([#​8187](DataDog/dd-trace-java#8187) - [@​amarziali](https://github.com/amarziali)) ##### Protocol Buffer instrumentation - ✨ Change hash computation for protobuf to better represent impacting changes + save proto number in schema ([#​8201](DataDog/dd-trace-java#8201) - [@​vandonr](https://github.com/vandonr)) ##### Spring instrumentation - 🐛 Preserve getQualifier from spring scheduling runnables ([#​8293](DataDog/dd-trace-java#8293) - [@​amarziali](https://github.com/amarziali)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: bb09d47e4eed77a003f630273b4d0a84003eb899
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What Does This Do
Support vertx 5.0 and extend testing. Testing was also not working with JVM >= 17. In particular having
maxJavaVersionForTests = 15was also limiting the java version of latestDep even if it was forced to > 17.This has been fixed on the java_no-deps gradle build file.
Some latestDepTest for vertx 5 have some asm tests disabled (with FIXME comments). To be tracked
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]