Skip to content

Conversation

@c-wygoda
Copy link
Contributor

@c-wygoda c-wygoda commented Oct 1, 2025

What does this PR do?

ddtrace-py 3.15 replaced ddtrace.debugging._uploader.LogsIntakeUploaderV1 with ddtrace.debugging._uploader.SignalsUploader so this project needs a little logic to import the right class.

Motivation

After dependabot having updated ddtrace, datadog_lambda failed in our application.

Testing Guidelines

Would love to have your help on testing this tbh.

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
@c-wygoda c-wygoda requested review from a team as code owners October 1, 2025 14:42
Copy link
Contributor

@purple4reina purple4reina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission. I'll additionally add some testing (in a different PR) so that we don't hit issues like this again in the future.

@purple4reina purple4reina merged commit b6131e5 into DataDog:main Oct 1, 2025
26 checks passed
purple4reina added a commit to DataDog/dd-trace-py that referenced this pull request Oct 6, 2025
…python still valid (#14746) ## Description <!-- Provide an overview of the change and motivation for the change --> Customer reported that a class name changed in the most recent version of ddtrace which was then causing errors when attempting to import `datadog_lambda`. See DataDog/datadog-lambda-python#661 and #14653. ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> It's just some tests, so risk is low. ## Additional Notes <!-- Any other information that would be helpful for reviewers --> Added additional tests on the `datadog_lambda` side as well, including running our unit tests twice a day. See DataDog/datadog-lambda-python#662.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants