feat(appsec): enable api security #636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
florentinl force-pushed the florentinl/APPSEC-58369/report-route-on-inferred-span branch 3 times, most recently from abcfe53 to 0f15cf0 Compare 2 tasks
christophe-papazian approved these changes Jul 24, 2025
florentinl added a commit to DataDog/dd-trace-py that referenced this pull request Jul 24, 2025
## Description Add a handler for lambda to send a response body to parse. Additionally fix one typo ## Additional Notes This is enabled in datadog_lambda by this PR: DataDog/datadog-lambda-python#636 ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
florentinl force-pushed the florentinl/APPSEC-58369/report-route-on-inferred-span branch 2 times, most recently from baadddd to 2868513 Compare alyshawang pushed a commit to DataDog/dd-trace-py that referenced this pull request Jul 25, 2025
## Description Add a handler for lambda to send a response body to parse. Additionally fix one typo ## Additional Notes This is enabled in datadog_lambda by this PR: DataDog/datadog-lambda-python#636 ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
florentinl force-pushed the florentinl/APPSEC-58369/report-route-on-inferred-span branch from 2868513 to b59105d Compare 
joeyzhao2018 approved these changes Jul 28, 2025
florentinl deleted the florentinl/APPSEC-58369/report-route-on-inferred-span branch Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the necessary functionalities to implement API Security:
http.routetag on the entry span:Motivation
The objective of this PR is to enable API Security inside the tracer for python in lambda.
Testing Guidelines
Updated the test cases for the
asm_start_responsefunction to ensure that the body is sent to Appsec.Updated the snapshot tests to ensure that
http.routeis present on required spans.Additional Notes
This PR depends on DataDog/dd-trace-py#14118.
Types of Changes
Check all that apply