Skip to content

Conversation

@nhulston
Copy link
Contributor

What does this PR do?

Users could be storing their secret in SecretsManager in a different region than the currently running Lambda. This parses the arn for the correct region.

Before this change, users would get error: Secrets Manager can't find the specified secret.

Motivation

Backports DataDog/datadog-lambda-extension#604

Testing Guidelines

Unit tests

  • Tested manually with secret in same region, and it works
  • Tested manually with secret in different region, and it works

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
@nhulston nhulston force-pushed the nicholas.hulston/use-correct-secrets-manager-region branch 4 times, most recently from 2ca583a to dc3306e Compare March 13, 2025 21:37
@nhulston nhulston marked this pull request as ready for review March 13, 2025 21:44
@nhulston nhulston requested a review from a team as a code owner March 13, 2025 21:44
@nhulston nhulston force-pushed the nicholas.hulston/use-correct-secrets-manager-region branch from 7447411 to 1fec486 Compare March 13, 2025 21:45
@nhulston nhulston merged commit 7d7c153 into main Mar 14, 2025
60 checks passed
@nhulston nhulston deleted the nicholas.hulston/use-correct-secrets-manager-region branch March 14, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants