Skip to content

chore: remove the hardcoded 2.21.3 version in dockerfile #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2025
Merged

chore: remove the hardcoded 2.21.3 version in dockerfile #568

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64bd960
remove the hardcoded 2.21.3 version in dockerfile
joeyzhao2018 Mar 4, 2025
55b7995
Apply suggestions from code review
mabdinur Mar 4, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ ENV PATH=/root/.cargo/bin:$PATH

# Install datadog_lambda and dependencies from local
COPY . .
RUN pip install . ddtrace==2.21.3 -t ./python/lib/$runtime/site-packages
RUN pip install --no-cache-dir . -t ./python/lib/$runtime/site-packages
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this safe to do? What's the implication of this? Do you remember why we were pinning before?

There was a pretty good reason about this from the past
Copy link
Contributor Author

@joeyzhao2018 joeyzhao2018 Mar 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for ddtrace==2.21.3 it's in the description.
For --no-cache-dir... i actually wonder how it was added ... my local change didn't have it just realized that @mabdinur merged the bot suggestion :P
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that's the reason, you were pinning in the past you wanted to make sure the fix was included for dynamodb, sg

# Remove botocore (40MB) to reduce package size. aws-xray-sdk
# installs it, while it's already provided by the Lambda Runtime.
Expand Down
Loading