Skip to content

Conversation

@apiarian-datadog
Copy link
Contributor

@apiarian-datadog apiarian-datadog commented Nov 4, 2024

What does this PR do?

Respect the DD_BOTOCORE_ADD_SPAN_POINTERS environment variable that is also used by dd-trace-py to opt out of automatic botocore span pointers.

Testing Guidelines

Unit tests. Also confirmed that this works as expected in a live test lambda setup.

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
@apiarian-datadog apiarian-datadog requested a review from a team as a code owner November 4, 2024 19:14
@apiarian-datadog apiarian-datadog marked this pull request as draft November 4, 2024 19:14
@apiarian-datadog apiarian-datadog marked this pull request as ready for review November 4, 2024 19:24
@apiarian-datadog apiarian-datadog merged commit ea0a09e into main Nov 4, 2024
51 checks passed
@apiarian-datadog apiarian-datadog deleted the aleksandr.pasechnik/add-span-pointers-environment-variable branch November 4, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants