Skip to content

feat: Fix regex for ddtrace version #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2023
Merged

feat: Fix regex for ddtrace version #389

merged 1 commit into from
Nov 7, 2023

Conversation

@astuyve
Copy link
Contributor

@astuyve astuyve commented Nov 7, 2023 •
edited
Loading

What does this PR do?

It turns out we may have more than 10 patch releases for a given minor.

Motivation

Tests pass now:
image

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
@astuyve astuyve requested a review from a team as a code owner November 7, 2023 12:41
@astuyve astuyve merged commit a45283c into main Nov 7, 2023
@astuyve astuyve deleted the aj/fix-ddtrace-regex branch November 7, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@astuyve @Julio-Guerra