feat: Pin dd trace below 2 #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| datadog = ">=0.41.0,<1.0.0" | ||
| wrapt = "^1.11.2" | ||
| ddtrace = "1.15.2" | ||
| ddtrace = "<2.0.0" |
There was a problem hiding this comment.
There's also a reference to 1.15.2 in the poetry.lock file.
There was a problem hiding this comment.
It seems you'll just need to run poetry install, see https://python-poetry.org/docs/basic-usage/#installing-with-poetrylock.
There was a problem hiding this comment.
Yup, added that already
purple4reina approved these changes Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Specifies dependency on ddtrace < 2.0.0
Motivation
Users not utilizing our layer may bring their own version of ddtrace, which may be greater than our latest release.
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply