Skip to content

Conversation

@jcstorms1
Copy link
Contributor

What does this PR do?

This sets up pre-commit for use with this repo.

  • Implements pre-commit hooks for black and merge-conflicts
  • Adds a custom hook for checking AWS and Datadog secret keys

Motivation

Security

Testing Guidelines

Tried to commit with secret keys present in the repo.

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
@jcstorms1 jcstorms1 requested a review from a team as a code owner July 1, 2021 13:32
@jcstorms1 jcstorms1 merged commit 986ec7a into main Jul 1, 2021
@jcstorms1 jcstorms1 deleted the storms/add-pre-commit-hooks branch July 1, 2021 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants