Skip to content

Ensure http.status_code is always a string #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Ensure http.status_code is always a string #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion datadog_lambda/trigger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,4 +214,4 @@ def extract_http_status_code_tag(trigger_tags, response):
elif hasattr(response, "status_code"):
status_code = response.status_code

return status_code
return str(status_code)
4 changes: 2 additions & 2 deletions tests/test_trigger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,11 +342,11 @@ def test_extract_http_status_code_tag_from_response_dict(self):
trigger_tags = {"function_trigger.event_source": "api-gateway"}
response = {"statusCode": 403}
status_code = extract_http_status_code_tag(trigger_tags, response)
self.assertEqual(status_code, 403)
self.assertEqual(status_code, "403")

def test_extract_http_status_code_tag_from_response_object(self):
trigger_tags = {"function_trigger.event_source": "api-gateway"}
response = MagicMock(spec=["status_code"])
response.status_code = 403
status_code = extract_http_status_code_tag(trigger_tags, response)
self.assertEqual(status_code, 403)
self.assertEqual(status_code, "403")