Skip to content

Type check Lambda events when extracting trigger tags #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Type check Lambda events when extracting trigger tags #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions datadog_lambda/trigger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ def parse_event_source(event):
api-gateway | application-load-balancer | cloudwatch-logs |
cloudwatch-events | cloudfront | dynamodb | kinesis | s3 | sns | sqs
"""
if type(event) is not dict:
return
event_source = event.get("eventSource") or event.get("EventSource")

request_context = event.get("requestContext")
Expand Down
6 changes: 6 additions & 0 deletions tests/test_trigger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,12 @@ def test_extract_trigger_tags_unsupported(self):
tags = extract_trigger_tags(event, ctx)
self.assertEqual(tags, {})

def test_extract_trigger_tags_list_type_event(self):
event = []
ctx = get_mock_context()
tags = extract_trigger_tags(event, ctx)
self.assertEqual(tags, {})


class ExtractHTTPStatusCodeTag(unittest.TestCase):
def test_extract_http_status_code_tag_from_response_dict(self):
Expand Down