Remove clang-format check via GitHub Action #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
IshaanDesai changed the title …t hooks in the pre-commit config
siggmo approved these changes Oct 17, 2024
Contributor
siggmo left a comment
siggmo left a comment There was a problem hiding this comment.
I agree that we should remove this duplication. I'm fine with merging, though maybe we could consider whitelisting relevant extensions instead of excluding some (see my comment). But I guess both is fine.
sanathkeshav added a commit that referenced this pull request Oct 30, 2024
* Mention dependency on compiler support for OpenMP in README * Rename container user also in fans_dev image to fix broken entrypoint script (#27) * Add python3-dev to fans-ci stage already * Remove clang-format check via GitHub Action (#29) * Bump clang-format version * Formatting * Use a different Action workflow to run clang-format * Remove the Action to run clang-format, as it will go out of sync with the pre-commit run * Bump mirror-clang-format to latest version in the pre-commit-config * Update clang-format config file to also format JSON * Manually specify which extensions to format in the mirror-clang-format hooks in the pre-commit config * Exclude JSON files from clang-format * Exclude JSON files from clang-format * Correctly exclude JSON files from clang-format checking * Rather than excluding json, specifically suggest c++ * Added API to get homogenized stress and homogenized tangent (#31) * worked on getting the algorithmic tangent via finite differences * linear elastic triclinic material model * refactored material properties from type map<string, vector<double>> to type json * J2Plasticity time_step is double not a vector * refactored compute_error to accept different error measure and type * added additional error control when get_homogenized_tangent is called * in get_homogenized_tangent linear materials are handled seperately * added linear thermal triclinic model (#32) * added linear thermal triclinic model similar to linear elastic triclinic model * fixed readme.md indent causing linting error * Update CHANGELOG * Bump version --------- Co-authored-by: Moritz Sigg <st160944@stud.uni-stuttgart.de> Co-authored-by: Moritz Sigg <50019904+siggmo@users.noreply.github.com> Co-authored-by: Ishaan Desai <ishaandesai@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR removes the Action which runs clang-format. clang-format is configured to run via pre-commit, which is run via the Action workflow run-checks. Having two ways to run clang-format risks making them asynchronous, something that already happened. As pre-commit is more useful, the clang-format check via the Action is removed.
clang-format used via pre-commit is updated to the latest version, and necessary additions to the configuration are done.