Skip to content

Fixed Context struct to have usize instead of i32 #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wdoppenberg wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixed Context struct to have usize instead of i32 #20

wdoppenberg wants to merge 3 commits into from

Conversation

@wdoppenberg
Copy link

@wdoppenberg wdoppenberg commented Aug 23, 2023 •
edited
Loading

I kept getting an error as follows:

error[E0308]: mismatched types --> src/snowball/algorithms/armenian.rs:352:26 | 352 | env.limit_backward = context.i_pV; | ------------------ ^^^^^^^^^^^^ expected `usize`, found `i32` | | | expected due to the type of this binding For more information about this error, try `rustc --explain E0308`.

This was easily fixed by changing the Context struct's fields to be usize.

  • ran cargo test

Furthermore, I added a basic GH Actions workflow to run cargo test.
@patrik-simunic-cz patrik-simunic-cz mentioned this pull request Apr 27, 2024
Open
Ngalstyan4 added a commit to Ngalstyan4/rust-stemmers that referenced this pull request Sep 13, 2024
@Ngalstyan4
Patch campilation error by making context members usize
72ed4b5 
It seems at some point snowball_env.rs has been updated in the rust snowball backend but the change is not reflected in rust-stemmers project. The right fix probably is to fix snowball_env.rs and regenerate all rust code for language-specific stemmers. But this small change at least makes the main branch compile out of the box again. See CurrySoftware#20 for an additional github action suggestion that runs tests on PRs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@wdoppenberg