[microsoft#1683] Fix is_skill_claim validation for anonymous authentication (microsoft#1684)

* Fix validation order for anonymous skill claims. * Fix test

Author: ceciliaavila

libraries/botframework-connector/botframework/connector/auth/skill_validation.py

@@ -65,15 +65,15 @@ def is_skill_claim(claims: Dict[str, object]) -> bool:
  :param claims: A dict of claims.
  :return bool:
  """
- if AuthenticationConstants.VERSION_CLAIM not in claims:
- return False
-
  if (
  claims.get(AuthenticationConstants.APP_ID_CLAIM, None)
  == AuthenticationConstants.ANONYMOUS_SKILL_APP_ID
  ):
  return True
 
+ if AuthenticationConstants.VERSION_CLAIM not in claims:
+ return False
+
  audience = claims.get(AuthenticationConstants.AUDIENCE_CLAIM)
 
  # The audience is https://api.botframework.com and not an appId.

libraries/botframework-connector/tests/test_auth.py

@@ -59,7 +59,7 @@ class TestAuth:
 
  @pytest.mark.asyncio
  async def test_claims_validation(self):
- claims: List[Dict] = []
+ claims: List[Dict] = {}
  default_auth_config = AuthenticationConfiguration()
 
  # No validator should pass.