This repository was archived by the owner on Sep 27, 2023. It is now read-only.
Pass correct variable #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
BrockReece reviewed Apr 19, 2018
src/Dropzone.vue Outdated
| this.$emit('file-upload-error', { | ||
| file: file, | ||
| response: response, | ||
| errorMessage: errorMessage, |
Contributor
There was a problem hiding this comment.
We have changed key names here, is this going to introduce any breaking changes for code expecting the old response key?
Contributor Author
There was a problem hiding this comment.
Thats a good point @BrockReece, i guess it makes sense to keep the key name the same. Thanks
BrockReece approved these changes Apr 20, 2018
Contributor
| Released in v1.0.2 |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fixes #2, emits the correct errorMessage variable