Skip to content

Update for Xcode 11 beta 3 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2019
Merged

Update for Xcode 11 beta 3 #8

merged 1 commit into from
Jul 3, 2019

Conversation

broadwaylamb
Copy link
Contributor

@broadwaylamb broadwaylamb commented Jul 3, 2019 •
edited
Loading

In the new beta:

  • AnyCanellable.store(in:) method has been added
  • eraseToAnySubject() has been removed
  • Publishers.Just has become just Just :)
freak4pc
freak4pc requested changes Jul 3, 2019
View reviewed changes
Copy link
Member

@freak4pc freak4pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! one nit
Data/core_components.csv Outdated
ConnectableObservableType,ConnectablePublisher,
Disposable,Cancellable,
DisposeBag,❌,
DisposeBag,A collection of AnyCancellables,"Call anyCancellable.store(in: disposeBag), where disposeBag can be an array, a set, or any other RangeReplaceableCollection"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be

Suggested change
DisposeBag,A collection of AnyCancellables,"Call anyCancellable.store(in: disposeBag), where disposeBag can be an array, a set, or any other RangeReplaceableCollection"
DisposeBag,A collection of AnyCancellables,"Call anyCancellable.store(in: collection), where disposeBag can be an array, a set, or any other RangeReplaceableCollection"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
freak4pc
freak4pc approved these changes Jul 3, 2019
View reviewed changes
Copy link
Member

@freak4pc freak4pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@freak4pc freak4pc merged commit be35307 into CombineCommunity:master Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@broadwaylamb @freak4pc