Skip to content
This repository was archived by the owner on Jan 13, 2023. It is now read-only.

Minor bugfixes #76

Merged
merged 10 commits into from
May 14, 2019
Merged

Minor bugfixes #76

merged 10 commits into from
May 14, 2019

Conversation

@lrog
Copy link
Contributor

@lrog lrog commented Mar 21, 2019 •
edited
Loading

Changes:

  • Fixed a bug with job repository authentication when using MS SQL server. This problem strangely has not been caught during unit nor integration tests and so this test case needs be added (thanks @qwerty155).
  • Updated the Docker image with installed packages (the java11 base image has been updated and the previous dependencies were no longer available in PPA).
  • Minor updates in examples (not to use the dev version of the pipeline image).
  • Added tests for running pipeline ingesting from SQL Server.
  • Minor fix when using ElasticSearch X-Pack / Open Distro with security enabled, but without SSL -- requires only username and password.
  • Added a custom ImageMagic configuration file, which extends the available resources for ImageMagic when performing documents conversion (thanks @qwerty155 ). When converting very large documents, only few first pages could have been saved due to lack of free disk space allocated for IM. The configuration sets the available space to 8GB.

TODO:

  • add unit tests
  • update changelog
  • bump the version to 1.3.1
lrog and others added 8 commits March 12, 2019 13:49
@lrog
merging changes from master to dev (#75)
4957492 
* updating the examples to use the newest version of the docker images from dockerhub * version bump to 1.3.0 * Update README.md (#74) * Update README.md * Create HISTORY
@lrog
fixing the job repository auth connection + update tesseract
8dee872
@lrog
fixing travis build -- updating pip
66b1cd6
@lrog
fixing dockerhub build
0e32477
@lrog
fixing dockerhub build (update deps)
f7d2d08
@lrog
re-triggering travis build (dummy commit)
e84591e
@lrog
Test sqlserver (#77)
fa4c8ce 
* added postgresql docker image for tests; re-enabled sql server tests; reduce the number of processing threads from 16 to 8 * reverting changes (by mistake) in example 5 (NB: but using a randomised range for the timestamps needs to be re-visited)
@lrog
minor fix for user credentials for ES X-Pack when not using SSL
fc8228a
@lrog lrog changed the title Fix for the job repository auth problem Minor bugfixes May 10, 2019
@lrog lrog requested a review from afolarin May 13, 2019 07:52
@lrog lrog added this to the version-1.3.1 milestone May 13, 2019
afolarin
afolarin approved these changes May 13, 2019
View reviewed changes
Copy link
Contributor

@afolarin afolarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@lrog lrog merged commit 6669484 into master May 14, 2019
vladd-bit pushed a commit that referenced this pull request Nov 10, 2021
@lrog
Minor bugfixes (#76)
fb86ba1 
* merging changes from master to dev (#75) * updating the examples to use the newest version of the docker images from dockerhub * version bump to 1.3.0 * Update README.md (#74) * Update README.md * Create HISTORY * fixing the job repository auth connection + update tesseract * fixing travis build -- updating pip * fixing dockerhub build * fixing dockerhub build (update deps) * re-triggering travis build (dummy commit) * Test sqlserver (#77) * added postgresql docker image for tests; re-enabled sql server tests; reduce the number of processing threads from 16 to 8 * reverting changes (by mistake) in example 5 (NB: but using a randomised range for the timestamps needs to be re-visited) * minor fix for user credentials for ES X-Pack when not using SSL * modified the default ImageMagick configuration to prevent it from interrupting conversions of large documents (converted only partially) * added missing ImageMagick config file
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants

@lrog @afolarin