-
- Notifications
You must be signed in to change notification settings - Fork 304
FINALLY fixed the issue with GlobalState blowing up when pressing F5. #666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
<r>RED<r>
| I need to test this further but I'll let the rest of the team know |
| oh also btw if you guys could get F5 to work for resetting substates I'd appreciate it, but I couldn't figure out how to reset the current open substate so rip |
| I mean, i think at this point we can remove the global script from base assets |
| also like @SenDoesStuff was suggesting, this pr makes me more into the idea of having a developer mode in the options, for like accessing editors, some keybinds and more |
| No your right, but I just kept the file in so people can notice the file structure, and if we need to add anything there lol
|
nah imo just let em use the website for that |
| I was planning on making a pr on adding a Toolbox with the debug keys packaged in it, but I'm not sure if I really want to do that, but its been in my mind.
|
i'll see it myself since i'll do it in dev, dw |
| #14 cne flixel branch merged, testing new commit |
…Engine into f5-get-fucked
<r>disabling reloading substates cuz it broke...<r>
| ok pr should be good to go. Currently Reloading SubStates won't work because of overriding new functions, so it would be a weird fix to make it work, and that fix will break or be annoying to maintain, so until we can find a better one, reloading States should just be fine for now. |
| lemme check |
| ooh wait @NexIsDumb should we quickly add a keybind for console debug? |
| or whole other pr? |
nah i'll do smth like in dev as I've already planned |
This happened due to the GlobalScript in
assets/data/global.hxcontaining the code to reset the state being non functional, I wont explain in depth but basically spamming F5 caused it to blow up GlobalScripts.I removed ALL instances of the Source code using
FlxG.keys.justPressed.F5to a new Control KeyDEBUG_RELOADSo now you can set a custom keybind to reload states in the Options.
To reload GlobalScripts use
SHIFT+DEBUG_RELOAD.CURRENTLY THERE IS AN ISSUE, BUT IT'S FIXED IN THIS PR
once that is merged, this shouldn't cause any issues.
The issue?
It will reload twice, due to an oversight with updating the input AFTER
preUpdate... but elapsed is updated before it 😭anyways RED JUMPSCARE!!