Skip to content

Conversation

@THEkatinamicrowave
Copy link
Contributor

why was this not already implemented? Nevermind I'm pretty sure it's because parseBool isn't a thing

why was this not already implemented? Nevermind I'm pretty sure it's because parseBool isn't a thing
@THEkatinamicrowave
Copy link
Contributor Author

NOTE: this has NOT been playtested yet

@NeeEoo
Copy link
Contributor

NeeEoo commented Dec 12, 2024

Your repo is outdated, and removed features, please fix it before we merge

@THEkatinamicrowave
Copy link
Contributor Author

Your repo is outdated, and removed features, please fix it before we merge

noted. fixing stuff rn

gotta update my heckin repo
@THEkatinamicrowave
Copy link
Contributor Author

is dat gooood :>

@NeeEoo
Copy link
Contributor

NeeEoo commented Dec 13, 2024

Id move it down to above

if (node.has.updateHitbox && node.att.updateHitbox == "true") spr.updateHitbox();

and id make it like

if (node.has.flipX && node.att.flipX == "true") spr.flipX = true;
if (node.has.flipY && node.att.flipY == "true") spr.flipY = true;

rip parseBool but HAXE MAKE IT A THING
@SenDoesStuff
Copy link
Member

SenDoesStuff commented Dec 13, 2024

Make sure this works with characters as well. Iirc characters have a different useage of flipX from most sprites in PlayState

@THEkatinamicrowave
Copy link
Contributor Author

THEkatinamicrowave commented Dec 13, 2024

Make sure this works with characters as well. Iirc characters have a different useage of flipX from most sprites in PlayState

pretty sure that characters are added and handled differently than sprites. Sprites are FunkinSprite objects; characters are just extents of the Character class. I will double check though in case I'm dead wrong (feel free to laugh at and kill me)

@SenDoesStuff
Copy link
Member

Make sure this works with characters as well. Iirc characters have a different useage of flipX from most sprites in PlayState

pretty sure that characters are added and handled differently than sprites. Sprites are FunkinSprite objects; characters are just extents of the Character class. I will double check though in case I'm dead wrong (feel free to laugh at and kill me)

You’re correct, but the nodes for character positioning in stage xmls uses the same flipX from XMLUtils

@THEkatinamicrowave
Copy link
Contributor Author

I'm compiling it rn; if it works it works, if it doesn't I'll fix it
I'll update as soon as I can and realize something's wrong

@THEkatinamicrowave
Copy link
Contributor Author

sorry it's taking so long to proofread; I had to install hscript-improved and ran update.bat which is taking forever

@NeeEoo
Copy link
Contributor

NeeEoo commented Dec 13, 2024

I also said it put it above updateHitbox

¯\_(ツ)_/¯
@THEkatinamicrowave
Copy link
Contributor Author

k last night my computer was being fucky wucky but now I can actually test this and see if it works

@NexIsDumb
Copy link
Member

eh no need to check lowercase aswell, i mean look at updateHitbox
but tyy, imma prob merge it in the future

@NexIsDumb
Copy link
Member

aight peak gameplay

image

@NexIsDumb NexIsDumb merged commit 6e2877c into CodenameCrew:main Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants