Update code standards #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Naktibalda reviewed Jan 26, 2021
src/Codeception/Module/Symfony.php Outdated
| $autoLoader = codecept_root_dir() . 'vendor' . DIRECTORY_SEPARATOR . 'autoload.php'; | ||
| | ||
| if (file_exists($autoLoader)) { | ||
| require_once $autoLoader; |
Member
There was a problem hiding this comment.
This code is odd, I think its only purpose was to get CI working, because it runs composer install in two separate directories.
Member Author
There was a problem hiding this comment.
Yes, it seems that it is, and it is still necessary... if I remove it I get:
PHP Fatal error: Uncaught Error: Class 'Symfony\Component\HttpKernel\Kernel' not found in /home/runner/work/module-symfony/module-symfony/framework-tests/src/Kernel.php:12
So I opted to encapsulate it in a separate method improving its documentation:
/** * Ensures autoloader loading of additional directories. * It is only required for CI jobs to run correctly. */ private function requireAdditionalAutoloader(): void { $autoLoader = codecept_root_dir() . 'vendor' . DIRECTORY_SEPARATOR . 'autoload.php'; if (file_exists($autoLoader)) { require_once $autoLoader; } }
TavoNiievez changed the title Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.