Skip to content

Composer 2.0 compatibility #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from Oct 29, 2020
Merged

Composer 2.0 compatibility #62

merged 7 commits into from Oct 29, 2020

Conversation

@ghost
Copy link

@ghost ghost commented Oct 28, 2020

Seems to work fine with Composer 2.0, and "should" not break Composer 1.x compatibility.
@Tchiller Tchiller mentioned this pull request Oct 28, 2020
Closed
@ghost
Copy link
Author

ghost commented Oct 28, 2020

Got zero experience with Travis, but trying to see if we can get the tests to run using both 1.x and 2.x versions of composer.
@vctls
Copy link

vctls commented Oct 28, 2020 •
edited
Loading

Thank you for this!
Is the build stuck or something? I think it's been doing nothing for half an hour already.

Edit: nevermind, it just passed some more jobs. Just taking it's time, apparently.
@ghost
Copy link
Author

ghost commented Oct 28, 2020

Thank you for this!
Is the build stuck or something? I think it's been doing nothing for half an hour already.

Edit: nevermind, it just passed some more jobs. Just taking it's time, apparently.

Yea. Looks strange.. Did some googling, and apparently that happens to other builds also.. Thought it was related to the backgrounded PHP process, but looks like it's killed immediately after the codeception run...
@Slamdunk
Copy link
Contributor

Slamdunk commented Oct 29, 2020

🚢 🚀
@samdark samdark mentioned this pull request Oct 29, 2020
Merged
3 tasks
@Naktibalda Naktibalda merged commit e5df90e into Codeception:2.0 Oct 29, 2020
@Naktibalda
Copy link
Member

Naktibalda commented Oct 29, 2020

Merged and released. Please test 2.6.0
@vctls
Copy link

vctls commented Oct 29, 2020

Works for me 😊
@Slamdunk
Copy link
Contributor

Slamdunk commented Oct 29, 2020

I can confirm too 👍
@Naktibalda
Copy link
Member

Naktibalda commented Oct 29, 2020

@mwi-gofore Please take a look at #63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@vctls @Slamdunk @Naktibalda @samdark