Skip to content

Conversation

@thecoolwinter
Copy link
Collaborator

Description

  • Adds bold and italics support to the editor theme type.

Warning

This is a API-breaking change, merging this will require a minor version update when releasing.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Update example app default theme with bold and italics on strings, italics on comments, and bold on keywords.

Screen.Recording.2025-01-10.at.2.53.13.PM.mov
@austincondiff
Copy link
Collaborator

Make sure to compare with Xcode. The weights look a little light to me at first glance.

Standard weight should be Medium
Bold weight should be Bold

@thecoolwinter
Copy link
Collaborator Author

You're right it does seem a little light. The example app was using regular, but after upping it to medium it looks like bold isn't going much past medium. I'll look into it

@thecoolwinter
Copy link
Collaborator Author

thecoolwinter commented Jan 10, 2025

Screenshot 2025-01-10 at 5 20 18 PM

@austincondiff How does this look to you?

@austincondiff
Copy link
Collaborator

I think so. It's difficult to tell because the strings are also italicized. Can you instead post a screenshot with keywords in bold?

@thecoolwinter
Copy link
Collaborator Author

I think so. It's difficult to tell because the strings are also italicized. Can you instead post a screenshot with keywords in bold?

Uh oh they were bolded, I think they need to go one weight higher then.

@thecoolwinter
Copy link
Collaborator Author

thecoolwinter commented Jan 11, 2025

Okay two more attempts

Upped by 3 weight classes
Screenshot 2025-01-11 at 9 11 27 AM

Upped by 4 weight classes
Screenshot 2025-01-11 at 9 13 27 AM

@thecoolwinter thecoolwinter merged commit 17525ad into CodeEditApp:main Jan 11, 2025
2 checks passed
@thecoolwinter thecoolwinter deleted the feat/bold-italic-themes branch January 11, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants