Skip to content

Invalidate Visible Range, Responsive Language Update #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Invalidate Visible Range, Responsive Language Update #238

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
51a24cd
Highlight on Editing, Changing Language, Font Change
thecoolwinter Feb 24, 2024
c1fc90b
Merge branch 'CodeEditApp:main' into fix/highlighter-editing
thecoolwinter Feb 29, 2024
b5c7006
Reorder some invalidations
thecoolwinter Feb 29, 2024
1127507
Update visible set
thecoolwinter Feb 29, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reorder some invalidations
  • Loading branch information
@thecoolwinter
thecoolwinter committed Feb 29, 2024
commit b5c70065f616db87160ed82c6a7ded73ee2e42cb
7 changes: 4 additions & 3 deletions Sources/CodeEditSourceEditor/Highlighting/Highlighter.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,13 +112,14 @@ class Highlighter: NSObject {
guard let textView = self.textView else { return }
// Remove all current highlights. Makes the language setting feel snappier and tells the user we're doing
// something immediately.
validSet.removeAll()
pendingSet.removeAll()
highlightProvider?.setUp(textView: textView, codeLanguage: language)
textView.textStorage.setAttributes(
attributeProvider.attributesFor(nil),
range: NSRange(location: 0, length: textView.textStorage.length)
)
textView.layoutManager.invalidateLayoutForRect(textView.visibleRect)
validSet.removeAll()
pendingSet.removeAll()
highlightProvider?.setUp(textView: textView, codeLanguage: language)
invalidate()
}

Expand Down