Skip to content

Conversation

@austincondiff
Copy link
Collaborator

@austincondiff austincondiff commented Apr 25, 2023

Description

Not using theme highlight color when not using theme background. Instead, we are using system colors to highlight the current line.

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

When using the theme background...

image

When not using the theme background...

Before
image

After
image

Not using theme highlight color when not using theme background.
@austincondiff
Copy link
Collaborator Author

Any suggestions for how I can resolve that SwiftLint error?

@thecoolwinter
Copy link
Collaborator

As a quick fix for the lint error for now you could move the attributesFor method to the STTextViewController+Highlighter file.

@austincondiff
Copy link
Collaborator Author

@thecoolwinter thanks, that works!

@thecoolwinter thecoolwinter merged commit 2921e93 into CodeEditApp:main Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants