Skip to content

Conversation

@thecoolwinter
Copy link
Collaborator

Description

Fixes an issue with git status parsing where the substring indexing was off-by-one when creating the file string due to an index being incremented before creating a substring.

Fixes this by incrementing the current string index after returning the correct substring.

The related issue is marked as a Tahoe bug, the Tahoe bug is that Tahoe now shows the null character as a %00 at the end of the label, where previous macOS versions did not. This change is retroactive however as it is a bug fix.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

N/A

@thecoolwinter thecoolwinter added the bug Something isn't working label Sep 11, 2025
@thecoolwinter thecoolwinter merged commit 5c2d8ec into CodeEditApp:main Sep 15, 2025
1 of 2 checks passed
@thecoolwinter thecoolwinter deleted the fix/git-status-null-char branch September 15, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

1 participant