Skip to content

Conversation

thecoolwinter
Copy link
Collaborator

@thecoolwinter thecoolwinter commented Sep 4, 2025

Description

Updates the navigator, inspector, and utility area for the new Liquid Glass design.

Related Issues

Checklist

  • Navigator width doesn't work.
  • Padding on workspace panels wrong.
  • Padding, spacing, and size on filter is wrong.
  • Utility area toolbar clipping on window edge.
  • Utility area status bar height is wrong.
  • Utility area toolbar height is wrong.
  • Workspace panel tabs need background fill
  • Workspace panel tabs need stroke style
  • Workspace panel tabs need filled capsule selected style.
  • Filter bar on bottom needs to span width on side tab mode.
  • Project navigator selected item color is blue instead of white
  • Source control navigator lines need spacing on edges.
  • Source control navigator needs new tab style.
  • Source control repository list has large spacing.
  • Find navigator lines need spacing on edges.
  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Utility Area:

Screenshot_2025-09-03_at_5 08 48_PM Screenshot_2025-09-03_at_5 09 04_PM

Navigator

Screen.Recording.2025-09-04.at.3.56.43.PM.mov
commit 46f4e36 Author: Khan Winter <35942988+thecoolwinter@users.noreply.github.com> Date: Tue Sep 2 14:41:03 2025 -0500 Toolbar Opacity commit 79b49b3 Author: Khan Winter <35942988+thecoolwinter@users.noreply.github.com> Date: Fri Aug 29 16:45:12 2025 -0500 Correct Arrow Edge in Scheme Popover commit c2e7e70 Author: Khan Winter <35942988+thecoolwinter@users.noreply.github.com> Date: Fri Aug 29 16:37:39 2025 -0500 fix:lint commit 9408577 Author: Khan Winter <35942988+thecoolwinter@users.noreply.github.com> Date: Fri Aug 29 16:36:26 2025 -0500 Remove Unified Style (and fix the rabbit hole of bugs that caused) commit 22b5b93 Author: Khan Winter <35942988+thecoolwinter@users.noreply.github.com> Date: Fri Aug 29 12:38:53 2025 -0500 Adjust Task Notification View commit c7c30af Author: Khan Winter <35942988+thecoolwinter@users.noreply.github.com> Date: Fri Aug 29 11:58:05 2025 -0500 Update Popover Style commit bc152a0 Author: Khan Winter <35942988+thecoolwinter@users.noreply.github.com> Date: Fri Aug 29 11:37:46 2025 -0500 Use new WelcomeWindow Release commit 45aa64c Author: Khan Winter <35942988+thecoolwinter@users.noreply.github.com> Date: Fri Aug 29 11:32:43 2025 -0500 Finish Activity Viewer Pills commit 7e50ff9 Author: Khan Winter <35942988+thecoolwinter@users.noreply.github.com> Date: Thu Aug 28 16:22:32 2025 -0500 Adjust Branch Picker and Scheme Dropdown commit f39c497 Author: Khan Winter <35942988+thecoolwinter@users.noreply.github.com> Date: Thu Aug 28 16:22:17 2025 -0500 Fix Warning commit a4c879f Author: Khan Winter <35942988+thecoolwinter@users.noreply.github.com> Date: Thu Aug 28 16:22:11 2025 -0500 Add Start/Stop Task Toolbar Group commit 9d74f8a Author: Khan Winter <35942988+thecoolwinter@users.noreply.github.com> Date: Thu Aug 28 16:21:33 2025 -0500 Fix Concurrency Issues commit 1d590a9 Author: Khan Winter <35942988+thecoolwinter@users.noreply.github.com> Date: Thu Aug 28 16:20:58 2025 -0500 Update Project, Use local WelcomeWindow for now
commit 6218d89 Author: Khan Winter <35942988+thecoolwinter@users.noreply.github.com> Date: Thu Sep 4 10:09:23 2025 -0500 Revert Project File Changes commit 46f4e36 Author: Khan Winter <35942988+thecoolwinter@users.noreply.github.com> Date: Tue Sep 2 14:41:03 2025 -0500 Toolbar Opacity commit 79b49b3 Author: Khan Winter <35942988+thecoolwinter@users.noreply.github.com> Date: Fri Aug 29 16:45:12 2025 -0500 Correct Arrow Edge in Scheme Popover commit c2e7e70 Author: Khan Winter <35942988+thecoolwinter@users.noreply.github.com> Date: Fri Aug 29 16:37:39 2025 -0500 fix:lint commit 9408577 Author: Khan Winter <35942988+thecoolwinter@users.noreply.github.com> Date: Fri Aug 29 16:36:26 2025 -0500 Remove Unified Style (and fix the rabbit hole of bugs that caused) commit 22b5b93 Author: Khan Winter <35942988+thecoolwinter@users.noreply.github.com> Date: Fri Aug 29 12:38:53 2025 -0500 Adjust Task Notification View commit c7c30af Author: Khan Winter <35942988+thecoolwinter@users.noreply.github.com> Date: Fri Aug 29 11:58:05 2025 -0500 Update Popover Style commit bc152a0 Author: Khan Winter <35942988+thecoolwinter@users.noreply.github.com> Date: Fri Aug 29 11:37:46 2025 -0500 Use new WelcomeWindow Release commit 45aa64c Author: Khan Winter <35942988+thecoolwinter@users.noreply.github.com> Date: Fri Aug 29 11:32:43 2025 -0500 Finish Activity Viewer Pills commit 7e50ff9 Author: Khan Winter <35942988+thecoolwinter@users.noreply.github.com> Date: Thu Aug 28 16:22:32 2025 -0500 Adjust Branch Picker and Scheme Dropdown commit f39c497 Author: Khan Winter <35942988+thecoolwinter@users.noreply.github.com> Date: Thu Aug 28 16:22:17 2025 -0500 Fix Warning commit a4c879f Author: Khan Winter <35942988+thecoolwinter@users.noreply.github.com> Date: Thu Aug 28 16:22:11 2025 -0500 Add Start/Stop Task Toolbar Group commit 9d74f8a Author: Khan Winter <35942988+thecoolwinter@users.noreply.github.com> Date: Thu Aug 28 16:21:33 2025 -0500 Fix Concurrency Issues commit 1d590a9 Author: Khan Winter <35942988+thecoolwinter@users.noreply.github.com> Date: Thu Aug 28 16:20:58 2025 -0500 Update Project, Use local WelcomeWindow for now
@thecoolwinter thecoolwinter added the macOS Tahoe Issues for macOS Tahoe label Sep 4, 2025
@SilverMarcs
Copy link

For NavigatorFilterView, the textfield on Xcode on tahoe has less bright background.
for the selectionBackground in its file, setting
Color.white.opacity(0.09) insted of opacity of 0.24 mostly mimics corectly.
Also, for teh capsule stroke border around this textfield, the linewidth should be 1.00 instead of 1.25.

@SilverMarcs
Copy link

Screenshot 2025-09-08 at 6 08 40 PM

Thoughts on moving that picker to the top? the empty space below it upto the sidebar toggle button looks a bit weird

@thecoolwinter
Copy link
Collaborator Author

Thoughts on moving that picker to the top? the empty space below it upto the sidebar toggle button looks a bit weird

Not a bad idea, I didn't have a great idea for it but I can try that. Maybe slightly smaller icon sizes too there.

@austincondiff
Copy link
Collaborator

austincondiff commented Sep 8, 2025

We need to just keep in mind that debug controls will eventually need to go there. We initially had the tabs here but moved them because it felt weird to have them there when the drawer was closed.
image

We may look into placing them at the bottom of the drawer instead?

@thecoolwinter
Copy link
Collaborator Author

Screenshot 2025-09-08 at 1 29 04 PM Screenshot 2025-09-08 at 1 29 10 PM

Updated color and border width, thanks @SilverMarcs!

@thecoolwinter
Copy link
Collaborator Author

Screenshot 2025-09-08 at 1 39 43 PM

I don't mind this to be honest. Also for the breakpoint items we could move them down here to stay inside their container. Since we're using the utility area for more than just the debugger it might make sense here.

Screenshot 2025-09-08 at 1 39 43 PM
@thecoolwinter
Copy link
Collaborator Author

@austincondiff
Copy link
Collaborator

I think the breakpoint controls are there because the line numbers line up with the breakpoint toggle. Because you click a line number to add a breakpoint, it makes sense that enabling and disabling breakpoints are at the bottom of the line numbers. I think the tabs could go at the bottom left. Let me mock it up when I get a chance.

@thecoolwinter thecoolwinter marked this pull request as ready for review September 15, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

macOS Tahoe Issues for macOS Tahoe

3 participants