Skip to content

some tweaks #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
May 18, 2014
Merged

some tweaks #99

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
d7ebda4
Use release version
seuros May 14, 2014
15a0632
Fix test script
seuros May 14, 2014
b14b068
We just need activerecord
seuros May 14, 2014
eb9b34c
Use memory instead of file for sqlite
seuros May 14, 2014
155bd8d
update .gitignore
seuros May 14, 2014
2e40ac1
Correct dependency version
seuros May 14, 2014
cc88721
Add activerecord 3.1
seuros May 14, 2014
4fe20ec
spec_helper little cleanup
seuros May 14, 2014
a487a04
drop support for activerecord 3.1
seuros May 14, 2014
83aa2d4
Add optional test for activerecord edge
seuros May 14, 2014
44cd889
Add Rubinius to travix matrix
seuros May 14, 2014
4761d53
Updated README
seuros May 14, 2014
6bbb492
Syntax deprecation fix
seuros May 14, 2014
1b16bc8
Formatting
seuros May 15, 2014
a5cb56e
Test for Hierarchy Maintenance
seuros May 15, 2014
f6b2e69
revert syntax change (Not supported in AR3.2)
seuros May 15, 2014
5c8c804
Readme typo
seuros May 15, 2014
d497779
travis config typo.
seuros May 15, 2014
c8e9114
Assert valid keys to avoid typos and headaches
seuros May 15, 2014
ece5bfc
Remove deprecated syntax from label spec
seuros May 16, 2014
75a6d91
excluding tests
seuros May 16, 2014
912eb30
Add ruby head to travis
seuros May 16, 2014
d869ef7
Fast finish for travis and exclude incompatible build combination
seuros May 16, 2014
4f44e9b
corrected typo in .travis.yml
seuros May 16, 2014
56dce49
exclude Rubinius and AR3.2 from the matrix
seuros May 16, 2014
0f220e1
Let use appraisal
seuros May 17, 2014
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove deprecated syntax from label spec
  • Loading branch information
@seuros
seuros committed May 16, 2014
commit ece5bfc0040d03536c20eea5c584f240abc1035a
12 changes: 3 additions & 9 deletions spec/label_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,7 @@ def create_preorder_tree(suffix = "", &block)
b = c.parent
a = c.root
a.destroy
Label.exists?(a).should be_false
Label.exists?(b).should be_false
Label.exists?(c).should be_false
Label.exists?(id: [a.id,b.id,c.id]).should be_false
end
end

Expand Down Expand Up @@ -354,9 +352,7 @@ def children_name_and_order
c = Label.new(name: 'c')
b.add_child c
a.destroy
Label.exists?(a).should be_false
Label.exists?(b).should be_false
Label.exists?(c).should be_false
Label.exists?(id: [a.id,b.id,c.id]).should be_false
end

it "properly destroys descendents created with <<" do
Expand All @@ -366,9 +362,7 @@ def children_name_and_order
c = Label.new(name: 'c')
b.children << c
a.destroy
Label.exists?(a).should be_false
Label.exists?(b).should be_false
Label.exists?(c).should be_false
Label.exists?(id: [a.id,b.id,c.id]).should be_false
end
end

Expand Down