[jdbc-v2] Adds default port and restricts multiple endpoints #2489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
jdbc-v2/src/main/java/com/clickhouse/jdbc/internal/JdbcConfiguration.java Show resolved Hide resolved
jdbc-v2/src/test/java/com/clickhouse/jdbc/internal/JdbcConfigurationTest.java Show resolved Hide resolved
Contributor Author
enqueue changed the title 
chernser reviewed Jul 8, 2025
| { "jdbc:clickhouse://foo.bar?x==&y=z" }, | ||
| { "jdbc:clickhouse://localhost?☺=value1" }, | ||
| // multiple endpoints are invalid | ||
| { "jdbc:clickhouse://foo,bar" }, |
Contributor
There was a problem hiding this comment.
yes, multiple endpoints is what we do not plan to support:
- JDBC has datasources for multiple endpoints
- Client v2 has
addEndpoint()that will be used to add more endpoints when we support them.
chernser changed the title 
Contributor
| @enqueue thank you for the contribution! |
chernser approved these changes Jul 15, 2025
| @chernser Hi, Why not support multi node connections in the URL? How to use JDBC to connect multiple nodes? |
Contributor
| Good day, @stronglxp ! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
This PR ensures that valid JDBC URLs are also accepted as endpoints by Client.
JDBC URLs which contain multiple endpoints are considered invalid
This is an alternative PR to #2488 which supports the use of multiple endpoints in JDBC URLs.
Checklist