Skip to content

Adding string implementation #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 14, 2017
Merged

Adding string implementation #1

merged 2 commits into from
Nov 14, 2017

Conversation

karmoham
Copy link
Contributor

No description provided.

@karmoham karmoham requested review from jeaubin and simingy November 14, 2017 17:54
@karmoham karmoham changed the title Adding string implmentation Adding string implementation Nov 14, 2017
simingy
simingy suggested changes Nov 14, 2017
View reviewed changes
coding-102-parsers/strings.py Outdated
route-map RMAP8 out
'''

out = STRING
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need to assign out to STRING
just do for line in STRING.splitlines()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
coding-102-parsers/strings.py Outdated
# print the parsed built structure
print (PYTHON_DICT)

PYTHON_DICT = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a the expected output - comment it out so it's only for reference
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
coding-102-parsers/strings.py Outdated
continue

# print the parsed built structure
print (PYTHON_DICT)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import pprint; pprint.pprint()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
@simingy simingy merged commit 41ed04e into master Nov 14, 2017
@simingy simingy deleted the string_implementation branch November 14, 2017 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@karmoham @simingy