Skip to content

use allow-dev-deps label to block merging and allow non-binary dependencies #19210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

use allow-dev-deps label to block merging and allow non-binary dependencies #19210

wants to merge 16 commits into from

Conversation

@altendky
Copy link
Contributor

@altendky altendky commented Jan 30, 2025 •
edited
Loading

Purpose:

introduce usage of a label allow-dev-deps to:

  1. block merging by failing the check pr labels job
  2. skip jobs that tend to fail when building dev deps either because they are minimal docker installs, or explicitly checking that all dependencies are binary wheels, etc.
  3. allow developers to reference other branches of other repos, chia_rs for example, in PRs to check out integration with changes in those repos

Current Behavior:

New Behavior:

Testing Notes:

see #19211

Draft For:

  • consideration of handling for long lived branches
@altendky altendky added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog CI CI changes labels Jan 30, 2025
altendky added a commit that referenced this pull request Jan 30, 2025
@altendky
testing #19210
c487717
@altendky altendky mentioned this pull request Jan 30, 2025
Closed
@github-actions
Copy link
Contributor

This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed by the relevant parties.
@github-actions github-actions bot added the stale-pr Flagged as stale and in need of manual review label Mar 22, 2025
@altendky altendky mentioned this pull request Sep 17, 2025
Merged
altendky added a commit that referenced this pull request Sep 22, 2025
@altendky
back to full binary wheel checks etc (#20079)
8db5038 
<!-- Merging Requirements: - Please give your PR a title that is release-note friendly - In order to be merged, you must add the most appropriate category Label (Added, Changed, Fixed) to your PR --> <!-- Explain why this is an improvement (Does this add missing functionality, improve performance, or reduce complexity?) --> ### Purpose: side note, #19210 is an exploration of what a permanent version of this might look like. <!-- Does this PR introduce a breaking change? --> ### Current Behavior: ### New Behavior: <!-- As we aim for complete code coverage, please include details regarding unit, and regression tests --> ### Testing Notes: <!-- Attach any visual examples, or supporting evidence (attach any .gif/video/console output below) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changed Required label for PR that categorizes merge commit message as "Changed" for changelog CI CI changes stale-pr Flagged as stale and in need of manual review

2 participants

@altendky