Skip to content

[25.08.25 / TASK-247] Fix - Leaderboard 쿼리 결과값 버그 수정 #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 31, 2025
Merged

[25.08.25 / TASK-247] Fix - Leaderboard 쿼리 결과값 버그 수정 #44

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9ee243f
fix: 리더보드 비정상적인 집계값 수정
ooheunda Aug 25, 2025
9c00ceb
refactor: 중복된 날짜 계산 개선
ooheunda Aug 25, 2025
36dde5e
test: 통합 테스트에 버그 픽스한 부분 추가 및 skip 삭제
ooheunda Aug 25, 2025
af921f2
fix: 전체 데이터 수집 전(00시~01시)의 요청에 대한 방어로직 추가
ooheunda Aug 25, 2025
b39315a
fix: linting
ooheunda Aug 25, 2025
9d343be
refactor: 비정상 데이터 필터링 구문 개선
ooheunda Aug 27, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: 중복된 날짜 계산 개선
  • Loading branch information
@ooheunda
ooheunda committed Aug 25, 2025
commit 9c00cebc90a2f6db9c03b294d11d1a71b2755c4e
11 changes: 6 additions & 5 deletions src/repositories/leaderboard.repository.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export class LeaderboardRepository {
async getUserLeaderboard(sort: UserLeaderboardSortType, dateRange: number, limit: number) {
try {
const pastDateKST = getKSTDateStringWithOffset(-dateRange * 24 * 60);
const cteQuery = this.buildLeaderboardCteQuery(dateRange);
const cteQuery = this.buildLeaderboardCteQuery(dateRange, pastDateKST);

const query = `
${cteQuery}
Expand Down Expand Up @@ -46,7 +46,7 @@ export class LeaderboardRepository {
async getPostLeaderboard(sort: PostLeaderboardSortType, dateRange: number, limit: number) {
try {
const pastDateKST = getKSTDateStringWithOffset(-dateRange * 24 * 60);
const cteQuery = this.buildLeaderboardCteQuery(dateRange);
const cteQuery = this.buildLeaderboardCteQuery(dateRange, pastDateKST);

const query = `
${cteQuery}
Expand Down Expand Up @@ -83,10 +83,11 @@ export class LeaderboardRepository {
}

// 오늘 날짜와 기준 날짜의 통계를 가져오는 CTE(임시 결과 집합) 쿼리 빌드
private buildLeaderboardCteQuery(dateRange: number) {
private buildLeaderboardCteQuery(dateRange: number, pastDateKST?: string) {
const nowDateKST = getCurrentKSTDateString();
// 과거 날짜 계산 (dateRange일 전)
const pastDateKST = getKSTDateStringWithOffset(-dateRange * 24 * 60);
if (!pastDateKST) {
pastDateKST = getKSTDateStringWithOffset(-dateRange * 24 * 60);
}

return `
WITH
Expand Down