Skip to content

Conversation

@brianjgeiger
Copy link
Contributor

@brianjgeiger brianjgeiger commented Feb 3, 2021

Purpose

Add the hasProject boolean to draft-registrations. This matches up with the Platform PR CenterForOpenScience/osf.io#9607

Summary of Changes

  1. Add the attribute to the DraftRegistration model
  2. Add the attribute to the mirage factory

Side Effects

No, all additive. I made the mirage factory default work with all of the existing draft registrations in the default scenario and tests, so going forward with no project we can override as necessary.

QA Notes

Nothing testable yet.

Copy link
Member

@fabmiz fabmiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@adlius adlius merged commit 2138c52 into CenterForOpenScience:develop Feb 4, 2021
@fabmiz fabmiz added this to the 21.1.0 milestone Mar 12, 2021
@brianjgeiger brianjgeiger deleted the feature/draft-has-project-attribute branch January 20, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants