More unoconv fixes #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
felliott commented Apr 2, 2019
felliott commented - Bumping LO minor version requires updating path to LO's python binary. This will also require a PR to osf.io for local MFR development to work.
- Be explicit about debian release in the base python image
- More robust GPG handling by using multiple keyservers and disabling ipv6 lookup.
- Minor style adjustments: indentation, explicitly install/uninstall gpg
* The unpinned versions are upgraded when a new version of debian is released. This can cause breakage when packages are renamed, retired, or upgraded.
* Like curl, install before using and remove when done to ensure its presence.
* gpg key verification occasionally fails due to network issues when attempting to fetch keys. Combat this with two approaches: * Disable ipv6 testing in dirmngr.conf. [1] * Provide a fallback list of keyservers to pull from. [2] [1] usbarmory/usbarmory-debian-base_image#9 (comment) [2] tianon/gosu#39 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.