Api to set LifecycleOwner for BlurLayout #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- with the Lifecycle provided by the LifecycleOwner we can remove boilerplate calls to startBlur() and pauseBlur(). BlurLayout will implement Lifecycleobserver for this. - added dependency on android.arch.lifecycle:runtime:1.1.1 for the same - better not to use this API while using Java 8 Signed-off-by: Arka Prava Basu <arkaprava94@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Not sure if this change is welcomed. Let me know what you think anyways.
boilerplate calls to startBlur() and pauseBlur(). BlurLayout
will implement LifecycleObserver for this.
same