feat: Add viewup parameter to show in vis.py #1837
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This allows the user to setup the ViewUp position of the camera. The default is with Y up (0, 1, 0) but for projects like creating shapes for 3D printing Z up is more conventional. With this change it is difficult to manage. The default is Y up but that default can now be overridden by passing `viewup=(0, 0, 1)`
Contributor Author
| This isn't correct, I'm investigating a better solution. |
Contributor Author
| Closing, see discussion #1844 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This allows the user to change the ViewUp position of the camera. With this change the default remains Y up (0, 1, 0) so this is backwards compatible, but for projects like creating shapes for 3D printing, where Z up is more conventional, the ViewUp can be changed.