Skip to content

Add support for position: -webkit-sticky #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 27, 2017
Merged

Add support for position: -webkit-sticky #236

merged 3 commits into from
Oct 27, 2017

Conversation

toptalo
Copy link
Contributor

@toptalo toptalo commented Oct 5, 2017

  • add -webkit-sticky to availible positions list
  • add .idea/ folder to .gitignore for WebStorm
  • rebuild package
@toptalo toptalo mentioned this pull request Oct 5, 2017
Merged
@toptalo toptalo mentioned this pull request Oct 23, 2017
Closed
@stubbornella
Copy link
Member

Please separate your stylistic changes into a different PR and resubmit it.
@toptalo
Copy link
Contributor Author

toptalo commented Oct 25, 2017

Is this okay or it will be better to close this PR and make another one for more clean history?
With only one change
@stubbornella
Copy link
Member

It's fine, what do you think about adding a CSS validation test? Like maybe in this file:

parser-lib/tests/css/Validation.js

Line 1551 in 0263b2d

suite.add(new ValidationTestCase({

@toptalo
Copy link
Contributor Author

toptalo commented Oct 26, 2017

Added validation test
stubbornella
stubbornella approved these changes Oct 27, 2017
View reviewed changes
Copy link
Member

@stubbornella stubbornella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@stubbornella stubbornella merged commit f3e2dc6 into CSSLint:master Oct 27, 2017
@toptalo
Copy link
Contributor Author

toptalo commented Oct 27, 2017

Thanks!
@toptalo
Copy link
Contributor Author

toptalo commented Oct 31, 2017

Hello @stubbornella,
maybe you'll have time to see my other PR (#237, #238, #239)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@toptalo @stubbornella