chore: updated notify types to match from IBrowserSyncOptions #2093
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I was using BrowserSync within a different package and noticed that the types for the
notifyindicate that it's only a boolean:But it looks like the
IBrowserSyncOptionsinterface has the notify key accepting a CSS styles object or array of CSS style rules.I'm not as familiar with this project, so I just copied the type definition, but when I run a diff between the
InitOptionsandIBrowserSyncOptions, it looks like they're mostly the same except forInitOptionshaving:Should the types between these two things the same, or should we consider importing and extending
IBrowserSyncOptions?