Skip to content

DB: Updated entity scope to use models dynamic table #5878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ssddanbrown merged 3 commits into from
Nov 11, 2025
Merged

DB: Updated entity scope to use models dynamic table #5878

ssddanbrown merged 3 commits into from
Nov 11, 2025
+140 −5

Conversation

@ssddanbrown
Copy link
Member

@ssddanbrown ssddanbrown commented Nov 10, 2025 •
edited
Loading

This was hardcoded since the table was always the same, but in some cases Laravel will auto-alias the table name (for example, when in sub-queries) which will break MySQL 5.7 when the scope attempts to use the table name instead of the alias.

Needs testing coverage.
For #5877

Todo

  • Full testing against supported major MySQL/MariaDB versions.
    • MySQL 5.7
    • MySQL 8.0
    • MySQL 8.4
    • MySQL 9.5
    • MariaDB 10.2
    • MariaDB 10.6
    • MariaDB 10.11
    • MariaDB 11.4
    • MariaDB 11.8
    • MariaDB 12.0
  • Coverage of this scenario in test cases if possible (Start a query and inspect it?)
@ssddanbrown ssddanbrown self-assigned this Nov 10, 2025
@ssddanbrown
DB: Updated entity scope to use models dynamic table
4eb4407 
This was hardcoded since the table was always the same, but in some cases Laravel will auto-alias the table name (for example, when in sub-queries) which will break MySQL 5.7 when the scope attempts to use the table name instead of the alias. Needs testing coverage. For #5877
@ssddanbrown ssddanbrown mentioned this pull request Nov 10, 2025
Closed
2 tasks
@ssddanbrown
DB: Added initial DB testing docker-based script
befc645
@ssddanbrown
DB: Added extra query tests, updated db-testing scripts
8ab9252 
Also added skipping to avif tests for environments where GD does not have built-in AVIF support
@ssddanbrown ssddanbrown merged commit 8ab9252 into development Nov 11, 2025
16 checks passed
@ssddanbrown ssddanbrown deleted the fix_5877 branch December 5, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 Bug 🚀 Priority 🔧 Maintenance

2 participants

@ssddanbrown