Allow uploads of files containing dots in filename #2611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Failing checks seem to be a problem of the system: Will reopen to retrigger checks |
| @Hecke29 Thanks for this, Looks good from a quick initial review. Have assigned to next release. Don't worry too much about the failed runs, Think it's just a case of GitHub changing the base instance they run against, That's on me. |
ssddanbrown added a commit that referenced this pull request Mar 14, 2021
Updated testing for changes and to check existing of new expected file name. Related to #2611
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When I take screenshots on my MacBook it will create a file that contains the time with dots separated; e.g.
Bildschirmfoto 2021-03-04 um 18.29.58.I could never upload them directly to BookStack (that I use and recommend with multiple clients) but had to rename them before and today was the evening I want to change that.
Closes #2217