Create footer for regulatory links #1973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Findus23 suggested changes Apr 11, 2020
| @@ -0,0 +1,10 @@ | |||
| @if(setting('app-privacy-policy') | setting('app-terms-of-service')) | |||
There was a problem hiding this comment.
Suggested change
| @if(setting('app-privacy-policy') | setting('app-terms-of-service')) | |
| @if(setting('app-privacy-policy') or setting('app-terms-of-service')) |
I am not too familiar with blade templates, but without this change, I only get a lot of errors (I only entered a privacy policy link, but not a terms of service)
There was a problem hiding this comment.
What version of PHP are you running, out of curiosity?
There was a problem hiding this comment.
Thinking about it, I guess || would also be possible, but doesn't | do a bitwise or?
ssddanbrown added a commit that referenced this pull request Jan 31, 2021
Made so footer link ordering, names and urls can be set. Cleaned up some of the setting-service and added support for array setting types, which are cleaned on entry and stored as json with a new type indicator column on the settings table for auto-decode. Also added testing to cover this feature. Related to #1973 and #854
| Thank you for this PR @james-geiger and sorry for my late response. This all looked great, but I knew that people would probably want to change the wording and links so I built upon your work and made further changes in 44c41e9 to make this a configurable, order-able list. Will be part of the next feature release. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Per #854 and feedback from @ApertureDevelopment, provides a mechanism to add links to a privacy policy and terms of service from the settings page.
Currently would not display on the page editor pages, but am open to and welcome feedback. It just didn't seem to me to fit the flow very well with the full-page editor, but this could also be added as a setting as well.
@ssddanbrown, not sure what your thoughts are on limits to the number of "app settings" but this seemed like it would be a good fit for that section. Also purposely limited this to two different kinds of links. Could likely be abstracted into a feature where you could add any number of "custom footer links" each with a label and href, but this seemed like a good place to start.