Skip to content

Conversation

@anniek-valk
Copy link

… to README.md.

Description

To make sure no developers try to find out why the a video with audio on an Android emulator isn't working properly, I added it to the README.md.

Related Issues

Issue 42309

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.
@anniek-valk anniek-valk changed the title Added information of video not working correctly on Android emulators… [camera] Added information of video not working correctly on Android emulators… Oct 21, 2020
valconetti added 3 commits October 22, 2020 13:24
…ter-plugins into issue-42309 � Conflicts: �	packages/camera/CHANGELOG.md �	packages/camera/README.md
Copy link
Member

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the title of the PR so it fits on the same line and one small typo.

Co-authored-by: Maurits van Beusekom <maurits@vnbskm.nl>
Co-authored-by: Maurice Parrish <bmparr@google.com>
@mvanbeusekom mvanbeusekom deleted the issue-42309 branch September 21, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants