Skip to content

Conversation

@Hari-07
Copy link
Contributor

@Hari-07 Hari-07 commented Oct 10, 2024

The package wasn't currently handling the new CNAuthorizationStatusLimited introduce in ios18. Older versions of ios will remain unchanged. Here's a screen recording showcasing the change

  • ios 17.2
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2024-10-10.at.13.43.12.mp4
  • ios 18.0
Simulator.Screen.Recording.-.Logged.In.16.Pro.-.2024-10-10.at.13.46.09.mp4

List at least one fixed issue.

Pre-launch Checklist

  • I made sure the project builds.
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I rebased onto main.
  • I added new tests to check the change I am making, or this PR does not need tests.
  • I made sure all existing and new tests are passing.
  • I ran dart format . and committed any changes.
  • I ran flutter analyze and fixed any errors.
@Hari-07
Copy link
Contributor Author

Hari-07 commented Oct 10, 2024

The check failure of invoking prints seems to be from an old commit, not from my changes. Happy to remove them if required though

@kvenn
Copy link

kvenn commented Oct 14, 2024

Any update on when this would be merged? This looks good to me!

@levyanjos
Copy link

Any update on this? I have same issue with iOS 18

@HappyMakadiyaS
Copy link

Is there any update on this? As we have a client request for this feature.

@starshipcoder
Copy link

Any update ? Apple is deploying the 18.1 right now, I see customers with this issue

@amrgetment
Copy link

for those who want it before merging

dependency_overrides: # limited access on iOS 18 for contacts permission_handler_apple: git: url: https://github.com/sodality-tech/flutter-permission-handler.git ref: main path: permission_handler_apple 
@inamhusain
Copy link

inamhusain commented Dec 20, 2024

What about Android 14? it is directly show granted status

@Hari-07
Copy link
Contributor Author

Hari-07 commented Dec 20, 2024

What about Android 14? it is directly show granted status

Better to file a separate issue. This PR doesnt touch android

@s-alkami
Copy link

Hi @Hari-07 can this be merged this week? or can anyone share an update? iOS 18 has been out for 4 months now and this is causing issues for all users on that version

@Hari-07
Copy link
Contributor Author

Hari-07 commented Jan 30, 2025

@s-alkami I'd love to, but Im not a maintainer of this package so I dont have the access necessary. If you want you can use our fork like mentioned above, we have been using it for a while with no issues

dependency_overrides:
permission_handler_apple:
git:
url: https://github.com/sodality-tech/flutter-permission-handler.git
ref: main
path: permission_handler_apple

If the team wants me to make any changes before it can be merged I'd be open to it

@s-alkami
Copy link

s-alkami commented Jan 30, 2025

@s-alkami I'd love to, but Im not a maintainer of this package so I dont have the access necessary. If you want you can use our fork like mentioned above, we have been using it for a while with no issues

dependency_overrides:
permission_handler_apple:
git:
url: https://github.com/sodality-tech/flutter-permission-handler.git
ref: main
path: permission_handler_apple

If the team wants me to make any changes before it can be merged I'd be open to it

noted, thanks @mvanbeusekom - are there any maintainers who can review/merge this change to handle iOS 18 functionality?
cc @TimHoogstrate @BeMacized @martijn00 @jurijjzz

@husainazkas
Copy link

please do merge ASAP, it's been 4 months @mvanbeusekom

@mvanbeusekom mvanbeusekom changed the base branch from main to issue/1387 February 20, 2025 09:18
@mvanbeusekom mvanbeusekom merged commit ceac713 into Baseflow:issue/1387 Feb 20, 2025
0 of 2 checks passed
mvanbeusekom added a commit that referenced this pull request Feb 20, 2025
* Handle contacts limited permission (#1395) * Handle contacts limited permission * Version bump and comments * Resolve build errors and update example project * Update build configuration to use macos-latest * Only handle CNAuthorizationLimited on iOS 18+ * Force build workflow to use macOS 15 * Upgrade Example app --------- Co-authored-by: Hari07 <22373191+Hari-07@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

10 participants